MIPS: Remove unneeded volatile from arch/mips/lib/bitops.c
Subsystems (2)
PATCH 1/1 MIPS: Remove unneeded volatile from arch/mips/lib/bitops.c
From: David Daney <[email protected]>
The operations on the bitmap pointers are protected by "memory" clobbering raw_local_irq_{save,restore}(), so there is no need for volatile here. By removing the volatile we get better code generation out of the compiler.
Signed-off-by David Daney <[email protected]>
--- arch/mips/lib/bitops.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
arch/mips/lib/bitops.c +7 -7
@@ -19,7 +19,7 @@*/ void __mips_set_bit (unsigned long nr,volatile unsigned long *addr) { -volatile unsigned long *a = addr; +unsigned long *a = (unsigned long *)addr;unsigned bit = nr &SZLONG_MASK ;unsigned long mask;unsigned long flags;
@@ -41,7 +41,7 @@ EXPORT_SYMBOL(__mips_set_bit);*/ void __mips_clear_bit (unsigned long nr,volatile unsigned long *addr) { -volatile unsigned long *a = addr; +unsigned long *a = (unsigned long *)addr;unsigned bit = nr &SZLONG_MASK ;unsigned long mask;unsigned long flags;
@@ -63,7 +63,7 @@ EXPORT_SYMBOL(__mips_clear_bit);*/ void __mips_change_bit (unsigned long nr,volatile unsigned long *addr) { -volatile unsigned long *a = addr; +unsigned long *a = (unsigned long *)addr;unsigned bit = nr &SZLONG_MASK ;unsigned long mask;unsigned long flags;
@@ -86,7 +86,7 @@ EXPORT_SYMBOL(__mips_change_bit);int __mips_test_and_set_bit (unsigned long nr,volatile unsigned long *addr) { -volatile unsigned long *a = addr; +unsigned long *a = (unsigned long *)addr;unsigned bit = nr &SZLONG_MASK ;unsigned long mask;unsigned long flags;
@@ -112,7 +112,7 @@ EXPORT_SYMBOL(__mips_test_and_set_bit);int __mips_test_and_set_bit_lock (unsigned long nr,volatile unsigned long *addr) { -volatile unsigned long *a = addr; +unsigned long *a = (unsigned long *)addr;unsigned bit = nr &SZLONG_MASK ;unsigned long mask;unsigned long flags;
@@ -137,7 +137,7 @@ EXPORT_SYMBOL(__mips_test_and_set_bit_lock);*/ int __mips_test_and_clear_bit (unsigned long nr,volatile unsigned long *addr) { -volatile unsigned long *a = addr; +unsigned long *a = (unsigned long *)addr;unsigned bit = nr &SZLONG_MASK ;unsigned long mask;unsigned long flags;
@@ -162,7 +162,7 @@ EXPORT_SYMBOL(__mips_test_and_clear_bit);*/ int __mips_test_and_change_bit (unsigned long nr,volatile unsigned long *addr) { -volatile unsigned long *a = addr; +unsigned long *a = (unsigned long *)addr;unsigned bit = nr &SZLONG_MASK ;unsigned long mask;unsigned long flags;
Signature · 1 line
1.7.11.7