Skip to contentSkip to conversation

Adding USB 3.0 DRD-phy support for exynos5250

PATCH Superseded Vivek Gautam 4 participants 11 messages Feb 5, 2013 – Feb 27, 2013

Subsystems (2)

v5 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v5 cover Adding USB 3.0 DRD-phy support for exynos5250

Based on 'usb-next'

Changes from v4:
- Modifying function names and driver names to follow a common naming convention.
"usb2phy" for samsung-usb2phy driver
"usb3phy" for samsung-usb3phy driver
- Changing file names "samsung-usb2.c" to "samsung-usb2phy.c" and, "samsung-usb3.c" to "samsung-usb3phy.c"
- Removing dependencies for SAMSUNG_USB2PHY and SAMSUNG_USB3PHY.
- Arranging SAMSUNG_USB2PHY and SAMSUNG_USB3PHY to select SAMSUNG_USBPHY, which is the usb-phy helper driver.

Vivek Gautam (2):
usb: phy: samsung: Common out the generic stuff
usb: phy: samsung: Add PHY support for USB 3.0 controller

 drivers/usb/phy/Kconfig           |   25 +-
 drivers/usb/phy/Makefile          |    2 +
 drivers/usb/phy/samsung-usb2phy.c |  511 ++++++++++++++++++++++++++
 drivers/usb/phy/samsung-usb3phy.c |  349 ++++++++++++++++++
 drivers/usb/phy/samsung-usbphy.c  |  717 +------------------------------------
 drivers/usb/phy/samsung-usbphy.h  |  328 +++++++++++++++++
 6 files changed, 1219 insertions(+), 713 deletions(-)
 create mode 100644 drivers/usb/phy/samsung-usb2phy.c
 create mode 100644 drivers/usb/phy/samsung-usb3phy.c
 create mode 100644 drivers/usb/phy/samsung-usbphy.h
Signature · 1 line
1.7.6.5
#1 lore raw

PATCH v5 1/2 usb: phy: samsung: Common out the generic stuff

Moving register and structure definitions to header file, and keeping the generic functions to be used across multiple PHYs in common phy helper driver under SAMSUNG_USBPHY, and moving USB 2.0 PHY driver under SAMSUNG_USB2PHY.

---
 drivers/usb/phy/Kconfig           |   17 +-
 drivers/usb/phy/Makefile          |    1 +
 drivers/usb/phy/samsung-usb2phy.c |  511 ++++++++++++++++++++++++++
 drivers/usb/phy/samsung-usbphy.c  |  717 +------------------------------------
 drivers/usb/phy/samsung-usbphy.h  |  247 +++++++++++++
 5 files changed, 780 insertions(+), 713 deletions(-)
 create mode 100644 drivers/usb/phy/samsung-usb2phy.c
 create mode 100644 drivers/usb/phy/samsung-usbphy.h
drivers/usb/phy/Kconfig +12 -5
index 65217a5..b28878d 100644
@@ -66,10 +66,17 @@ config USB_RCAR_PHY
 	  To compile this driver as a module, choose M here: the
 	  module will be called rcar-phy.
 
-config SAMSUNG_USBPHY
-	bool "Samsung USB PHY controller Driver"
-	depends on USB_S3C_HSOTG || USB_EHCI_S5P || USB_OHCI_EXYNOS
+config SAMSUNG_USB2PHY
+	bool "Samsung USB 2.0 PHY controller Driver"
+	select SAMSUNG_USBPHY
 	select USB_OTG_UTILS
 	help
-	  Enable this to support Samsung USB phy controller for samsung
-	  SoCs.
+	  Enable this to support Samsung USB 2.0 (High Speed) PHY controller
+	  driver for Samsung SoCs.
+
+config SAMSUNG_USBPHY
+	bool "Samsung USB PHY Driver"
+	help
+	  Enable this to support Samsung USB phy helper driver for Samsung SoCs.
+	  This driver provides common interface to interact, for Samsung USB 2.0 PHY
+	  driver and later for Samsung USB 3.0 PHY driver.
drivers/usb/phy/Makefile +1 -0
index b13faa1..1efa174 100644
@@ -12,3 +12,4 @@ obj-$(CONFIG_MV_U3D_PHY)		+= mv_u3d_phy.o
 obj-$(CONFIG_USB_EHCI_TEGRA)	+= tegra_usb_phy.o
 obj-$(CONFIG_USB_RCAR_PHY)		+= rcar-phy.o
 obj-$(CONFIG_SAMSUNG_USBPHY)		+= samsung-usbphy.o
+obj-$(CONFIG_SAMSUNG_USB2PHY)		+= samsung-usb2phy.o
drivers/usb/phy/samsung-usb2phy.c new file +511 -0

511 lines not on this page · raw message

drivers/usb/phy/samsung-usbphy.c +9 -708

764 lines not on this page · raw message

drivers/usb/phy/samsung-usbphy.h new file +247 -0

247 lines not on this page · raw message

Signature · 1 line
1.7.6.5
#2 lore raw

PATCH v5 2/2 usb: phy: samsung: Add PHY support for USB 3.0 controller

In reply to Vivek Gautam

Adding PHY driver support for USB 3.0 controller for Samsung's SoCs.

---
 drivers/usb/phy/Kconfig           |    8 +
 drivers/usb/phy/Makefile          |    1 +
 drivers/usb/phy/samsung-usb3phy.c |  349 +++++++++++++++++++++++++++++++++++++
 drivers/usb/phy/samsung-usbphy.h  |   81 +++++++++
 4 files changed, 439 insertions(+), 0 deletions(-)
 create mode 100644 drivers/usb/phy/samsung-usb3phy.c
drivers/usb/phy/Kconfig +8 -0
index b28878d..723d7b1 100644
@@ -74,6 +74,14 @@ config SAMSUNG_USB2PHY
 	  Enable this to support Samsung USB 2.0 (High Speed) PHY controller
 	  driver for Samsung SoCs.
 
+config SAMSUNG_USB3PHY
+	bool "Samsung USB 3.0 PHY controller Driver"
+	select SAMSUNG_USBPHY
+	select USB_OTG_UTILS
+	help
+	  Enable this to support Samsung USB 3.0 (Super Speed) phy controller
+	  for samsung SoCs.
+
 config SAMSUNG_USBPHY
 	bool "Samsung USB PHY Driver"
 	help
drivers/usb/phy/Makefile +1 -0
index 1efa174..77f0b2e 100644
@@ -13,3 +13,4 @@ obj-$(CONFIG_USB_EHCI_TEGRA)	+= tegra_usb_phy.o
 obj-$(CONFIG_USB_RCAR_PHY)		+= rcar-phy.o
 obj-$(CONFIG_SAMSUNG_USBPHY)		+= samsung-usbphy.o
 obj-$(CONFIG_SAMSUNG_USB2PHY)		+= samsung-usb2phy.o
+obj-$(CONFIG_SAMSUNG_USB3PHY)		+= samsung-usb3phy.o
drivers/usb/phy/samsung-usb3phy.c new file +349 -0

349 lines not on this page · raw message

drivers/usb/phy/samsung-usbphy.h +81 -0

87 lines not on this page · raw message

Signature · 1 line
1.7.6.5
Acked-by Kukjin Kim on the v5 series
#3 lore raw
In reply to Vivek Gautam
Quoted 20 lines · Vivek Gautam

Based on 'usb-next'

Changes from v4:
- Modifying function names and driver names to follow a common naming convention.
"usb2phy" for samsung-usb2phy driver
"usb3phy" for samsung-usb3phy driver
- Changing file names "samsung-usb2.c" to "samsung-usb2phy.c" and, "samsung-usb3.c" to "samsung-usb3phy.c"
- Removing dependencies for SAMSUNG_USB2PHY and
SAMSUNG_USB3PHY.
- Arranging SAMSUNG_USB2PHY and SAMSUNG_USB3PHY to select
SAMSUNG_USBPHY,
which is the usb-phy helper driver.

Vivek Gautam (2):
usb: phy: samsung: Common out the generic stuff
usb: phy: samsung: Add PHY support for USB 3.0 controller

Quoted 6 lines
 drivers/usb/phy/Kconfig           |   25 +-
 drivers/usb/phy/Makefile          |    2 +
 drivers/usb/phy/samsung-usb2phy.c |  511
++++++++++++++++++++++++++
 drivers/usb/phy/samsung-usb3phy.c |  349 ++++++++++++++++++
 drivers/usb/phy/samsung-usbphy.c  |  717
+------------------------------------
>  drivers/usb/phy/samsung-usbphy.h  |  328 +++++++++++++++++
>  6 files changed, 1219 insertions(+), 713 deletions(-)
>  create mode 100644 drivers/usb/phy/samsung-usb2phy.c
>  create mode 100644 drivers/usb/phy/samsung-usb3phy.c
>  create mode 100644 drivers/usb/phy/samsung-usbphy.h
Quoted 3 lines

--
1.7.6.5

For now, looks good to me, and if any enhancement is required, it can be done next time.

Felipe, please go ahead with my ack :-)

Thanks.

- Kukjin

#4 lore raw
Quoted 34 lines · On Tue, Feb 12, 2013 at 10:31:00PM -0800…
Quoted 20 lines · Vivek Gautam

Based on 'usb-next'

Changes from v4:
- Modifying function names and driver names to follow a common naming convention.
"usb2phy" for samsung-usb2phy driver
"usb3phy" for samsung-usb3phy driver
- Changing file names "samsung-usb2.c" to "samsung-usb2phy.c" and, "samsung-usb3.c" to "samsung-usb3phy.c"
- Removing dependencies for SAMSUNG_USB2PHY and
SAMSUNG_USB3PHY.
- Arranging SAMSUNG_USB2PHY and SAMSUNG_USB3PHY to select
SAMSUNG_USBPHY,
which is the usb-phy helper driver.

Vivek Gautam (2):
usb: phy: samsung: Common out the generic stuff
usb: phy: samsung: Add PHY support for USB 3.0 controller

Quoted 6 lines
 drivers/usb/phy/Kconfig           |   25 +-
 drivers/usb/phy/Makefile          |    2 +
 drivers/usb/phy/samsung-usb2phy.c |  511
++++++++++++++++++++++++++
 drivers/usb/phy/samsung-usb3phy.c |  349 ++++++++++++++++++
 drivers/usb/phy/samsung-usbphy.c  |  717
+------------------------------------
>  drivers/usb/phy/samsung-usbphy.h  |  328 +++++++++++++++++
>  6 files changed, 1219 insertions(+), 713 deletions(-)
>  create mode 100644 drivers/usb/phy/samsung-usb2phy.c
>  create mode 100644 drivers/usb/phy/samsung-usb3phy.c
>  create mode 100644 drivers/usb/phy/samsung-usbphy.h
Quoted 1 line
Quoted 8 lines
Quoted 2 lines

--
1.7.6.5

For now, looks good to me, and if any enhancement is required, it can be done next time.

Felipe, please go ahead with my ack :-)

Thank you, but it's too late for v3.9, this will have to wait until v3.10. You will get an email once I apply these to my branch.

Cheers

Signature · 1 line
balbi

_______________________________________________
devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/[email protected]
https://lists.ozlabs.org/listinfo/devicetree-discuss

#5 lore raw
Quoted 38 lines · Felipe Balbi
Quoted 37 lines · On Tue, Feb 12, 2013 at 10:31:00PM -0800, [email protected] wrote:
Quoted 20 lines · Vivek Gautam

Based on 'usb-next'

Changes from v4:
- Modifying function names and driver names to follow a common naming convention.
"usb2phy" for samsung-usb2phy driver
"usb3phy" for samsung-usb3phy driver
- Changing file names "samsung-usb2.c" to "samsung-usb2phy.c" and, "samsung-usb3.c" to "samsung-usb3phy.c"
- Removing dependencies for SAMSUNG_USB2PHY and
SAMSUNG_USB3PHY.
- Arranging SAMSUNG_USB2PHY and SAMSUNG_USB3PHY to select
SAMSUNG_USBPHY,
which is the usb-phy helper driver.

Vivek Gautam (2):
usb: phy: samsung: Common out the generic stuff
usb: phy: samsung: Add PHY support for USB 3.0 controller

Quoted 6 lines
 drivers/usb/phy/Kconfig           |   25 +-
 drivers/usb/phy/Makefile          |    2 +
 drivers/usb/phy/samsung-usb2phy.c |  511
++++++++++++++++++++++++++
 drivers/usb/phy/samsung-usb3phy.c |  349 ++++++++++++++++++
 drivers/usb/phy/samsung-usbphy.c  |  717
+------------------------------------
>  drivers/usb/phy/samsung-usbphy.h  |  328 +++++++++++++++++
>  6 files changed, 1219 insertions(+), 713 deletions(-)
>  create mode 100644 drivers/usb/phy/samsung-usb2phy.c
>  create mode 100644 drivers/usb/phy/samsung-usb3phy.c
>  create mode 100644 drivers/usb/phy/samsung-usbphy.h
Quoted 3 lines

--
1.7.6.5

Quoted 9 lines
Quoted 5 lines

For now, looks good to me, and if any enhancement is required, it can be done next time.

Felipe, please go ahead with my ack :-)

Thank you, but it's too late for v3.9, this will have to wait until v3.10. You will get an email once I apply these to my branch.

Sure, thanks :)

Signature · 2 lines
Thanks & Regards
Vivek
#6 lore raw

PATCH 1/1 usb: phy: samsung: let it be built as a module

There's no reason not to allow samsung PHY
drivers be built as modules. This patch changes
Kconfig to allow that.

---

Hi,

I will take your patches but I'm planning to add this on top as there is no reason not to allow these drivers being built as modules.

cheers

 drivers/usb/phy/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/usb/phy/Kconfig +3 -3
index 723d7b1..4f696d0 100644
@@ -67,7 +67,7 @@ config USB_RCAR_PHY
 	  module will be called rcar-phy.
 
 config SAMSUNG_USB2PHY
-	bool "Samsung USB 2.0 PHY controller Driver"
+	tristate "Samsung USB 2.0 PHY controller Driver"
 	select SAMSUNG_USBPHY
 	select USB_OTG_UTILS
 	help
@@ -75,7 +75,7 @@ config SAMSUNG_USB2PHY
 	  driver for Samsung SoCs.
 
 config SAMSUNG_USB3PHY
-	bool "Samsung USB 3.0 PHY controller Driver"
+	tristate "Samsung USB 3.0 PHY controller Driver"
 	select SAMSUNG_USBPHY
 	select USB_OTG_UTILS
 	help
@@ -83,7 +83,7 @@ config SAMSUNG_USB3PHY
 	  for samsung SoCs.
 
 config SAMSUNG_USBPHY
-	bool "Samsung USB PHY Driver"
+	tristate "Samsung USB PHY Driver"
 	help
 	  Enable this to support Samsung USB phy helper driver for Samsung SoCs.
 	  This driver provides common interface to interact, for Samsung USB 2.0 PHY
Signature · 1 line
1.8.1.rc1.5.g7e0651a
#7 lore raw

Re: [PATCH] usb: phy: samsung: let it be built as a module

Hi Felipe,

Quoted 4 lines · Felipe Balbi

There's no reason not to allow samsung PHY
drivers be built as modules. This patch changes
Kconfig to allow that.

Quoted 9 lines

---

Hi,

I will take your patches but I'm planning to add this on top as there is no reason not to allow these drivers being built as modules.

aargh !! my bad :-(
actually missed exporting the symbols in drivers/usb/phy/samsung-usbphy.c Getting compile errors.
Shall i just update the patch [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250
or send a separate patch on top so that you can squash this change along with. ;-)

Quoted 39 lines

cheers

 drivers/usb/phy/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/usb/phy/Kconfig +3 -4
index 723d7b1..4f696d0 100644
@@ -67,7 +67,7 @@ config USB_RCAR_PHY
          module will be called rcar-phy.
 
 config SAMSUNG_USB2PHY
-       bool "Samsung USB 2.0 PHY controller Driver"
+       tristate "Samsung USB 2.0 PHY controller Driver"
        select SAMSUNG_USBPHY
        select USB_OTG_UTILS
        help
@@ -75,7 +75,7 @@ config SAMSUNG_USB2PHY
          driver for Samsung SoCs.
 
 config SAMSUNG_USB3PHY
-       bool "Samsung USB 3.0 PHY controller Driver"
+       tristate "Samsung USB 3.0 PHY controller Driver"
        select SAMSUNG_USBPHY
        select USB_OTG_UTILS
        help
@@ -83,7 +83,7 @@ config SAMSUNG_USB3PHY
          for samsung SoCs.
 
 config SAMSUNG_USBPHY
-       bool "Samsung USB PHY Driver"
+       tristate "Samsung USB PHY Driver"
        help
          Enable this to support Samsung USB phy helper driver for Samsung SoCs.
          This driver provides common interface to interact, for Samsung USB 2.0 PHY
--

1.8.1.rc1.5.g7e0651a

Signature · 2 lines
Thanks & Regards
Vivek
#8 lore raw

Re: [PATCH] usb: phy: samsung: let it be built as a module

Hi,

Quoted 18 lines · Vivek Gautam

Hi Felipe,

Quoted 4 lines · Felipe Balbi

There's no reason not to allow samsung PHY
drivers be built as modules. This patch changes
Kconfig to allow that.

Quoted 9 lines

---

Hi,

I will take your patches but I'm planning to add this on top as there is no reason not to allow these drivers being built as modules.

Quoted 7 lines

aargh !! my bad :-(
actually missed exporting the symbols in drivers/usb/phy/samsung-usbphy.c Getting compile errors.
Shall i just update the patch [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250
or send a separate patch on top so that you can squash this change along with. ;-)

there's still time to update the original. I'll drop all 3 patches for now (both of yours and mine).

cheers

Signature · 1 line
balbi
#9 lore raw

Re: [PATCH] usb: phy: samsung: let it be built as a module

Quoted 29 lines · Felipe Balbi

Hi,

Quoted 18 lines · Vivek Gautam

Hi Felipe,

Quoted 4 lines · Felipe Balbi

There's no reason not to allow samsung PHY
drivers be built as modules. This patch changes
Kconfig to allow that.

Quoted 9 lines

---

Hi,

I will take your patches but I'm planning to add this on top as there is no reason not to allow these drivers being built as modules.

Quoted 7 lines

aargh !! my bad :-(
actually missed exporting the symbols in drivers/usb/phy/samsung-usbphy.c Getting compile errors.
Shall i just update the patch [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250
or send a separate patch on top so that you can squash this change along with. ;-)

Quoted 3 lines

there's still time to update the original. I'll drop all 3 patches for now (both of yours and mine).

Alright, i shall update the original patches and resend them after adding this change for
EXPORT_SYMBOL_GPL() and also squashing your change for "modules".

Signature · 2 lines
Thanks & Regards
Vivek
#10 lore raw

Re: [PATCH] usb: phy: samsung: let it be built as a module

Quoted 30 lines · Vivek Gautam
Quoted 29 lines · Felipe Balbi

Hi,

Quoted 25 lines · Vivek Gautam

Hi Felipe,

Quoted 4 lines · Felipe Balbi

There's no reason not to allow samsung PHY
drivers be built as modules. This patch changes
Kconfig to allow that.

Quoted 9 lines

---

Hi,

I will take your patches but I'm planning to add this on top as there is no reason not to allow these drivers being built as modules.

aargh !! my bad :-(
actually missed exporting the symbols in drivers/usb/phy/samsung-usbphy.c Getting compile errors.
Shall i just update the patch [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250
or send a separate patch on top so that you can squash this change along with. ;-)

Quoted 7 lines
Quoted 3 lines

there's still time to update the original. I'll drop all 3 patches for now (both of yours and mine).

Alright, i shall update the original patches and resend them after adding this change for
EXPORT_SYMBOL_GPL() and also squashing your change for "modules".

k, thanks

Signature · 1 line
balbi