Skip to contentSkip to conversation

ARM: tegra: make bounce buffer option

PATCH Superseded Stephen Warren 3 participants 5 messages Feb 26, 2013 – Feb 28, 2013 Tegra architecture support

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: tegra: make bounce buffer option

From: Stephen Warren <[email protected]>

All Tegra devices will need CONFIG_BOUNCE_BUFFER. Move it to tegra-common.h to ensure it's always set.

---
These are useful on top of Tom's Tegra30 MMC series.

 include/configs/tegra-common.h   |    3 +++
 include/configs/tegra20-common.h |    3 ---
 include/configs/tegra30-common.h |    3 ---
 3 files changed, 3 insertions(+), 6 deletions(-)
include/configs/tegra-common.h +3 -0
index 4a656bb..a3cb5b9 100644
@@ -157,4 +157,7 @@
 #define CONFIG_SPL_SERIAL_SUPPORT
 #define CONFIG_SPL_GPIO_SUPPORT
 
+/* Misc utility code */
+#define CONFIG_BOUNCE_BUFFER
+
 #endif /* _TEGRA_COMMON_H_ */
include/configs/tegra20-common.h +0 -3
index 186e023..c51de00 100644
@@ -120,7 +120,4 @@
 #define CONFIG_SYS_NAND_SELF_INIT
 #define CONFIG_SYS_NAND_ONFI_DETECTION
 
-/* Misc utility code */
-#define CONFIG_BOUNCE_BUFFER
-
 #endif /* _TEGRA20_COMMON_H_ */
include/configs/tegra30-common.h +0 -3
index 82b1c07..f6c07c6 100644
@@ -92,7 +92,4 @@
 /* Total I2C ports on Tegra30 */
 #define TEGRA_I2C_NUM_CONTROLLERS	5
 
-/* Misc utility code */
-#define CONFIG_BOUNCE_BUFFER
-
 #endif /* _TEGRA30_COMMON_H_ */
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 2/2 ARM: tegra: make CONFIG_CMD_PART common

From: Stephen Warren <[email protected]>

This is useful on all Tegras, so that boot.scr on all devices can use the same commands. Hence, move it to tegra-common.h.

---
 include/configs/tegra-common.h   |    2 ++
 include/configs/tegra20-common.h |    3 ---
 2 files changed, 2 insertions(+), 3 deletions(-)
include/configs/tegra-common.h +2 -0
index a3cb5b9..45f0099 100644
@@ -141,6 +141,8 @@
 #define CONFIG_CMD_GPIO
 #define CONFIG_CMD_ENTERRCM
 #define CONFIG_CMD_BOOTZ
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_CMD_PART
 
 /* Defines for SPL */
 #define CONFIG_SPL
include/configs/tegra20-common.h +0 -3
index c51de00..e464e06 100644
@@ -114,9 +114,6 @@
 /* Total I2C ports on Tegra20 */
 #define TEGRA_I2C_NUM_CONTROLLERS	4
 
-#define CONFIG_PARTITION_UUIDS
-#define CONFIG_CMD_PART
-
 #define CONFIG_SYS_NAND_SELF_INIT
 #define CONFIG_SYS_NAND_ONFI_DETECTION
 
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 2/2 ARM: tegra: make CONFIG_CMD_PART common

Quoted 2 lines · Stephen Warren

This is useful on all Tegras, so that boot.scr on all devices can use the same commands. Hence, move it to tegra-common.h.

Unfortunately, this breaks Tegra114 builds because no partition types are enabled, and CONFIG_CMD_PART requires functionality that's only enabled if some partition types are supported.

There are two possible solutions:

1) Conditionally enable PARTITION_UUIDS and CMD_PART in tegra-common-post.h only if some partition type is enabled.

2) Also enable DOS and EFI partitions in tegra-common.h, along with all of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards this won't be any change. For the Colibri T20 and Avionic Design boards, this ends up enabling a few more options.

(or perhaps enable all of those in tegra-common-post.h only if support for any block device is enabled)

I prefer option (2). Does anyone object?

#3 lore raw

PATCH 2/2 ARM: tegra: make CONFIG_CMD_PART common

Quoted 18 lines · Stephen Warren
Quoted 2 lines · Stephen Warren

This is useful on all Tegras, so that boot.scr on all devices can use the same commands. Hence, move it to tegra-common.h.

Unfortunately, this breaks Tegra114 builds because no partition types are enabled, and CONFIG_CMD_PART requires functionality that's only enabled if some partition types are supported.

There are two possible solutions:

1) Conditionally enable PARTITION_UUIDS and CMD_PART in tegra-common-post.h only if some partition type is enabled.

2) Also enable DOS and EFI partitions in tegra-common.h, along with all of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards this won't be any change. For the Colibri T20 and Avionic Design boards, this ends up enabling a few more options.

Quoted 4 lines

(or perhaps enable all of those in tegra-common-post.h only if support for any block device is enabled)

I prefer option (2). Does anyone object?

Fine with me. I recently posted patches that enable some of these options as part of boot script support on Tamonten boards anyway.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130227/6b0a7ae4/attachment.pgp>

#4 lore raw

PATCH 2/2 ARM: tegra: make CONFIG_CMD_PART common

In reply to Stephen Warren

Am Mittwoch, den 27.02.2013, 14:03 -0700 schrieb Stephen Warren:

Quoted 18 lines · Stephen Warren
Quoted 2 lines

This is useful on all Tegras, so that boot.scr on all devices can use the same commands. Hence, move it to tegra-common.h.

Unfortunately, this breaks Tegra114 builds because no partition types are enabled, and CONFIG_CMD_PART requires functionality that's only enabled if some partition types are supported.

There are two possible solutions:

1) Conditionally enable PARTITION_UUIDS and CMD_PART in tegra-common-post.h only if some partition type is enabled.

2) Also enable DOS and EFI partitions in tegra-common.h, along with all of FS_EXT4, FS_FAT, CMD_EXT2, CMD_FAT, CMD_FS_GENERIC. For most boards this won't be any change. For the Colibri T20 and Avionic Design boards, this ends up enabling a few more options.

Quoted 5 lines

(or perhaps enable all of those in tegra-common-post.h only if support for any block device is enabled)

I prefer option (2). Does anyone object?

No objections. There is no real reason to leave out all those options as we are not size limited on the Colibri.

Regards,
Lucas