Skip to contentSkip to conversation

What to set uart_port->irq to for polled driver?

DISCUSSION Grant Edwards 2 participants 5 messages Feb 13, 2013 – Feb 28, 2013 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

For a polled serial driver that doesn't use interrupts, to what should the "irq" field in the uart_port structure be set? Should it be 0? Should it be the unused IRQ associated with the PCI card slot in which the board is found?

Signature · 3 lines
Grant Edwards               grant.b.edwards        Yow! MERYL STREEP is my
                                  at               obstetrician!
                              gmail.com            
#1 lore raw
Quoted 4 lines · Grant Edwards

For a polled serial driver that doesn't use interrupts, to what should the "irq" field in the uart_port structure be set? Should it be 0? Should it be the unused IRQ associated with the PCI card slot in which the board is found?

Doesn't look supported, but adding the support doesn't look difficult. At the very least, a patch is required so that on port shutdown, the core doesn't synchronize_irq().

Regards,
Peter Hurley

#2 lore raw
Quoted 9 lines · Peter Hurley
Quoted 4 lines · Grant Edwards

For a polled serial driver that doesn't use interrupts, to what should the "irq" field in the uart_port structure be set? Should it be 0? Should it be the unused IRQ associated with the PCI card slot in which the board is found?

Doesn't look supported, but adding the support doesn't look difficult. At the very least, a patch is required so that on port shutdown, the core doesn't synchronize_irq().

Does the call ty synchronize_irq() do any harm? AFAICT, it will just cause a short delay if handling of that IRQ is in-progress.

I currently set the "irq" field to the IRQ number that would be used by the board if I did choose to enable interrupts. That seems to work fine (with rather limited testing).

Signature · 3 lines
Grant Edwards               grant.b.edwards        Yow! We just joined the
                                  at               civil hair patrol!
                              gmail.com            
#3 lore raw
Quoted 11 lines · Grant Edwards
Quoted 9 lines · Peter Hurley
Quoted 4 lines · Grant Edwards

For a polled serial driver that doesn't use interrupts, to what should the "irq" field in the uart_port structure be set? Should it be 0? Should it be the unused IRQ associated with the PCI card slot in which the board is found?

Doesn't look supported, but adding the support doesn't look difficult. At the very least, a patch is required so that on port shutdown, the core doesn't synchronize_irq().

Quoted 6 lines

Does the call ty synchronize_irq() do any harm? AFAICT, it will just cause a short delay if handling of that IRQ is in-progress.

I currently set the "irq" field to the IRQ number that would be used by the board if I did choose to enable interrupts. That seems to work fine (with rather limited testing).

AFAICT, it's probably ok; but it might not be. Certainly more robust to just add a UPF_POLLING flag and skip the synchronize_irq().

Is this an in-tree driver?

Regards,
Peter Hurley

#4 lore raw
Quoted 15 lines · Peter Hurley
Quoted 14 lines · Grant Edwards
Quoted 9 lines · Peter Hurley
Quoted 4 lines · Grant Edwards

For a polled serial driver that doesn't use interrupts, to what should the "irq" field in the uart_port structure be set? Should it be 0? Should it be the unused IRQ associated with the PCI card slot in which the board is found?

Doesn't look supported, but adding the support doesn't look difficult. At the very least, a patch is required so that on port shutdown, the core doesn't synchronize_irq().

Does the call ty synchronize_irq() do any harm? AFAICT, it will just cause a short delay if handling of that IRQ is in-progress.

Quoted 8 lines
Quoted 3 lines

I currently set the "irq" field to the IRQ number that would be used by the board if I did choose to enable interrupts. That seems to work fine (with rather limited testing).

AFAICT, it's probably ok; but it might not be. Certainly more robust to just add a UPF_POLLING flag and skip the synchronize_irq().

Is this an in-tree driver?

No.

One of my polled mode drivers is an enhanced version of the new rp2 serial driver. It's currently in beta test. I posted a snapshot of that one to this list last week, but it hasn't been submitted as a git patch yet.

The other is a rewrite of the rocket driver -- it's still under development. I'd be happy to submit it for inclusion in the tree when it's done.

Signature · 3 lines
Grant Edwards               grant.b.edwards        Yow! Give them RADAR-GUIDED
                                  at               SKEE-BALL LANES and
                              gmail.com            VELVEETA BURRITOS!!