Skip to contentSkip to conversation

Add scratch directory for NFS upcall state storage

PATCH Superseded Rich Dubielzig 2 participants 3 messages Feb 28, 2013 – Mar 1, 2013 1 message not in the archive

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Add scratch directory for NFS upcall state storage

When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot record the upcall state and cannot end the 90-second grace period on startup. This is true even when NFS4 is not being served according to nfsstat.

More details and discussion here:
https://lkml.org/lkml/2012/6/11/206

---
 .../nfs-utils/nfs-utils_1.2.3.bb                   |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb +3 -1
index 84c4464..138791b 100644
@@ -12,7 +12,7 @@ DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
 RDEPENDS_${PN} = "rpcbind"
 RRECOMMENDS_${PN} = "kernel-module-nfsd"
 
-PR = "r4"
+PR = "r5"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/nfs/nfs-utils-${PV}.tar.bz2 \
            file://nfs-utils-1.0.6-uclibc.patch \
@@ -53,6 +53,8 @@ RDEPENDS_${PN}-stats = "python"
 do_install_append () {
 	install -d ${D}${sysconfdir}/init.d
 	install -m 0755 ${WORKDIR}/nfsserver ${D}${sysconfdir}/init.d/nfsserver
+	# kernel code as of 3.8 hard-codes this path as a default
+	install -d ${D}/var/lib/nfs/v4recovery
 
 	# the following are built by CC_FOR_BUILD
 	rm -f ${D}${sbindir}/rpcdebug
Signature · 1 line
1.7.1
#1 lore raw
Quoted 5 lines · Rich Dubielzig

When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot record the upcall state and cannot end the 90-second grace period on startup. This is true even when NFS4 is not being served according to nfsstat.

Quoted 7 lines

More details and discussion here:
https://lkml.org/lkml/2012/6/11/206

---
 .../nfs-utils/nfs-utils_1.2.3.bb                   |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

The subject line is missing the prefix ("nfs-utils: ") and this patch doesn't apply against master which has nfs-utils 1.2.7?

Cheers,

Richard

Quoted 22 lines
meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb +3 -1
index 84c4464..138791b 100644
@@ -12,7 +12,7 @@ DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
 RDEPENDS_${PN} = "rpcbind"
 RRECOMMENDS_${PN} = "kernel-module-nfsd"
 
-PR = "r4"
+PR = "r5"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/nfs/nfs-utils-${PV}.tar.bz2 \
            file://nfs-utils-1.0.6-uclibc.patch \
@@ -53,6 +53,8 @@ RDEPENDS_${PN}-stats = "python"
 do_install_append () {
 	install -d ${D}${sysconfdir}/init.d
 	install -m 0755 ${WORKDIR}/nfsserver ${D}${sysconfdir}/init.d/nfsserver
+	# kernel code as of 3.8 hard-codes this path as a default
+	install -d ${D}/var/lib/nfs/v4recovery
 
 	# the following are built by CC_FOR_BUILD
 	rm -f ${D}${sbindir}/rpcdebug

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

Re: [V3] nfs-utils: Add scratch directory for NFS upcall state storage (denzil)

I'm sorry to be filling up the forum like this. Please disregard this patch, for some reason it is reverting my change instead of adding it.
________________________________________
From: Rich Dubielzig [[email protected]]
Sent: Friday, March 01, 2013 3:36 PM
To: [email protected]
Cc: Dubielzig, Rich
Subject: [V3] nfs-utils: Add scratch directory for NFS upcall state storage (denzil)

When the /var/lib/nfs/v4recovery directory is not present, NFSD cannot record the upcall state and cannot end the 90-second grace period on startup. This is true even when NFS4 is not being served according to nfsstat.

---
 .../nfs-utils/nfs-utils_1.2.3.bb                   |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb +1 -3
index 138791b..84c4464 100644
@@ -12,7 +12,7 @@ DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
 RDEPENDS_${PN} = "rpcbind"
 RRECOMMENDS_${PN} = "kernel-module-nfsd"
 
-PR = "r5"
+PR = "r4"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/nfs/nfs-utils-${PV}.tar.bz2 \
            file://nfs-utils-1.0.6-uclibc.patch \
@@ -53,8 +53,6 @@ RDEPENDS_${PN}-stats = "python"
 do_install_append () {
        install -d ${D}${sysconfdir}/init.d
        install -m 0755 ${WORKDIR}/nfsserver ${D}${sysconfdir}/init.d/nfsserver
-       # kernel code as of 3.8 hard-codes this path as a default
-       install -d ${D}/var/lib/nfs/v4recovery
 
        # the following are built by CC_FOR_BUILD
        rm -f ${D}${sbindir}/rpcdebug

--
1.7.1