Skip to contentSkip to conversation

staging: dgrp: Drop unnecessary typecast

PATCH New Guenter Roeck 1 participant 1 message Feb 28, 2013 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: dgrp: Drop unnecessary typecast

An unnecessary typecast in dgrp_net_ops.c causes the following build error if compiled with W=1.

In function ‘copy_from_user’, inlined from ‘dgrp_net_ioctl’ at
drivers/staging/dgrp/dgrp_net_ops.c:3408:21:
arch/x86/include/asm/uaccess_32.h:211:26: error: call to ‘copy_from_user_overflow’ declared with attribute error: copy_from_user() buffer size is not provably correct

---
 drivers/staging/dgrp/dgrp_net_ops.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgrp/dgrp_net_ops.c +1 -1
index e6018823..f364e8e 100644
@@ -3405,7 +3405,7 @@ static long dgrp_net_ioctl(struct file *file, unsigned int cmd,
 		if (size != sizeof(struct link_struct))
 			return -EINVAL;
 
-		if (copy_from_user((void *)(&link), (void __user *) arg, size))
+		if (copy_from_user(&link, (void __user *)arg, size))
 			return -EFAULT;
 
 		if (link.lk_fast_rate < 9600)
Signature · 1 line
1.7.9.7