Skip to contentSkip to conversation

mfd: da9055 change irq state to default

PATCH In review Ashish Jangam 1 participant 3 messages Jan 18, 2013 – Mar 8, 2013

Subsystems (2)
Multifunction devices (MFD) Dialog semiconductor drivers
lore
Share & tools
lore

Ashish Jangam

author
#0 lore raw

PATCH 1/5 mfd: da9055 change irq state to default

This patch changes the irq state from high to the now default low state.

This patch is tested on smdk6410 board.

Signed-off-by Ashish Jangam <[email protected]>
---
 drivers/mfd/da9055-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/da9055-core.c +1 -1
index f56a1a9..49cb23d 100644
@@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
 		da9055->irq_base = pdata->irq_base;
 
 	ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
-				  IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+				  IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 				  da9055->irq_base, &da9055_regmap_irq_chip,
 				  &da9055->irq_data);
 	if (ret < 0)
Signature · 1 line
1.7.0.4
author
#1 lore raw
Quoted 15 lines · Ashish Jangam

This patch changes the irq state from high to the now default low state.

This patch is tested on smdk6410 board.

Signed-off-by Ashish Jangam <[email protected]>
---
 drivers/mfd/da9055-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/da9055-core.c +0 -0
index f56a1a9..49cb23d 100644

drivers/mfd/da9055-core.c int da9055_device_init(struct da9055 *da9055) · line 397

Quoted 8 lines
drivers/mfd/da9055-core.c +1 -1
@@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
 		da9055->irq_base = pdata->irq_base;
 
 	ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
-				  IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+				  IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 				  da9055->irq_base, &da9055_regmap_irq_chip,
 				  &da9055->irq_data);
 	if (ret < 0)

Can you let me know if this patch looks good to get merged?

author
#2 lore raw
Quoted 18 lines · Ashish Jangam
Quoted 17 lines · Ashish Jangam

This patch changes the irq state from high to the now default low state.

This patch is tested on smdk6410 board.

Signed-off-by Ashish Jangam <[email protected]>
---
 drivers/mfd/da9055-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/da9055-core.c +0 -0
index f56a1a9..49cb23d 100644
@@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
 		da9055->irq_base = pdata->irq_base;
Quoted 7 lines

drivers/mfd/da9055-core.c int da9055_device_init(struct da9055 *da9055) · line 397

Quoted 6 lines
drivers/mfd/da9055-core.c +1 -1
 	ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
-				  IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+				  IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 				  da9055->irq_base, &da9055_regmap_irq_chip,
 				  &da9055->irq_data);
 	if (ret < 0)

Can you let me know if this patch looks good to get merged?

Any update? Sorry to ping, just need to close this small change till earlier.