mtd: nand: use ssize_t instead of size_t to prevent infinite loop
Subsystems (2)
PATCH 1/1 mtd: nand: use ssize_t instead of size_t to prevent infinite loop
When a all 0xFF buffer is passed to drop_ffs, the no-0xFF check loop will loop forever.
After the fix, If ssize_t i = -1 and size_t l = i + 1, the value of l will still be 0 as expected.
Signed-off-by Tao Hou <[email protected]>
Cc Ben Gardiner <[email protected]>
Cc Scott Wood <[email protected]>
--- drivers/mtd/nand/nand_util.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mtd/nand/nand_util.c +2 -1
@@ -451,7 +451,8 @@ static int check_skip_len(nand_info_t *nand, loff_t offset, size_t length)static size_t drop_ffs (const nand_info_t *nand,const u_char *buf,const size_t *len) { -size_t i, l = *len; +size_t l = *len; +ssize_t i;for (i = l -1 ; i >=0 ; i--)if (buf[i] !=0xFF )
Signature · 1 line
1.7.9.5
Quoted 5 lines · htbegin
When a all
0xFFbuffer is passed todrop_ffs, the no-0xFF check loop will loop forever.
After the fix, Ifssize_ti = -1 andsize_tl = i + 1, the value of l will still be 0 as expected.
Quoted 7 lines
Signed-off-by Tao Hou <[email protected]>Cc Ben Gardiner <[email protected]>Cc Scott Wood <[email protected]>---
drivers/mtd/nand/nand_util.c| 3 ++-1 file changed, 2 insertions(+), 1 deletion(-)
Applied to u-boot-nand-flash
-Scott