md: use set_bit_le and clear_bit_le
PATCH 1/1 md: use set_bit_le and clear_bit_le
The value returned by test_and_set_bit_le() drivers/md/bitmap.c is not used. So just use set_bit_le(). The same goes for test_and_clear_bit_le().
--- drivers/md/bitmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/md/bitmap.c +2 -2
@@ -846,7 +846,7 @@ static void bitmap_file_set_bit(struct bitmap *bitmap, sector_t block)if (test_bit (BITMAP_HOSTENDIAN , &bitmap->flags))set_bit (bit, kaddr);else -test_and_set_bit_le (bit, kaddr); +set_bit_le (bit, kaddr);kunmap_atomic (kaddr);pr_debug ("set file bit %lu page %lu\n" , bit, page->index);/* record page number so it gets flushed to disk when unplug occurs */
@@ -868,7 +868,7 @@ static void bitmap_file_clear_bit(struct bitmap *bitmap, sector_t block)if (test_bit (BITMAP_HOSTENDIAN , &bitmap->flags))clear_bit (bit, paddr);else -test_and_clear_bit_le (bit, paddr); +clear_bit_le (bit, paddr);kunmap_atomic (paddr);if (!test_page_attr (bitmap, page->index,BITMAP_PAGE_NEEDWRITE )) {set_page_attr (bitmap, page->index,BITMAP_PAGE_PENDING );
Signature · 1 line
1.8.1.2
NeilBrown
AppliedQuoted 24 lines · On Sat, 2 Mar 2013 23:35:57 +0900 Akinobu Mita <[email protected]> wrote:
The value returned by
test_and_set_bit_le()drivers/md/bitmap.cis not used. So just useset_bit_le(). The same goes fortest_and_clear_bit_le().--- drivers/md/bitmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/md/bitmap.c +1
-1@@ -846,7 +846,7 @@ static void bitmap_file_set_bit(struct bitmap *bitmap, sector_t block)if (test_bit (BITMAP_HOSTENDIAN , &bitmap->flags))set_bit (bit, kaddr);else -test_and_set_bit_le (bit, kaddr); +set_bit_le (bit, kaddr);kunmap_atomic (kaddr);pr_debug ("set file bit %lu page %lu\n" , bit, page->index);/* record page number so it gets flushed to disk when unplug occurs */
drivers/md/bitmap.c static void bitmap_file_clear_bit(struct bitmap *bitmap, sector_t block) · line 874
Quoted 8 lines
drivers/md/bitmap.c +1
-1@@ -868,7 +868,7 @@ static void bitmap_file_clear_bit(struct bitmap *bitmap, sector_t block)if (test_bit (BITMAP_HOSTENDIAN , &bitmap->flags))clear_bit (bit, paddr);else -test_and_clear_bit_le (bit, paddr); +clear_bit_le (bit, paddr);kunmap_atomic (paddr);if (!test_page_attr (bitmap, page->index,BITMAP_PAGE_NEEDWRITE )) {set_page_attr (bitmap, page->index,BITMAP_PAGE_PENDING );
applied, thanks.
NeilBrown