Skip to contentSkip to conversation

i2o/i2o_config: Validate message size

PATCH New Guenter Roeck 1 participant 1 message Mar 2, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2o/i2o_config: Validate message size

Message size was already validated against inbound_frame_size, but that does not guarantee that it is small enough for the buffer used to store a copy of it on the stack.

---
I am also not sure if the previous validation can be trusted, since the size is read again from user space after the initial validation.

 drivers/message/i2o/i2o_config.c |    4 ++++
 1 file changed, 4 insertions(+)
drivers/message/i2o/i2o_config.c +4 -0
index 5451bef..aabaafc 100644
@@ -922,6 +922,10 @@ static int i2o_cfg_passthru(unsigned long arg)
 		}
 		size = size >> 16;
 		size *= 4;
+		if (size > sizeof(rmsg)) {
+			rcode = -EFAULT;
+			goto sg_list_cleanup;
+		}
 		/* Copy in the user's I2O command */
 		if (copy_from_user(rmsg, user_msg, size)) {
 			rcode = -EFAULT;
Signature · 1 line
1.7.9.7