sp5100_tco: Fix the AcpiMmioSel bitmask value
PATCH 1/1 sp5100_tco: Fix the AcpiMmioSel bitmask value
The AcpiMmioSel bit is the bit1 in AcpiMmioEn register, but, current sp5100_tco driver was using bit2.
The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit1). fortunately, The problem didn't occur by this typo, because the default value of misused bit2 is zero. However, the sp5100_tco driver should use the correct bitmask value.
--- drivers/watchdog/sp5100_tco.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/sp5100_tco.h +1 -1
@@ -57,7 +57,7 @@#define SB800_PM_WATCHDOG_DISABLE (1 << 2)#define SB800_PM_WATCHDOG_SECOND_RES (3 << 0)#define SB800_ACPI_MMIO_DECODE_EN (1 << 0) -#define SB800_ACPI_MMIO_SEL (1 << 2) +#define SB800_ACPI_MMIO_SEL (1 << 1)#define SB800_PM_WDT_MMIO_OFFSET 0xB00
Signature · 1 line
1.8.1.4
PATCH v2 1/1 sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2
From: Takahisa Tanaka <[email protected]>
Date: Sun, 3 Mar 2013 14:48:00 +0900
The AcpiMmioSel bit is bit 1 in the AcpiMmioEn register, but the current sp5100_tco driver is using bit 2.
See 2.3.3 Power Management (PM) Registers page 150 of the AMD SB800-Series Southbridges Register Reference Guide [1].
AcpiMmioEn - RW – 8/16/32 bits - [PM_Reg: 24h]
Field Name Bits Default Description
AcpiMMioDecodeEn 0 0b Set to 1 to enable AcpiMMio space.
AcpiMMIoSel 1 0b Set AcpiMMio registers to be memory-mapped or IO-mapped space.
0: Memory-mapped space 1: I/O-mapped space
The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit 1).
Fortunately, no problems were caused by this typo, because the default value of the undocumented misused bit 2 seems to be zero.
However, the sp5100_tco driver should use the correct bitmask value.
[1] http://support.amd.com/us/Embedded_TechDocs/45482.pdf
---
v2: Hopefully improved the commit message.
drivers/watchdog/sp5100_tco.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/sp5100_tco.h +1 -1
@@ -57,7 +57,7 @@#define SB800_PM_WATCHDOG_DISABLE (1 << 2)#define SB800_PM_WATCHDOG_SECOND_RES (3 << 0)#define SB800_ACPI_MMIO_DECODE_EN (1 << 0) -#define SB800_ACPI_MMIO_SEL (1 << 2) +#define SB800_ACPI_MMIO_SEL (1 << 1)#define SB800_PM_WDT_MMIO_OFFSET 0xB00
Signature · 1 line
1.7.10.4
Re: [PATCH v2] sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2
Hi Paul,
2013/3/3 Paul Menzel <[email protected]>:
Quoted 48 lines
From: Takahisa Tanaka <[email protected]>
Date: Sun, 3 Mar 2013 14:48:00 +0900The AcpiMmioSel bit is bit 1 in the AcpiMmioEn register, but the current
sp5100_tcodriver is using bit 2.See 2.3.3 Power Management (PM) Registers page 150 of the AMD SB800-Series Southbridges Register Reference Guide [1].
AcpiMmioEn - RW – 8/16/32 bits - [
PM_Reg: 24h]
Field Name Bits Default Description
AcpiMMioDecodeEn 0 0b Set to 1 to enable AcpiMMio space.
AcpiMMIoSel 1 0b Set AcpiMMio registers to be memory-mapped or IO-mapped space.
0: Memory-mapped space 1: I/O-mapped spaceThe
sp5100_tcodriver expects zero as a value of AcpiMmioSel (bit 1).Fortunately, no problems were caused by this typo, because the default value of the undocumented misused bit 2 seems to be zero.
However, the
sp5100_tcodriver should use the correct bitmask value.[1] http://support.amd.com/us/Embedded_TechDocs/45482.pdf
Signed-off-by Takahisa Tanaka <[email protected]>Signed-off-by Paul Menzel <[email protected]>---
v2: Hopefully improved the commit message.drivers/watchdog/sp5100_tco.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/sp5100_tco.h +1
-2@@ -57,7 +57,7 @@#define SB800_PM_WATCHDOG_DISABLE (1 << 2)#define SB800_PM_WATCHDOG_SECOND_RES (3 << 0)#define SB800_ACPI_MMIO_DECODE_EN (1 << 0) -#define SB800_ACPI_MMIO_SEL (1 << 2) +#define SB800_ACPI_MMIO_SEL (1 << 1)#define SB800_PM_WDT_MMIO_OFFSET 0xB00 --
Quoted 1 line
1.7.10.4
I'm sorry for late reply.
Thank you for improving the commit log.
Regards,
Takahisa
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html