Skip to contentSkip to conversation

btrfs-progs: update mkfs.btrfs help info for raid5/6

PATCH In review [email protected] 3 participants 4 messages Mar 4, 2013 – Apr 21, 2013 1 message not in the archive Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs-progs: update mkfs.btrfs help info for raid5/6

From: Zhi Yong Wu <[email protected]>

Since raid5/6 support was introduced, we should update mkfs.btrfs help info.

---
 mkfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mkfs.c +1 -1
index 5ece186..f9f26a5 100644
@@ -326,7 +326,7 @@ static void print_usage(void)
 	fprintf(stderr, "options:\n");
 	fprintf(stderr, "\t -A --alloc-start the offset to start the FS\n");
 	fprintf(stderr, "\t -b --byte-count total number of bytes in the FS\n");
-	fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid10, dup or single\n");
+	fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid5, raid6, raid10, dup or single\n");
 	fprintf(stderr, "\t -l --leafsize size of btree leaves\n");
 	fprintf(stderr, "\t -L --label set a label\n");
 	fprintf(stderr, "\t -m --metadata metadata profile, values like data profile\n");
Signature · 1 line
1.7.11.7
#1 lore raw
Quoted 14 lines · On 04/03/13 01:37, [email protected] wrote:

From: Zhi Yong Wu<[email protected]>

Since raid5/6 support was introduced, we should update mkfs.btrfs help info.

---
  mkfs.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
mkfs.c +0 -0
index 5ece186..f9f26a5 100644

mkfs.c static void print_usage(void) · line 332

Quoted 8 lines
mkfs.c +1 -1
@@ -326,7 +326,7 @@ static void print_usage(void)
  	fprintf(stderr, "options:\n");
  	fprintf(stderr, "\t -A --alloc-start the offset to start the FS\n");
  	fprintf(stderr, "\t -b --byte-count total number of bytes in the FS\n");
-	fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid10, dup or single\n");
+	fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid5, raid6, raid10, dup or single\n");
  	fprintf(stderr, "\t -l --leafsize size of btree leaves\n");
  	fprintf(stderr, "\t -L --label set a label\n");
  	fprintf(stderr, "\t -m --metadata metadata profile, values like data profile\n");

Nitpick: that line of output is now longer than 80. Perhaps instead of "\t " have a few spaces at the start of each line.

Frank

#2 lore raw
Quoted 10 lines · Frank A. Kingswood
Quoted 9 lines · On 04/03/13 01:37, [email protected] wrote:

From: Zhi Yong Wu<[email protected]>

Since raid5/6 support was introduced, we should update mkfs.btrfs help info.

---
  mkfs.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines

mkfs.c static void print_usage(void) · line 332

Quoted 13 lines
mkfs.c +1 -1
index 5ece186..f9f26a5 100644
@@ -326,7 +326,7 @@ static void print_usage(void)
      fprintf(stderr, "options:\n");
      fprintf(stderr, "\t -A --alloc-start the offset to start the FS\n");
      fprintf(stderr, "\t -b --byte-count total number of bytes in the FS\n");
-    fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid10, dup or single\n");
+    fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid5, raid6, raid10, dup or single\n");
      fprintf(stderr, "\t -l --leafsize size of btree leaves\n");
      fprintf(stderr, "\t -L --label set a label\n");
      fprintf(stderr, "\t -m --metadata metadata profile, values like data profile\n");

Nitpick: that line of output is now longer than 80. Perhaps instead of "\t " have a few spaces at the start of each line.

or maybe:

+ fprintf(stderr, "\t -d --data data profile: [raid0|raid1|raid5|raid6|raid10|dup|single]\n");

I think that fits...

Quoted 6 lines

Frank

Signature · 3 lines
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CAEH94Lg2b9uYk=+cf_KXKnFYnMxPBM_rKGJairX14TtvGHD=ww@mail.gmail.com

#4 lore raw

I found this patch had been merged into David's unstable btrfs-progs git, but not into its master git, so don't know the reason. If it need me to send v2 based on your comments, please let me know, thanks.

Quoted 69 lines · Zhi Yong Wu

I found this patch had been merged into David's unstable btrfs-progs git, but not into its master git, so don't know the reason. If it need me to send v2 based on your comments, please let me know, thanks.

Quoted 50 lines · Eric Sandeen
Quoted 24 lines · Frank A. Kingswood
Quoted 23 lines · On 04/03/13 01:37, [email protected] wrote:

From: Zhi Yong Wu<[email protected]>

Since raid5/6 support was introduced, we should update mkfs.btrfs
help info.

---
  mkfs.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
mkfs.c +1 -1
index 5ece186..f9f26a5 100644
@@ -326,7 +326,7 @@ static void print_usage(void)
      fprintf(stderr, "options:\n");
      fprintf(stderr, "\t -A --alloc-start the offset to start the
 FS\n");
      fprintf(stderr, "\t -b --byte-count total number of bytes in the
 FS\n");
-    fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid10,
 dup or single\n");
+    fprintf(stderr, "\t -d --data data profile, raid0, raid1, raid5,
Quoted 8 lines
Quoted 5 lines
raid6, raid10, dup or single\n");
      fprintf(stderr, "\t -l --leafsize size of btree leaves\n");
      fprintf(stderr, "\t -L --label set a label\n");
      fprintf(stderr, "\t -m --metadata metadata profile, values like

data profile\n");

Nitpick: that line of output is now longer than 80. Perhaps instead of "\t " have a few spaces at the start of each line.

or maybe:

+ fprintf(stderr, "\t -d --data data profile:
[raid0|raid1|raid5|raid6|raid10|dup|single]\n");

I think that fits...

Quoted 7 lines

Frank

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Regards,

Zhi Yong Wu

Signature · 3 lines
Regards,

Zhi Yong Wu