Skip to contentSkip to conversation

rds: simplify a warning message

PATCH Applied Cong Wang 2 participants 2 messages Mar 4, 2013

Subsystems (3)
lore
Share & tools
lore

Cong Wang

author
#0 lore raw

PATCH 1/1 rds: simplify a warning message

From: Cong Wang <[email protected]>

Cc David S. Miller <[email protected]>
Cc Venkat Venkatsubra <[email protected]>

---

net/rds/message.c +1 -4
index f0a4658..5586cae 100644
@@ -82,10 +82,7 @@ static void rds_message_purge(struct rds_message *rm)
 void rds_message_put(struct rds_message *rm)
 {
 	rdsdebug("put rm %p ref %d\n", rm, atomic_read(&rm->m_refcount));
-	if (atomic_read(&rm->m_refcount) == 0) {
-printk(KERN_CRIT "danger refcount zero on %p\n", rm);
-WARN_ON(1);
-	}
+	WARN(!atomic_read(&rm->m_refcount), "danger refcount zero on %p\n", rm);
 	if (atomic_dec_and_test(&rm->m_refcount)) {
 		BUG_ON(!list_empty(&rm->m_sock_item));
 		BUG_ON(!list_empty(&rm->m_conn_item));