Skip to contentSkip to conversation

tools/intel_reg_dumper: add hsw backlight registers

PATCH In review Jani Nikula 2 participants 2 messages Mar 4, 2013 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/intel_reg_dumper: add hsw backlight registers

The more the merrier.

---
 lib/intel_reg.h          |    5 +++++
 tools/intel_reg_dumper.c |    5 +++++
 2 files changed, 10 insertions(+)
lib/intel_reg.h +5 -0
index 99d97bb..db07064 100644
@@ -3465,6 +3465,11 @@ typedef enum {
 #define  PWM_PIPE_B             (1 << 29)
 #define BLC_PWM_CPU_CTL         0x48254
 
+#define BLC_PWM2_CTL		0x48350
+#define BLC_PWM2_DATA		0x48354
+#define BLC_MISC_CTL		0x48360
+#define UTIL_PIN_CTL		0x48400
+
 #define BLC_PWM_PCH_CTL1        0xc8250
 #define  PWM_PCH_ENABLE         (1 << 31)
 #define  PWM_POLARITY_ACTIVE_LOW        (1 << 29)
tools/intel_reg_dumper.c +5 -0
index 20f332f..9f22720 100644
@@ -1899,6 +1899,11 @@ static struct reg_debug haswell_debug_regs[] = {
 	/* Fuses */
 	DEFINEREG(SFUSE_STRAP),
 
+	/* Backlight */
+	DEFINEREG(BLC_PWM2_CTL),
+	DEFINEREG(BLC_PWM2_DATA),
+	DEFINEREG(BLC_MISC_CTL),
+	DEFINEREG(UTIL_PIN_CTL),
 };
 
 static struct reg_debug i945gm_mi_regs[] = {
Signature · 1 line
1.7.9.5
#1 lore raw

Tabs or spaces? (was: [I-G-T] tools/intel_reg_dumper: add hsw backlight registers)

Dear intel-gfx folks,

Am Montag, den 04.03.2013, 12:22 +0200 schrieb Jani Nikula:

Quoted 13 lines

The more the merrier.

---
 lib/intel_reg.h          |    5 +++++
 tools/intel_reg_dumper.c |    5 +++++
 2 files changed, 10 insertions(+)
lib/intel_reg.h +0 -0
index 99d97bb..db07064 100644

lib/intel_reg.h typedef enum { · line 3472

Quoted 8 lines
lib/intel_reg.h +5 -0
@@ -3465,6 +3465,11 @@ typedef enum {
 #define  PWM_PIPE_B             (1 << 29)
 #define BLC_PWM_CPU_CTL         0x48254
 
+#define BLC_PWM2_CTL		0x48350
+#define BLC_PWM2_DATA		0x48354
+#define BLC_MISC_CTL		0x48360
+#define UTIL_PIN_CTL		0x48400
+

looking at that change I noticed that tabs and spaces are mixed in that file? What is preferred?

lib/intel_reg.h typedef enum { · line 3475

Quoted 3 lines
lib/intel_reg.h +0 -0
 #define BLC_PWM_PCH_CTL1        0xc8250
 #define  PWM_PCH_ENABLE         (1 << 31)
 #define  PWM_POLARITY_ACTIVE_LOW        (1 << 29)

[…]

Thanks,

Paul

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx