Skip to contentSkip to conversation

sparc,leon: support for GRPCI1 PCI host bridge controller

PATCH Superseded Daniel Hellstrom 2 participants 3 messages Mar 4, 2013 – Mar 5, 2013 SPARC + UltraSPARC (sparc/sparc64)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 sparc,leon: support for GRPCI1 PCI host bridge controller

Some of the GRPCI1 cores does not support detection of all PCI errors, the default is therefore limited PCI error handling. The property all_pci_errors my be set by the boot loader to enable interrupt on all PCI errors.

---
 arch/sparc/Kconfig                  |   11 +
 arch/sparc/kernel/Makefile          |    1 +
 arch/sparc/kernel/leon_pci_grpci1.c |  724 +++++++++++++++++++++++++++++++++++
 3 files changed, 736 insertions(+), 0 deletions(-)
 create mode 100644 arch/sparc/kernel/leon_pci_grpci1.c
arch/sparc/Kconfig +11 -0
index 9bff3db..9aa2cb8 100644
@@ -500,6 +500,17 @@ config LEON_PCI
 	depends on PCI && SPARC_LEON
 	default y
 
+config SPARC32_GRPCI1
+	bool "GRPCI Host Bridge Support"
+	depends on LEON_PCI
+	default y
+	help
+	  Say Y here to include the GRPCI Host Bridge Driver. The GRPCI
+	  PCI host controller is typically found in GRLIB SPARC32/LEON
+	  systems. The driver has one property (all_pci_errors) controlled
+	  from the bootloader that makes the GRPCI to generate interrupts
+	  on detected PCI Parity and System errors.
+
 config GRPCI2
 	bool "GRPCI2 Host Bridge Support"
 	depends on LEON_PCI
arch/sparc/kernel/Makefile +1 -0
index 6cf591b..992be44 100644
@@ -75,6 +75,7 @@ obj-y                     += dma.o
 obj-$(CONFIG_PCIC_PCI)    += pcic.o
 obj-$(CONFIG_LEON_PCI)    += leon_pci.o
 obj-$(CONFIG_GRPCI2)      += leon_pci_grpci2.o
+obj-$(CONFIG_SPARC32_GRPCI1) += leon_pci_grpci1.o
 
 obj-$(CONFIG_SMP)         += trampoline_$(BITS).o smp_$(BITS).o
 obj-$(CONFIG_SPARC32_SMP) += sun4m_smp.o sun4d_smp.o leon_smp.o
arch/sparc/kernel/leon_pci_grpci1.c new file +724 -0

724 lines not on this page · raw message

Signature · 1 line
1.7.0.4
#1 lore raw
Quoted 22 lines · Daniel Hellstrom

Some of the GRPCI1 cores does not support detection of all PCI errors, the default is therefore limited PCI error handling. The property all_pci_errors my be set by the boot loader to enable interrupt on all PCI errors.

---
 arch/sparc/Kconfig                  |   11 +
 arch/sparc/kernel/Makefile          |    1 +
 arch/sparc/kernel/leon_pci_grpci1.c |  724 +++++++++++++++++++++++++++++++++++
 3 files changed, 736 insertions(+), 0 deletions(-)
 create mode 100644 arch/sparc/kernel/leon_pci_grpci1.c
arch/sparc/Kconfig +1 -0
index 9bff3db..9aa2cb8 100644
@@ -500,6 +500,17 @@ config LEON_PCI
 	depends on PCI && SPARC_LEON
 	default y
 
+config SPARC32_GRPCI1

arch/sparc/Kconfig config LEON_PCI · line 513

Quoted 10 lines
arch/sparc/Kconfig +10 -0
+	bool "GRPCI Host Bridge Support"
+	depends on LEON_PCI
+	default y
+	help
+	  Say Y here to include the GRPCI Host Bridge Driver. The GRPCI
+	  PCI host controller is typically found in GRLIB SPARC32/LEON
+	  systems. The driver has one property (all_pci_errors) controlled
+	  from the bootloader that makes the GRPCI to generate interrupts
+	  on detected PCI Parity and System errors.
+

Please - use SPARC_ prefix.
All arch specific symbols shall have the ARCH_ prefix. In the x86 world we do: X86_32_ for the 32 bit specific symbols.

I know someone(*) added a SPARC32_SMP - but thats not a good example to follow.

(*) Yeah - that was me. I got wiser now.

Sam

#2 lore raw
In reply to Daniel Hellstrom
Quoted 37 lines · Sam Ravnborg
Quoted 22 lines · Daniel Hellstrom

Some of the GRPCI1 cores does not support detection of all PCI errors, the default is therefore limited PCI error handling. The property all_pci_errors my be set by the boot loader to enable interrupt on all PCI errors.

---
  arch/sparc/Kconfig                  |   11 +
  arch/sparc/kernel/Makefile          |    1 +
  arch/sparc/kernel/leon_pci_grpci1.c |  724 +++++++++++++++++++++++++++++++++++
  3 files changed, 736 insertions(+), 0 deletions(-)

create mode 100644 arch/sparc/kernel/leon_pci_grpci1.c

arch/sparc/Kconfig +1 -0
index 9bff3db..9aa2cb8 100644
@@ -500,6 +500,17 @@ config LEON_PCI
  	depends on PCI && SPARC_LEON
  	default y
 
+config SPARC32_GRPCI1

arch/sparc/Kconfig config LEON_PCI · line 513

Quoted 10 lines
arch/sparc/Kconfig +10 -0
+	bool "GRPCI Host Bridge Support"
+	depends on LEON_PCI
+	default y
+	help
+	  Say Y here to include the GRPCI Host Bridge Driver. The GRPCI
+	  PCI host controller is typically found in GRLIB SPARC32/LEON
+	  systems. The driver has one property (all_pci_errors) controlled
+	  from the bootloader that makes the GRPCI to generate interrupts
+	  on detected PCI Parity and System errors.
+

Please - use SPARC_ prefix.
All arch specific symbols shall have the ARCH_ prefix. In the x86 world we do: X86_32_ for the 32 bit specific symbols.

Quoted 5 lines

I know someone(*) added a SPARC32_SMP - but thats not a good example to follow.

(*) Yeah - that was me. I got wiser now.

Sam

Sam and Dave, sorry for messing up this simple stuff. I simply did a typo. I appreciate your time and effort regarding this. I will update the two last patches shortly using SPARC_* instead.

Daniel