hugetlb: fix sparse warning for hugetlb_register_node
Subsystems (2)
PATCH 1/1 hugetlb: fix sparse warning for hugetlb_register_node
Removed the following sparse warnings:
* mm/hugetlb.c:1764:6: warning: symbol
'hugetlb_unregister_node' was not declared.
Should it be static?
* mm/hugetlb.c:1808:6: warning: symbol
'hugetlb_register_node' was not declared.
Should it be static?
--- mm/hugetlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/hugetlb.c +2 -2
@@ -1761,7 +1761,7 @@ static struct hstate *kobj_to_node_hstate(struct kobject *kobj, int *nidp)* Unregister hstate attributes from a single node device. * No-op if no hstate attributes attached. */ -void hugetlb_unregister_node (struct node *node) +static void hugetlb_unregister_node (struct node *node) {struct hstate *h;struct node_hstate *nhs = &node_hstates[node->dev.id];
@@ -1805,7 +1805,7 @@ static void hugetlb_unregister_all_nodes(void)* Register hstate attributes for a single node device. * No-op if attributes already registered. */ -void hugetlb_register_node (struct node *node) +static void hugetlb_register_node (struct node *node) {struct hstate *h;struct node_hstate *nhs = &node_hstates[node->dev.id];
Signature · 7 lines
1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 38 lines · Claudiu Ghioc
Removed the following sparse warnings:
*mm/hugetlb.c:1764:6: warning: symbol
'hugetlb_unregister_node' was not declared.
Should it be static?
*mm/hugetlb.c:1808:6: warning: symbol
'hugetlb_register_node' was not declared.
Should it be static?Signed-off-by Claudiu Ghioc <[email protected]>--- mm/hugetlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/hugetlb.c +2
-3@@ -1761,7 +1761,7 @@ static struct hstate *kobj_to_node_hstate(struct kobject *kobj, int *nidp)* Unregister hstate attributes from a single node device. * No-op if no hstate attributes attached. */ -void hugetlb_unregister_node (struct node *node) +static void hugetlb_unregister_node (struct node *node) {struct hstate *h;struct node_hstate *nhs = &node_hstates[node->dev.id];@@ -1805,7 +1805,7 @@ static void hugetlb_unregister_all_nodes(void)* Register hstate attributes for a single node device. * No-op if attributes already registered. */ -void hugetlb_register_node (struct node *node) +static void hugetlb_register_node (struct node *node) {struct hstate *h;struct node_hstate *nhs = &node_hstates[node->dev.id]; --1.7.9.5
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi Jiri,
Can you pick this up via trivial tree?
thanks,
Daniel.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 29 lines · Daniel Baluta
Quoted 29 lines
Removed the following sparse warnings:
*mm/hugetlb.c:1764:6: warning: symbol
'hugetlb_unregister_node' was not declared.
Should it be static?
*mm/hugetlb.c:1808:6: warning: symbol
'hugetlb_register_node' was not declared.
Should it be static?Signed-off-by Claudiu Ghioc <[email protected]>--- mm/hugetlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)mm/hugetlb.c +1
-1@@ -1761,7 +1761,7 @@ static struct hstate *kobj_to_node_hstate(struct kobject *kobj, int *nidp)* Unregister hstate attributes from a single node device. * No-op if no hstate attributes attached. */ -void hugetlb_unregister_node (struct node *node) +static void hugetlb_unregister_node (struct node *node) {struct hstate *h;struct node_hstate *nhs = &node_hstates[node->dev.id];@@ -1805,7 +1805,7 @@ static void hugetlb_unregister_all_nodes(void)* Register hstate attributes for a single node device. * No-op if attributes already registered.
Quoted 8 lines
mm/hugetlb.c static void hugetlb_unregister_all_nodes(void) · line 1811
Quoted 6 lines
mm/hugetlb.c +1
-1*/ -void hugetlb_register_node (struct node *node) +static void hugetlb_register_node (struct node *node) {struct hstate *h;struct node_hstate *nhs = &node_hstates[node->dev.id];Can you pick this up via trivial tree?
Seems like sparse is correct here, as register_hugetlbfs_with_node is passing pointers to those functions.
Will take it.
Signature · 8 lines
Jiri Kosina SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>