stress: honor the BR2_PREFER_STATIC_LIB preference
PATCH 1/1 stress: honor the BR2_PREFER_STATIC_LIB preference
From: roylee17 <[email protected]>
Change-Id: I13f849e76557fac81b488ab26b4ac8b999888bc1
--- package/stress/stress.mk | 3 +++ 1 file changed, 3 insertions(+)
package/stress/stress.mk +3 -0
@@ -10,4 +10,7 @@ STRESS_VERSION = 1.0.4 STRESS_SITE = http://weather.ou.edu/~apw/projects/stress STRESS_AUTORECONF = YES +STRESS_CONF_OPT = \ + $(if $(BR2_PREFER_STATIC_LIB),--enable-static,--disable-static) + $(eval $(autotools-package))
Signature · 1 line
1.8.1.2
PATCH 1/1 stress: honor the BR2_PREFER_STATIC_LIB preference
Quoted 12 lines · Tzu-Jung Lee
From: roylee17 <[email protected]>
Change-Id: I13f849e76557fac81b488ab26b4ac8b999888bc1
--- package/stress/stress.mk | 3 +++ 1 file changed, 3 insertions(+)package/stress/stress.mk +0
-0
package/stress/stress.mk STRESS_VERSION = 1.0.4 · line 14
Quoted 5 lines
package/stress/stress.mk +2
-0@@ -10,4 +10,7 @@ STRESS_VERSION = 1.0.4 STRESS_SITE = http://weather.ou.edu/~apw/projects/stress STRESS_AUTORECONF = YES +STRESS_CONF_OPT = \ + $(if $(BR2_PREFER_STATIC_LIB),--enable-static,--disable-static)
This is already part of the standard SHARED_STATIC_LIBS_OPTS, which is
part of the argument list of configure. The difference being that in the shared case, --enable-static is still passed (to allow building static libraries, in case some client prefers to link statically after all).
Any reason why this doesn't work for stress?
Regards,
Arnout
Quoted 2 lines
package/stress/stress.mk +1
-0+ $(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/1 stress: honor the BR2_PREFER_STATIC_LIB preference
ifeq ($(BR2_PREFER_STATIC_LIB),y)
SHARED_STATIC_LIBS_OPTS=--enable-static --disable-shared
TARGET_LDFLAGS += --static
else
SHARED_STATIC_LIBS_OPTS=--enable-static --enable-shared
endifAs you indicated, the --enable-static is given anyway in the SHARED_STATIC_LIBS_OPTS.
Unfortunately, as long as the --enable-static is given, stress links the program statically, regardless how the --enable-shared or --disable-shared. In this case, stress would be linked statically regardless how the BR2_PREFER_STATIC_LIB specifies.
So we need the patch to explicitly tell it link the program dynamically by appending/overriding with --disable-static.
Thanks.
Roy
Quoted 37 lines · Arnout Vandecappelle
Quoted 13 lines · Tzu-Jung Lee
From: roylee17 <[email protected]>
Change-Id: I13f849e76557fac81b488ab26b4ac**8b999888bc1
--- package/stress/stress.mk | 3 +++ 1 file changed, 3 insertions(+)package/stress/stress.mk +0
-0package/stress/stress.mk STRESS_VERSION = 1.0.4 · line 15
Quoted 6 lines
package/stress/stress.mk +2
-0@@ -10,4 +10,7 @@ STRESS_VERSION = 1.0.4 STRESS_SITE = http://weather.ou.edu/~apw/**projects/stress<http://weather.ou.edu/~apw/projects/stress> STRESS_AUTORECONF = YES +STRESS_CONF_OPT = \ + $(if $(BR2_PREFER_STATIC_LIB),--**enable-static,--disable-** static)This is already part of the standard
SHARED_STATIC_LIBS_OPTS, which is
part of the argument list of configure. The difference being that in the shared case, --enable-static is still passed (to allow building static libraries, in case some client prefers to link statically after all).Any reason why this doesn't work for stress?
Regards,
Arnout+
Quoted 2 lines
$(eval $(autotools-package))
Quoted 8 lines
--
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/**arnoutvandecappelle<http://www.linkedin.com/in/arnoutvandecappelle> GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130304/8dc2ff97/attachment-0001.html>
PATCH 1/1 stress: honor the BR2_PREFER_STATIC_LIB preference
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"T" == Tzu-Jung Lee <[email protected]> writes:
T> ? ? ifeq ($(BR2_PREFER_STATIC_LIB),y)
T> ? ? SHARED_STATIC_LIBS_OPTS=--enable-static --disable-shared T> ? ? TARGET_LDFLAGS += --static
T> ? ? else
T> ? ? SHARED_STATIC_LIBS_OPTS=--enable-static --enable-shared T> ? ? endif
T> As you indicated, the --enable-static is given anyway in the T> SHARED_STATIC_LIBS_OPTS. Unfortunately, as long as the T> --enable-static is given, stress links the program statically, T> regardless how the --enable-shared or --disable-shared. In this T> case, stress would be linked statically regardless how the T> BR2_PREFER_STATIC_LIB specifies. So we need the patch to explicitly T> tell it link the program dynamically by appending/overriding with T> --disable-static.
So you only need to pass --disable-static if !BR2_PREFER_STATIC_LIB? Could you please resend with a patch only doing that and a comment above it explaining why?
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 stress: honor the BR2_PREFER_STATIC_LIB preference
My pleasure.
I add comment in both commit log and makefile. Please feel free to do necessary editing while committing.
Thanks.
Roy
Quoted 18 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"T" == Tzu-Jung Lee <[email protected]> writes:
T> ifeq ($(BR2_PREFER_STATIC_LIB),y) T> SHARED_STATIC_LIBS_OPTS=--enable-static --disable-shared T> TARGET_LDFLAGS += --static T> else T> SHARED_STATIC_LIBS_OPTS=--enable-static --enable-shared T> endifT> As you indicated, the --enable-static is given anyway in the T>
SHARED_STATIC_LIBS_OPTS. Unfortunately, as long as the T> --enable-static is given, stress links the program statically, T> regardless how the --enable-shared or --disable-shared. In this T> case, stress would be linked statically regardless how the T>BR2_PREFER_STATIC_LIBspecifies. So we need the patch to explicitly T> tell it link the program dynamically by appending/overriding with T> --disable-static.
Quoted 7 lines
So you only need to pass --disable-static if !BR2_PREFER_STATIC_LIB? Could you please resend with a patch only doing that and a comment above it explaining why?
--
Bye, Peter Korsgaard
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130305/51c26faf/attachment.html>
PATCH 1/1 stress: honor the BR2_PREFER_STATIC_LIB preference
In reply to Tzu-Jung LeeFrom: roylee17 <[email protected]>
Stress is linked statically if the --enable-static is specified. However, this option is always specified in the global SHARED_STATIC_LIBS_OPTS to tell packages to build static libraries, if supported.
If the BR2_PREFER_STATIC_LIB is not defined, we have to specify --disable-static explicitly to get stress linked dynamically.
--- package/stress/stress.mk | 10 ++++++++++ 1 file changed, 10 insertions(+)
package/stress/stress.mk +10 -0
@@ -10,4 +10,14 @@ STRESS_VERSION = 1.0.4 STRESS_SITE = http://weather.ou.edu/~apw/projects/stress STRESS_AUTORECONF = YES +# Stress is linked statically if the --enable-static is specified. +# However, this option is always specified in the global +# SHARED_STATIC_LIBS_OPTS to tell packages to build static libraries, +# if supported. +# +# If the BR2_PREFER_STATIC_LIB is not defined, we have to specify +# --disable-static explicitly to get stress linked dynamically. +STRESS_CONF_OPT = \ + $(if $(BR2_PREFER_STATIC_LIB),,--disable-static) + $(eval $(autotools-package))
Signature · 1 line
1.8.1.5
PATCH 1/1 stress: honor the BR2_PREFER_STATIC_LIB preference
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"T" == Tzu-Jung Lee <[email protected]> writes:
T> From: roylee17 <[email protected]>
T> Stress is linked statically if the --enable-static is specified. T> However, this option is always specified in the global T> SHARED_STATIC_LIBS_OPTS to tell packages to build static libraries, T> if supported.
T> If the BR2_PREFER_STATIC_LIB is not defined, we have to specify T> --disable-static explicitly to get stress linked dynamically.
T> Signed-off-by: Tzu-Jung Lee <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard