Skip to contentSkip to conversation

staging/vt6656: Fix too large integer constant warning on 32-bit

PATCH In review Geert Uytterhoeven 2 participants 2 messages Mar 4, 2013 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging/vt6656: Fix too large integer constant warning on 32-bit

drivers/staging/vt6656/card.c: In function ‘CARDqGetNextTBTT’:
drivers/staging/vt6656/card.c:793: warning: integer constant is too large for ‘unsigned long’ type

Commit c7b7cad0d8df823ea063c86a54316bbcbfa04a7c ("staging/vt6656: Fix sparse warning constant 0xffffffff00000000U is so big it is unsigned long") changed the constant to "0xffffffff00000000UL", but that only works on 64-bit. Change it "0xffffffff00000000ULL" to fix it for 32-bit, too.

---
 drivers/staging/vt6656/card.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/vt6656/card.c +1 -1
index 22918a1..d2479b7 100644
@@ -790,7 +790,7 @@ u64 CARDqGetNextTBTT(u64 qwTSF, WORD wBeaconInterval)
 	if ((~uLowNextTBTT) < uLowRemain)
 		qwTSF = ((qwTSF >> 32) + 1) << 32;
 
-	qwTSF = (qwTSF & 0xffffffff00000000UL) |
+	qwTSF = (qwTSF & 0xffffffff00000000ULL) |
 		(u64)(uLowNextTBTT + uLowRemain);
 
     return (qwTSF);
Signature · 1 line
1.7.0.4
Reviewed-by on v1 1/1
#1 lore raw

Am Montag, 4. März 2013, 20:42:00 schrieb Geert Uytterhoeven:

Quoted 9 lines

drivers/staging/vt6656/card.c: In function ‘CARDqGetNextTBTT’:
drivers/staging/vt6656/card.c:793: warning: integer constant is too large for ‘unsigned long’ type

Commit c7b7cad0d8df823ea063c86a54316bbcbfa04a7c ("staging/vt6656: Fix sparse warning constant 0xffffffff00000000U is so big it is unsigned long") changed the constant to "0xffffffff00000000UL", but that only works on 64-bit. Change it "0xffffffff00000000ULL" to fix it for 32-bit, too.

Thanks - sorry that I had missed this.
I thought I had it compiled on x86 (non64 bit), too.