Skip to contentSkip to conversation

Staging: Netlogic XLR/XLS GMAC driver

PATCH In review [email protected] 2 participants 5 messages Mar 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: Netlogic XLR/XLS GMAC driver

From: Ganesan Ramalingam <[email protected]>

Add support for the Network Accelerator Engine on Netlogic XLR/XLS MIPS SoCs. The XLR/XLS NAE blocks can be configured as one 10G interface or four 1G interfaces. This driver supports blocks with 1G ports.

---
This patch has to be merged via staging tree.

This driver has been submitted to netdev tree and reviewed, the comments are list in TODO list, will be addressed in next cycle of submission, till that time I wanted this driver to be in staging tree.

This driver shall be sent to [email protected] and David Miller <[email protected]> for further review.

xlr_net.* - adding the driver support
platform_net.* - adding the XLR/XLS platform support, this will be moved to platform when this driver moving to netdev tree.

 drivers/staging/Kconfig                 |    2 +
 drivers/staging/Makefile                |    1 +
 drivers/staging/netlogic/Kconfig        |    7 +
 drivers/staging/netlogic/Makefile       |    1 +
 drivers/staging/netlogic/TODO           |    5 +
 drivers/staging/netlogic/platform_net.c |  223 ++++++
 drivers/staging/netlogic/platform_net.h |   46 ++
 drivers/staging/netlogic/xlr_net.c      | 1116 +++++++++++++++++++++++++++++++
 drivers/staging/netlogic/xlr_net.h      | 1099 ++++++++++++++++++++++++++++++
 9 files changed, 2500 insertions(+), 0 deletions(-)
 create mode 100644 drivers/staging/netlogic/Kconfig
 create mode 100644 drivers/staging/netlogic/Makefile
 create mode 100644 drivers/staging/netlogic/TODO
 create mode 100644 drivers/staging/netlogic/platform_net.c
 create mode 100644 drivers/staging/netlogic/platform_net.h
 create mode 100644 drivers/staging/netlogic/xlr_net.c
 create mode 100644 drivers/staging/netlogic/xlr_net.h
drivers/staging/Kconfig +2 -0
index 093f10c..daeeec1 100644
@@ -140,4 +140,6 @@ source "drivers/staging/zcache/Kconfig"
 
 source "drivers/staging/goldfish/Kconfig"
 
+source "drivers/staging/netlogic/Kconfig"
+
 endif # STAGING
drivers/staging/Makefile +1 -0
index fa41b04..d3040d7 100644
@@ -23,6 +23,7 @@ obj-$(CONFIG_RTS5139)		+= rts5139/
 obj-$(CONFIG_TRANZPORT)		+= frontier/
 obj-$(CONFIG_IDE_PHISON)	+= phison/
 obj-$(CONFIG_LINE6_USB)		+= line6/
+obj-$(CONFIG_NETLOGIC_XLR_NET)	+= netlogic/
 obj-$(CONFIG_USB_SERIAL_QUATECH2)	+= serqt_usb2/
 obj-$(CONFIG_OCTEON_ETHERNET)	+= octeon/
 obj-$(CONFIG_VT6655)		+= vt6655/
drivers/staging/netlogic/Kconfig new file +7 -0
new file mode 100644
index 0000000..d660de5
@@ -0,0 +1,7 @@
+config NETLOGIC_XLR_NET
+	tristate "Netlogic XLR/XLS network device"
+	depends on CPU_XLR
+	select PHYLIB
+	---help---
+	This driver support Netlogic XLR/XLS on chip gigabit
+	Ethernet.
drivers/staging/netlogic/Makefile new file +1 -0
new file mode 100644
index 0000000..f7355e3
@@ -0,0 +1 @@
+obj-$(CONFIG_NETLOGIC_XLR_NET) += xlr_net.o platform_net.o
drivers/staging/netlogic/TODO new file +5 -0
new file mode 100644
index 0000000..b366a8d
@@ -0,0 +1,5 @@
+* Implementing 64bit stat counter in software
+* All memory allocation should be changed to DMA allocations
+* All the netdev should be linked to single pdev as parent
+* Changing comments in to linux standred format
+
drivers/staging/netlogic/platform_net.c new file +223 -0

223 lines not on this page · raw message

drivers/staging/netlogic/platform_net.h new file +46 -0

46 lines not on this page · raw message

drivers/staging/netlogic/xlr_net.c new file +1116 -0

1,116 lines not on this page · raw message

drivers/staging/netlogic/xlr_net.h new file +1099 -0

1,099 lines not on this page · raw message

Signature · 1 line
1.7.6
#1 lore raw
Quoted 8 lines · On Tue, Mar 05, 2013 at 11:59:18AM +0530, [email protected] wrote:

This patch has to be merged via staging tree.

This driver has been submitted to netdev tree and reviewed, the comments are list in TODO list, will be addressed in next cycle of submission, till that time I wanted this driver to be in staging tree.

This driver shall be sent to [email protected] and David Miller <[email protected]> for further review.

When is that going to happen?

drivers/staging/netlogic/Kconfig line 3

Quoted 6 lines
drivers/staging/netlogic/Kconfig new file +3 -0
@@ -0,0 +1,7 @@
+config NETLOGIC_XLR_NET
+	tristate "Netlogic XLR/XLS network device"
+	depends on CPU_XLR

Why will this not build on any other platform? It should, right?

drivers/staging/netlogic/TODO line 5

Quoted 8 lines
drivers/staging/netlogic/TODO new file +5 -0
@@ -0,0 +1,5 @@
+* Implementing 64bit stat counter in software
+* All memory allocation should be changed to DMA allocations
+* All the netdev should be linked to single pdev as parent
+* Changing comments in to linux standred format
+

I need a name and email address for who is responsible for this driver and will be handling patches for it.

Please fix this up and resubmit.

thanks,

greg k-h

#2 lore raw
Quoted 12 lines · Greg Kroah-Hartman
Quoted 8 lines · On Tue, Mar 05, 2013 at 11:59:18AM +0530, [email protected] wrote:

This patch has to be merged via staging tree.

This driver has been submitted to netdev tree and reviewed, the comments are list in TODO list, will be addressed in next cycle of submission, till that time I wanted this driver to be in staging tree.

This driver shall be sent to [email protected] and David Miller <[email protected]> for further review.

When is that going to happen?

In two months.

Quoted 10 lines

drivers/staging/netlogic/Kconfig line 3

Quoted 6 lines
drivers/staging/netlogic/Kconfig new file +3 -0
@@ -0,0 +1,7 @@
+config NETLOGIC_XLR_NET
+	tristate "Netlogic XLR/XLS network device"
+	depends on CPU_XLR

Why will this not build on any other platform? It should, right?

This driver is for XLR processor ethernet, which is depend on FMN for any communication between packet processing agents, so this driver depend on XLR platform.

Quoted 12 lines

drivers/staging/netlogic/TODO line 5

Quoted 8 lines
drivers/staging/netlogic/TODO new file +5 -0
@@ -0,0 +1,5 @@
+* Implementing 64bit stat counter in software
+* All memory allocation should be changed to DMA allocations
+* All the netdev should be linked to single pdev as parent
+* Changing comments in to linux standred format
+

I need a name and email address for who is responsible for this driver and will be handling patches for it.

Will add the emaipl address list and resubmit.

Quoted 6 lines

Please fix this up and resubmit.

thanks,

greg k-h

#3 lore raw
Quoted 8 lines · Ganesan Ramalignam
Quoted 7 lines · Greg Kroah-Hartman
Quoted 6 lines · On Tue, Mar 05, 2013 at 11:59:18AM +0530, [email protected] wrote:

This patch has to be merged via staging tree.

This driver has been submitted to netdev tree and reviewed, the comments are list in TODO list, will be addressed in next cycle of submission, till that time I wanted this driver to be in staging tree.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

This driver shall be sent to [email protected] and David Miller <[email protected]> for further review.

When is that going to happen?

In two months.

Why then? What is so magic about 2 months? In two months, this driver is not going to be in a released version of the kernel yet.

Quoted 11 lines
Quoted 10 lines

drivers/staging/netlogic/Kconfig line 3

Quoted 6 lines
drivers/staging/netlogic/Kconfig new file +3 -0
@@ -0,0 +1,7 @@
+config NETLOGIC_XLR_NET
+	tristate "Netlogic XLR/XLS network device"
+	depends on CPU_XLR

Why will this not build on any other platform? It should, right?

Quoted 3 lines

This driver is for XLR processor ethernet, which is depend on FMN for any communication between packet processing agents, so this driver depend on XLR platform.

What is "FMN"?

thanks,

greg k-h

#4 lore raw
Quoted 12 lines · Greg Kroah-Hartman
Quoted 11 lines · Ganesan Ramalignam
Quoted 10 lines · Greg Kroah-Hartman
Quoted 8 lines · On Tue, Mar 05, 2013 at 11:59:18AM +0530, [email protected] wrote:

This patch has to be merged via staging tree.

This driver has been submitted to netdev tree and reviewed, the comments are list in TODO list, will be addressed in next cycle of submission, till that time I wanted this driver to be in staging tree.

This driver shall be sent to [email protected] and David Miller <[email protected]> for further review.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

When is that going to happen?

In two months.

Why then? What is so magic about 2 months? In two months, this driver is not going to be in a released version of the kernel yet.

Hi Greg,

Sorry, I think my previous mail did not give more detail, let me clarify now.

The plan is to make the changes as per the comments received so far and submit it again for review. There may be more changes and development when this driver reviewed again, this process might take time of 2 months or even more. Also this driver is useful to people with XLR/XLS board right now, so I would like to move this driver to staging, once it reaches the standard will be moved to netdev tree.

Please let me know if anything wrong in this approach.

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines

drivers/staging/netlogic/Kconfig line 3

Quoted 6 lines
drivers/staging/netlogic/Kconfig new file +3 -0
@@ -0,0 +1,7 @@
+config NETLOGIC_XLR_NET
+	tristate "Netlogic XLR/XLS network device"
+	depends on CPU_XLR

Why will this not build on any other platform? It should, right?

Quoted 6 lines
Quoted 3 lines

This driver is for XLR processor ethernet, which is depend on FMN for any communication between packet processing agents, so this driver depend on XLR platform.

What is "FMN"?

This driver is for the network accelerator integrated into the Netlogic XLR/XLS processor family. It uses the Fast Message Network(FMN) present only on the Netlogic XLR/XLS SoCs, FMN is used for sending descriptors between CPUs and high speed interfaces on XLR/XLS SoC (the code for this is in arch/mips/netlogic/xlr/fmn*), so I do not see it being used on other platforms.

Quoted 4 lines

thanks,

greg k-h