leds: wm8350: Complain if we fail to reenable DCDC
Subsystems (2)
PATCH 1/1 leds: wm8350: Complain if we fail to reenable DCDC
Provide some trace, though the hardware is most likely non-functional if this happens.
Signed-off-by Mark Brown <[email protected]>
--- drivers/leds/leds-wm8350.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/leds/leds-wm8350.c +4 -1
@@ -129,7 +129,10 @@ static void wm8350_led_disable(struct wm8350_led *led) ret =regulator_disable (led->isink);if (ret !=0 ) {dev_err (led->cdev.dev,"Failed to disable ISINK: %d\n" , ret); -regulator_enable (led->dcdc); + ret =regulator_enable (led->dcdc); +if (ret !=0 ) +dev_err (led->cdev.dev,"Failed to reenable DCDC: %d\n" , + ret);return ; }
Signature · 1 line
1.7.10.4
Quoted 3 lines · Mark Brown
Provide some trace, though the hardware is most likely non-functional if this happens.
Thanks for the update, I will merge it.
-Bryan
Quoted 24 lines
Signed-off-by Mark Brown <[email protected]>--- drivers/leds/leds-wm8350.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/leds/leds-wm8350.c +4
-2@@ -129,7 +129,10 @@ static void wm8350_led_disable(struct wm8350_led *led) ret =regulator_disable (led->isink);if (ret !=0 ) {dev_err (led->cdev.dev,"Failed to disable ISINK: %d\n" , ret); -regulator_enable (led->dcdc); + ret =regulator_enable (led->dcdc); +if (ret !=0 ) +dev_err (led->cdev.dev,"Failed to reenable DCDC: %d\n" , + ret);return ; } --1.7.10.4