Skip to contentSkip to conversation

leds: wm8350: Complain if we fail to reenable DCDC

PATCH In review Mark Brown 2 participants 2 messages Mar 6, 2013

Subsystems (2)
lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 leds: wm8350: Complain if we fail to reenable DCDC

Provide some trace, though the hardware is most likely non-functional if this happens.

---
 drivers/leds/leds-wm8350.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/leds/leds-wm8350.c +4 -1
index ed15157..8a181d5 100644
@@ -129,7 +129,10 @@ static void wm8350_led_disable(struct wm8350_led *led)
 	ret = regulator_disable(led->isink);
 	if (ret != 0) {
 		dev_err(led->cdev.dev, "Failed to disable ISINK: %d\n", ret);
-		regulator_enable(led->dcdc);
+		ret = regulator_enable(led->dcdc);
+		if (ret != 0)
+			dev_err(led->cdev.dev, "Failed to reenable DCDC: %d\n",
+				ret);
 		return;
 	}
 
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 3 lines · Mark Brown

Provide some trace, though the hardware is most likely non-functional if this happens.

Thanks for the update, I will merge it.

-Bryan

Quoted 24 lines
---
 drivers/leds/leds-wm8350.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/leds/leds-wm8350.c +4 -2
index ed15157..8a181d5 100644
@@ -129,7 +129,10 @@ static void wm8350_led_disable(struct wm8350_led *led)
        ret = regulator_disable(led->isink);
        if (ret != 0) {
                dev_err(led->cdev.dev, "Failed to disable ISINK: %d\n", ret);
-               regulator_enable(led->dcdc);
+               ret = regulator_enable(led->dcdc);
+               if (ret != 0)
+                       dev_err(led->cdev.dev, "Failed to reenable DCDC: %d\n",
+                               ret);
                return;
        }
 
--

1.7.10.4