Skip to contentSkip to conversation

ARM: DT: tegra20/tegra30: Correct clock id for UARTB

PATCH In review Laxman Dewangan 2 participants 3 messages Mar 8, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: DT: tegra20/tegra30: Correct clock id for UARTB

UARTB clock bit in CAR register is 7. Correcting this in DTS file.

---
 arch/arm/boot/dts/tegra20.dtsi |    2 +-
 arch/arm/boot/dts/tegra30.dtsi |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/tegra20.dtsi +1 -1
index bbbe2de..b89fea2 100644
@@ -260,7 +260,7 @@
 		reg-shift = <2>;
 		interrupts = <0 37 0x04>;
 		nvidia,dma-request-selector = <&apbdma 9>;
-		clocks = <&tegra_car 96>;
+		clocks = <&tegra_car 7>;
 		status = "disabled";
 	};
 
arch/arm/boot/dts/tegra30.dtsi +1 -1
index eddd0f9..0c9532b 100644
@@ -247,7 +247,7 @@
 		reg-shift = <2>;
 		interrupts = <0 37 0x04>;
 		nvidia,dma-request-selector = <&apbdma 9>;
-		clocks = <&tegra_car 160>;
+		clocks = <&tegra_car 7>;
 		status = "disabled";
 	};
 
Signature · 1 line
1.7.1.1
#1 lore raw
Quoted 2 lines · Laxman Dewangan

UARTB clock bit in CAR register is 7. Correcting this in DTS file.

The register bit is 7, but the clock ID in the Tegra CAR DT binding is 96 for UART2 or 97 for VFIR. This was due to there being 1 clock bit and 2 separate IP block reset bits, or the other way around, so we highlight the issue by assigning different clock IDs. See the comment before the list of clock IDs in the binding document.

#2 lore raw
Quoted 8 lines · Stephen Warren
Quoted 2 lines · Laxman Dewangan

UARTB clock bit in CAR register is 7. Correcting this in DTS file.

The register bit is 7, but the clock ID in the Tegra CAR DT binding is 96 for UART2 or 97 for VFIR. This was due to there being 1 clock bit and 2 separate IP block reset bits, or the other way around, so we highlight the issue by assigning different clock IDs. See the comment before the list of clock IDs in the binding document.

Aaha, I missed the Documentation part. I was looking for DT entry only found this.