bnx2fc version 1.0.14
Subsystems (2)
cover bnx2fc version 1.0.14
Hi James,
Please consider including the following patches for 3.9+ merge window.
Thanks,
Bhanu
Bhanu Prakash Gollapudi (5):
bnx2fc: Enable cached tasks to improve performance
bnx2fc: Include chip number in the symbolic name
bnx2fc: Fix race condition between IO completion and abort
bnx2fc: Update copyright information
bnx2fc: Bumped version to 1.0.14
drivers/scsi/bnx2fc/bnx2fc.h | 57 +++++++++++++++++++++++++++++++++++- drivers/scsi/bnx2fc/bnx2fc_els.c | 2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 55 ++++++++++++++++++++++++++++++----- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 8 ++++- drivers/scsi/bnx2fc/bnx2fc_io.c | 9 ++++-- drivers/scsi/bnx2fc/bnx2fc_tgt.c | 2 +- 6 files changed, 116 insertions(+), 17 deletions(-)
PATCH 1/5 bnx2fc: Enable cached tasks to improve performance
Set perf_config to 3 during firmware initialization to enable both cached connections as well as cached tasks.
--- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-)
drivers/scsi/bnx2fc/bnx2fc_hwi.c +5 -1
@@ -126,7 +126,11 @@ int bnx2fc_send_fw_fcoe_init_msg(struct bnx2fc_hba *hba) fcoe_init3.error_bit_map_lo =0xffffffff ; fcoe_init3.error_bit_map_hi =0xffffffff ; - fcoe_init3.perf_config =1 ; +/* +* enable both cached connection and cached tasks +* 0 = none, 1 = cached connection, 2 = cached tasks, 3 = both +*/ + fcoe_init3.perf_config =3 ; kwqe_arr[0 ] = (struct kwqe *) &fcoe_init1; kwqe_arr[1 ] = (struct kwqe *) &fcoe_init2;
Signature · 1 line
1.7.1
PATCH 2/5 bnx2fc: Include chip number in the symbolic name
In reply to Bhanu Prakash Gollapudi--- drivers/scsi/bnx2fc/bnx2fc.h | 53 +++++++++++++++++++++++++++++++++++++ drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 51 +++++++++++++++++++++++++++++++---- 2 files changed, 98 insertions(+), 6 deletions(-)
drivers/scsi/bnx2fc/bnx2fc.h +53 -0
@@ -68,6 +68,57 @@#define PFX "bnx2fc: " +#define BCM_CHIP_LEN 16 + +#ifndef PCI_DEVICE_ID_NX2_57710 +#define PCI_DEVICE_ID_NX2_57710 0x164e +#endif +#ifndef PCI_DEVICE_ID_NX2_57711 +#define PCI_DEVICE_ID_NX2_57711 0x164f +#endif +#ifndef PCI_DEVICE_ID_NX2_57712 +#define PCI_DEVICE_ID_NX2_57712 0x1662 +#endif +#ifndef PCI_DEVICE_ID_NX2_57712_MF +#define PCI_DEVICE_ID_NX2_57712_MF 0x1663 +#endif +#ifndef PCI_DEVICE_ID_NX2_57712_VF +#define PCI_DEVICE_ID_NX2_57712_VF 0x166f +#endif +#ifndef PCI_DEVICE_ID_NX2_57800 +#define PCI_DEVICE_ID_NX2_57800 0x168a +#endif +#ifndef PCI_DEVICE_ID_NX2_57800_MF +#define PCI_DEVICE_ID_NX2_57800_MF 0x16a5 +#endif +#ifndef PCI_DEVICE_ID_NX2_57800_VF +#define PCI_DEVICE_ID_NX2_57800_VF 0x16a9 +#endif +#ifndef PCI_DEVICE_ID_NX2_57810 +#define PCI_DEVICE_ID_NX2_57810 0x168e +#endif +#ifndef PCI_DEVICE_ID_NX2_57810_MF +#define PCI_DEVICE_ID_NX2_57810_MF 0x16ae +#endif +#ifndef PCI_DEVICE_ID_NX2_57810_VF +#define PCI_DEVICE_ID_NX2_57810_VF 0x16af +#endif +#ifndef PCI_DEVICE_ID_NX2_57840 +#define PCI_DEVICE_ID_NX2_57840 0x168d +#endif +#ifndef PCI_DEVICE_ID_NX2_57840_MF +#define PCI_DEVICE_ID_NX2_57840_MF 0x16a4 +#endif +#ifndef PCI_DEVICE_ID_NX2_57840_VF +#define PCI_DEVICE_ID_NX2_57840_VF 0x16ad +#endif +#ifndef PCI_DEVICE_ID_NX2_57840_2_20 +#define PCI_DEVICE_ID_NX2_57840_2_20 0x16a2 +#endif +#ifndef PCI_DEVICE_ID_NX2_57840_4_10 +#define PCI_DEVICE_ID_NX2_57840_4_10 0x16a1 +#endif +#define BNX2X_DOORBELL_PCI_BAR 2#define BNX2FC_MAX_BD_LEN 0xffff
@@ -243,6 +294,8 @@ struct bnx2fc_hba {int wait_for_link_down;int num_ofld_sess;struct list_head vports; + +char chip_num[BCM_CHIP_LEN ]; };struct bnx2fc_interface {
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +45 -6
82 lines not on this page · raw message
Signature · 1 line
1.7.1
James Bottomley
maintainerRe: [PATCH 2/5] bnx2fc: Include chip number in the symbolic name
Quoted 38 lines · Bhanu Prakash Gollapudi
drivers/scsi/bnx2fc/bnx2fc.h +38
-0+#ifndef PCI_DEVICE_ID_NX2_57710 +#define PCI_DEVICE_ID_NX2_57710 0x164e +#endif +#ifndef PCI_DEVICE_ID_NX2_57711 +#define PCI_DEVICE_ID_NX2_57711 0x164f +#endif +#ifndef PCI_DEVICE_ID_NX2_57712 +#define PCI_DEVICE_ID_NX2_57712 0x1662 +#endif +#ifndef PCI_DEVICE_ID_NX2_57712_MF +#define PCI_DEVICE_ID_NX2_57712_MF 0x1663 +#endif +#ifndef PCI_DEVICE_ID_NX2_57712_VF +#define PCI_DEVICE_ID_NX2_57712_VF 0x166f +#endif +#ifndef PCI_DEVICE_ID_NX2_57800 +#define PCI_DEVICE_ID_NX2_57800 0x168a +#endif +#ifndef PCI_DEVICE_ID_NX2_57800_MF +#define PCI_DEVICE_ID_NX2_57800_MF 0x16a5 +#endif +#ifndef PCI_DEVICE_ID_NX2_57800_VF +#define PCI_DEVICE_ID_NX2_57800_VF 0x16a9 +#endif +#ifndef PCI_DEVICE_ID_NX2_57810 +#define PCI_DEVICE_ID_NX2_57810 0x168e +#endif +#ifndef PCI_DEVICE_ID_NX2_57810_MF +#define PCI_DEVICE_ID_NX2_57810_MF 0x16ae +#endif +#ifndef PCI_DEVICE_ID_NX2_57810_VF +#define PCI_DEVICE_ID_NX2_57810_VF 0x16af +#endif +#ifndef PCI_DEVICE_ID_NX2_57840 +#define PCI_DEVICE_ID_NX2_57840 0x168d +#endif +#ifndef PCI_DEVICE_ID_NX2_57840_MF +#define PCI_DEVICE_ID_NX2_57840_MF 0x16a4
drivers/scsi/bnx2fc/bnx2fc.h line 120
Quoted 10 lines
drivers/scsi/bnx2fc/bnx2fc.h +10
-0+#endif +#ifndef PCI_DEVICE_ID_NX2_57840_VF +#define PCI_DEVICE_ID_NX2_57840_VF 0x16ad +#endif +#ifndef PCI_DEVICE_ID_NX2_57840_2_20 +#define PCI_DEVICE_ID_NX2_57840_2_20 0x16a2 +#endif +#ifndef PCI_DEVICE_ID_NX2_57840_4_10 +#define PCI_DEVICE_ID_NX2_57840_4_10 0x16a1 +#endif
This doesn't belong in your header file. Most of the IDs are already in pci_ids.h; I added the few which weren't.
James
Re: [PATCH 2/5] bnx2fc: Include chip number in the symbolic name
Quoted 43 lines · James Bottomley
Quoted 42 lines · Bhanu Prakash Gollapudi
drivers/scsi/bnx2fc/bnx2fc.h +42
-0+#ifndef PCI_DEVICE_ID_NX2_57710 +#define PCI_DEVICE_ID_NX2_57710 0x164e +#endif +#ifndef PCI_DEVICE_ID_NX2_57711 +#define PCI_DEVICE_ID_NX2_57711 0x164f +#endif +#ifndef PCI_DEVICE_ID_NX2_57712 +#define PCI_DEVICE_ID_NX2_57712 0x1662 +#endif +#ifndef PCI_DEVICE_ID_NX2_57712_MF +#define PCI_DEVICE_ID_NX2_57712_MF 0x1663 +#endif +#ifndef PCI_DEVICE_ID_NX2_57712_VF +#define PCI_DEVICE_ID_NX2_57712_VF 0x166f +#endif +#ifndef PCI_DEVICE_ID_NX2_57800 +#define PCI_DEVICE_ID_NX2_57800 0x168a +#endif +#ifndef PCI_DEVICE_ID_NX2_57800_MF +#define PCI_DEVICE_ID_NX2_57800_MF 0x16a5 +#endif +#ifndef PCI_DEVICE_ID_NX2_57800_VF +#define PCI_DEVICE_ID_NX2_57800_VF 0x16a9 +#endif +#ifndef PCI_DEVICE_ID_NX2_57810 +#define PCI_DEVICE_ID_NX2_57810 0x168e +#endif +#ifndef PCI_DEVICE_ID_NX2_57810_MF +#define PCI_DEVICE_ID_NX2_57810_MF 0x16ae +#endif +#ifndef PCI_DEVICE_ID_NX2_57810_VF +#define PCI_DEVICE_ID_NX2_57810_VF 0x16af +#endif +#ifndef PCI_DEVICE_ID_NX2_57840 +#define PCI_DEVICE_ID_NX2_57840 0x168d +#endif +#ifndef PCI_DEVICE_ID_NX2_57840_MF +#define PCI_DEVICE_ID_NX2_57840_MF 0x16a4 +#endif +#ifndef PCI_DEVICE_ID_NX2_57840_VF +#define PCI_DEVICE_ID_NX2_57840_VF 0x16ad +#endif
Quoted 8 lines
drivers/scsi/bnx2fc/bnx2fc.h line 120
Quoted 6 lines
drivers/scsi/bnx2fc/bnx2fc.h +6
-0+#ifndef PCI_DEVICE_ID_NX2_57840_2_20 +#define PCI_DEVICE_ID_NX2_57840_2_20 0x16a2 +#endif +#ifndef PCI_DEVICE_ID_NX2_57840_4_10 +#define PCI_DEVICE_ID_NX2_57840_4_10 0x16a1 +#endif This doesn't belong in your header file. Most of the IDs are already in
pci_ids.h; I added the few which weren't.
I had to add these since some of them were not there in pci_ids.h yet. If you have retained a few that are not in pci_ids.h file, it fine with me.
Thanks,
Bhanu
Quoted 5 lines
James
PATCH 3/5 bnx2fc: Fix race condition between IO completion and abort
In reply to Bhanu Prakash GollapudiWhen IO is successfully completed while an abort is pending, eh_abort incorrectly assumes that abort failed and performes recovery by issuing cleanup. Howerver, cleanup timesout as the firmware has no clue about this IO. Fix this by checking if the IO has already completed.
--- drivers/scsi/bnx2fc/bnx2fc_io.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
drivers/scsi/bnx2fc/bnx2fc_io.c +5 -2
@@ -1269,8 +1269,11 @@ int bnx2fc_eh_abort(struct scsi_cmnd *sc_cmd)spin_lock_bh (&tgt->tgt_lock); io_req->wait_for_comp =0 ; -if (!(test_and_set_bit (BNX2FC_FLAG_ABTS_DONE , - &io_req->req_flags))) { +if (test_bit (BNX2FC_FLAG_IO_COMPL , &io_req->req_flags)) { +BNX2FC_IO_DBG (io_req,"IO completed in a different context\n" ); + rc =SUCCESS ; + }else if (!(test_and_set_bit (BNX2FC_FLAG_ABTS_DONE , + &io_req->req_flags))) {/* Let the scsi-ml try to recover this command */ printk(KERN_ERR PFX "abort failed, xid = 0x%x\n", io_req->xid);
Signature · 1 line
1.7.1
PATCH 4/5 bnx2fc: Update copyright information
In reply to Bhanu Prakash Gollapudi--- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- drivers/scsi/bnx2fc/bnx2fc_els.c | 2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 2 +- drivers/scsi/bnx2fc/bnx2fc_io.c | 2 +- drivers/scsi/bnx2fc/bnx2fc_tgt.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
drivers/scsi/bnx2fc/bnx2fc.h +1 -1
@@ -2,7 +2,7 @@#define _BNX2FC_H_/* bnx2fc.h: Broadcom NetXtreme II Linux FCoE offload driver. * -* Copyright (c) 2008 - 2011 Broadcom Corporation +* Copyright (c) 2008 - 2013 Broadcom Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
drivers/scsi/bnx2fc/bnx2fc_els.c +1 -1
@@ -3,7 +3,7 @@* This file contains helper routines that handle ELS requests * and responses. * -* Copyright (c) 2008 - 2011 Broadcom Corporation +* Copyright (c) 2008 - 2013 Broadcom Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1 -1
@@ -3,7 +3,7 @@* cnic modules to create FCoE instances, send/receive non-offloaded * FIP/FCoE packets, listen to link events etc. * -* Copyright (c) 2008 - 2011 Broadcom Corporation +* Copyright (c) 2008 - 2013 Broadcom Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
drivers/scsi/bnx2fc/bnx2fc_hwi.c +1 -1
@@ -2,7 +2,7 @@* This file contains the code that low level functions that interact * with 57712 FCoE firmware. * -* Copyright (c) 2008 - 2011 Broadcom Corporation +* Copyright (c) 2008 - 2013 Broadcom Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
drivers/scsi/bnx2fc/bnx2fc_io.c +1 -1
@@ -1,7 +1,7 @@/* bnx2fc_io.c: Broadcom NetXtreme II Linux FCoE offload driver. * IO manager and SCSI IO processing. * -* Copyright (c) 2008 - 2011 Broadcom Corporation +* Copyright (c) 2008 - 2013 Broadcom Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
drivers/scsi/bnx2fc/bnx2fc_tgt.c +1 -1
@@ -2,7 +2,7 @@* Handles operations such as session offload/upload etc, and manages * session resources such as connection id and qp resources. * -* Copyright (c) 2008 - 2011 Broadcom Corporation +* Copyright (c) 2008 - 2013 Broadcom Corporation * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
Signature · 1 line
1.7.1
PATCH 5/5 bnx2fc: Bumped version to 1.0.14
In reply to Bhanu Prakash Gollapudi--- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/bnx2fc/bnx2fc.h +1 -1
@@ -64,7 +64,7 @@#include "bnx2fc_constants.h" #define BNX2FC_NAME "bnx2fc" -#define BNX2FC_VERSION "1.0.13" +#define BNX2FC_VERSION "1.0.14"#define PFX "bnx2fc: "
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1 -1
@@ -22,7 +22,7 @@ DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu);#define DRV_MODULE_NAME "bnx2fc"#define DRV_MODULE_VERSION BNX2FC_VERSION -#define DRV_MODULE_RELDATE "Dec 21, 2012" +#define DRV_MODULE_RELDATE "Mar 08, 2012" static char version[] =
Signature · 1 line
1.7.1
Re: [PATCH 5/5] bnx2fc: Bumped version to 1.0.14
Quoted 24 lines · Bhanu Prakash Gollapudi
Signed-off-by Bhanu Prakash Gollapudi <[email protected]>--- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/scsi/bnx2fc/bnx2fc.h +1
-1@@ -64,7 +64,7 @@#include "bnx2fc_constants.h" #define BNX2FC_NAME "bnx2fc" -#define BNX2FC_VERSION "1.0.13" +#define BNX2FC_VERSION "1.0.14"#define PFX "bnx2fc: "drivers/scsi/bnx2fc/bnx2fc_fcoe.c +0
-0
drivers/scsi/bnx2fc/bnx2fc_fcoe.c DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu); · line 25
Quoted 5 lines
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1
-1@@ -22,7 +22,7 @@ DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu);#define DRV_MODULE_NAME "bnx2fc"#define DRV_MODULE_VERSION BNX2FC_VERSION -#define DRV_MODULE_RELDATE "Dec 21, 2012" +#define DRV_MODULE_RELDATE "Mar 08, 2012"
James, I realized there was a typo in the date - 2012 instead of 2013.
Please apply this patch instead. Sorry for the inconvenience.
--- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/bnx2fc/bnx2fc.h +1 -1
@@ -64,7 +64,7 @@#include "bnx2fc_constants.h" #define BNX2FC_NAME "bnx2fc" -#define BNX2FC_VERSION "1.0.13" +#define BNX2FC_VERSION "1.0.14"#define PFX "bnx2fc: "
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1 -1
@@ -22,7 +22,7 @@ DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu);#define DRV_MODULE_NAME "bnx2fc"#define DRV_MODULE_VERSION BNX2FC_VERSION -#define DRV_MODULE_RELDATE "Dec 21, 2012" +#define DRV_MODULE_RELDATE "Mar 08, 2013" static char version[] =
Signature · 5 lines
1.7.1 thanks, Bhanu
Quoted 3 lines
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +0
-0static char version[] =
James Bottomley
maintainerRe: [PATCH 5/5] bnx2fc: Bumped version to 1.0.14
Quoted 60 lines · Bhanu Prakash Gollapudi
Quoted 24 lines · Bhanu Prakash Gollapudi
Signed-off-by Bhanu Prakash Gollapudi <[email protected]>--- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/scsi/bnx2fc/bnx2fc.h +1
-1@@ -64,7 +64,7 @@#include "bnx2fc_constants.h" #define BNX2FC_NAME "bnx2fc" -#define BNX2FC_VERSION "1.0.13" +#define BNX2FC_VERSION "1.0.14"#define PFX "bnx2fc: "drivers/scsi/bnx2fc/bnx2fc_fcoe.c +0
-0drivers/scsi/bnx2fc/bnx2fc_fcoe.c DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu); · line 25
Quoted 5 lines
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1
-1@@ -22,7 +22,7 @@ DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu);#define DRV_MODULE_NAME "bnx2fc"#define DRV_MODULE_VERSION BNX2FC_VERSION -#define DRV_MODULE_RELDATE "Dec 21, 2012" +#define DRV_MODULE_RELDATE "Mar 08, 2012"James, I realized there was a typo in the date - 2012 instead of 2013.
Please apply this patch instead. Sorry for the inconvenience.
Signed-off-by Bhanu Prakash Gollapudi <[email protected]>--- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/scsi/bnx2fc/bnx2fc.h +1
-1@@ -64,7 +64,7 @@#include "bnx2fc_constants.h" #define BNX2FC_NAME "bnx2fc" -#define BNX2FC_VERSION "1.0.13" +#define BNX2FC_VERSION "1.0.14"#define PFX "bnx2fc: "drivers/scsi/bnx2fc/bnx2fc_fcoe.c +0
-0
drivers/scsi/bnx2fc/bnx2fc_fcoe.c DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu); · line 25
Quoted 5 lines
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1
-1@@ -22,7 +22,7 @@ DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu);#define DRV_MODULE_NAME "bnx2fc"#define DRV_MODULE_VERSION BNX2FC_VERSION -#define DRV_MODULE_RELDATE "Dec 21, 2012" +#define DRV_MODULE_RELDATE "Mar 08, 2013"
This doesn't actually apply ... your mailer has converted tabs to spaces. Since it's only a couple of lines, I fixed it up by hand this time ...
James
Re: [PATCH 5/5] bnx2fc: Bumped version to 1.0.14
Quoted 70 lines · James Bottomley
Quoted 60 lines · Bhanu Prakash Gollapudi
Quoted 24 lines · Bhanu Prakash Gollapudi
Signed-off-by Bhanu Prakash Gollapudi <[email protected]>--- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/scsi/bnx2fc/bnx2fc.h +1
-1@@ -64,7 +64,7 @@#include "bnx2fc_constants.h" #define BNX2FC_NAME "bnx2fc" -#define BNX2FC_VERSION "1.0.13" +#define BNX2FC_VERSION "1.0.14"#define PFX "bnx2fc: "drivers/scsi/bnx2fc/bnx2fc_fcoe.c +0
-0drivers/scsi/bnx2fc/bnx2fc_fcoe.c DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu); · line 25
Quoted 5 lines
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1
-1@@ -22,7 +22,7 @@ DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu);#define DRV_MODULE_NAME "bnx2fc"#define DRV_MODULE_VERSION BNX2FC_VERSION -#define DRV_MODULE_RELDATE "Dec 21, 2012" +#define DRV_MODULE_RELDATE "Mar 08, 2012"James, I realized there was a typo in the date - 2012 instead of 2013.
Please apply this patch instead. Sorry for the inconvenience.
Signed-off-by Bhanu Prakash Gollapudi <[email protected]>--- drivers/scsi/bnx2fc/bnx2fc.h | 2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/scsi/bnx2fc/bnx2fc.h +1
-1@@ -64,7 +64,7 @@#include "bnx2fc_constants.h" #define BNX2FC_NAME "bnx2fc" -#define BNX2FC_VERSION "1.0.13" +#define BNX2FC_VERSION "1.0.14"#define PFX "bnx2fc: "drivers/scsi/bnx2fc/bnx2fc_fcoe.c +0
-0drivers/scsi/bnx2fc/bnx2fc_fcoe.c DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu); · line 25
Quoted 5 lines
drivers/scsi/bnx2fc/bnx2fc_fcoe.c +1
-1@@ -22,7 +22,7 @@ DEFINE_PER_CPU(struct bnx2fc_percpu_s, bnx2fc_percpu);#define DRV_MODULE_NAME "bnx2fc"#define DRV_MODULE_VERSION BNX2FC_VERSION -#define DRV_MODULE_RELDATE "Dec 21, 2012" +#define DRV_MODULE_RELDATE "Mar 08, 2013"This doesn't actually apply ... your mailer has converted tabs to spaces. Since it's only a couple of lines, I fixed it up by hand this time ...
Quoted 4 lines
James
Thanks for taking care of this, James.
Bhanu
Quoted 14 lines · Bhanu Prakash Gollapudi
Hi James,
Please consider including the following patches for 3.9+ merge window.
Thanks,
BhanuBhanu Prakash Gollapudi (5):
bnx2fc: Enable cached tasks to improve performance
bnx2fc: Include chip number in the symbolic name
bnx2fc: Fix race condition between IO completion and abort
bnx2fc: Update copyright information
bnx2fc: Bumped version to 1.0.14
Quoted 8 lines
drivers/scsi/bnx2fc/bnx2fc.h | 57 +++++++++++++++++++++++++++++++++++- drivers/scsi/bnx2fc/bnx2fc_els.c | 2 +- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 55 ++++++++++++++++++++++++++++++----- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 8 ++++- drivers/scsi/bnx2fc/bnx2fc_io.c | 9 ++++-- drivers/scsi/bnx2fc/bnx2fc_tgt.c | 2 +- 6 files changed, 116 insertions(+), 17 deletions(-)
Hi James,
I see that these patches were not picked up by you yet. Please let me know if you're waiting for any information.
thanks,
Bhanu