ACPI: suppress compiler warnings in button.c

PATCH Applied Andy Shevchenko 3 participants 7 messages Mar 11, 2013 – Apr 12, 2013

Subsystems (2)

ACPI PCI

lore

Share & tools

lore

Andy Shevchenko

author

2013-03-11 09:17 UTC #0 lore raw

PATCH v2 1/5 ACPI: suppress compiler warnings in button.c

This patch fixes following compiler warnings when build via make W=1:

drivers/acpi/button.c:220:5: warning: no previous prototype for ‘acpi_lid_notifier_register’ [-Wmissing-prototypes] drivers/acpi/button.c:226:5: warning: no previous prototype for ‘acpi_lid_notifier_unregister’ [-Wmissing-prototypes] drivers/acpi/button.c:232:5: warning: no previous prototype for ‘acpi_lid_open’ [-Wmissing-prototypes]

Signed-off-by Andy Shevchenko <[email protected]>

---
 drivers/acpi/button.c | 1 +
 1 file changed, 1 insertion(+)

drivers/acpi/button.c +1 -0

index 86c7d54..92a659a 100644
@@ -33,6 +33,7 @@
 #include <linux/slab.h>
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
+#include <acpi/button.h>
 
 #define PREFIX "ACPI: "

Signature · 6 lines

1.8.2.rc0.22.gb3600c3

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Andy Shevchenko

author

2013-03-11 09:17 UTC #1 lore raw

PATCH v2 2/5 ACPI: suppress compiler warnings in processor_throttling.c

This patch fixes following compiler warnings when build via make W=1:

drivers/acpi/processor_throttling.c: In function ‘acpi_processor_throttling_init’:
drivers/acpi/processor_throttling.c:216:40: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]

Signed-off-by Andy Shevchenko <[email protected]>

---
 drivers/acpi/processor_throttling.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/acpi/processor_throttling.c +2 -1

index 1d02b7b..e7dd2c1 100644
@@ -211,9 +211,10 @@ err_ret:
  */
 void acpi_processor_throttling_init(void)
 {
-	if (acpi_processor_update_tsd_coord())
+	if (acpi_processor_update_tsd_coord()) {
 		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
 			"Assume no T-state coordination\n"));
+	}
 
 	return;
 }

Signature · 6 lines

1.8.2.rc0.22.gb3600c3

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Andy Shevchenko

author

2013-03-11 09:17 UTC #2 lore raw

PATCH v2 3/5 ACPI: suppress compiler warning in battery.c

In reply to Andy Shevchenko

This patch fixes following compiler warning when build via make W=1:

drivers/acpi/battery.c:149:52: warning: no previous prototype for ‘acpi_battery_present’ [-Wmissing-prototypes]

Signed-off-by Andy Shevchenko <[email protected]>

---
 drivers/acpi/battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/acpi/battery.c +1 -1

index c5cd5b5..0cc384b 100644
@@ -146,7 +146,7 @@ struct acpi_battery {
 
 #define to_acpi_battery(x) container_of(x, struct acpi_battery, bat)
 
-inline int acpi_battery_present(struct acpi_battery *battery)
+static inline int acpi_battery_present(struct acpi_battery *battery)
 {
 	return battery->device->status.battery_present;
 }

Signature · 6 lines

1.8.2.rc0.22.gb3600c3

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Andy Shevchenko

author

2013-03-11 09:17 UTC #3 lore raw

PATCH v2 4/5 ACPI: suppress compiler warning in container.c

In reply to Andy Shevchenko

This patch fixes following compiler warning when build via make W=1:

drivers/acpi/container.c:183:116: warning: no previous prototype for ‘acpi_container_init’ [-Wmissing-prototypes]

Signed-off-by Andy Shevchenko <[email protected]>

---
 drivers/acpi/container.c | 2 ++
 1 file changed, 2 insertions(+)

drivers/acpi/container.c +2 -0

index 5523ba7..6624c01 100644
@@ -35,6 +35,8 @@
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
 
+#include "internal.h"
+
 #define PREFIX "ACPI: "
 
 #define _COMPONENT			ACPI_CONTAINER_COMPONENT

Signature · 6 lines

1.8.2.rc0.22.gb3600c3

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Andy Shevchenko

author

2013-03-11 09:17 UTC #4 lore raw

PATCH v2 5/5 ACPI / pcie: suppress compiler warning in portdrv_acpi.c

In reply to Andy Shevchenko

This patch fixes following compiler warning when build via make W=1:

drivers/pci/pcie/portdrv_acpi.c:34:5: warning: no previous prototype for ‘pcie_port_acpi_setup’ [-Wmissing-prototypes]

Signed-off-by Andy Shevchenko <[email protected]>

Cc Bjorn Helgaas <[email protected]>

Cc [email protected]

---
 drivers/pci/pcie/portdrv_acpi.c | 1 +
 1 file changed, 1 insertion(+)

drivers/pci/pcie/portdrv_acpi.c +1 -0

index a86b56e..b4d2894 100644
@@ -17,6 +17,7 @@
 
 #include "aer/aerdrv.h"
 #include "../pci.h"
+#include "portdrv.h"
 
 /**
  * pcie_port_acpi_setup - Request the BIOS to release control of PCIe services.

Signature · 1 line

1.8.2.rc0.22.gb3600c3

Bjorn Helgaas

maintainer Applied

2013-04-12 20:54 UTC #5 lore raw

Re: [PATCHv2 5/5] ACPI / pcie: suppress compiler warning in portdrv_acpi.c

Quoted 7 lines · Andy Shevchenko

This patch fixes following compiler warning when build via make W=1:
drivers/pci/pcie/portdrv_acpi.c:34:5: warning: no previous prototype for ‘pcie_port_acpi_setup’ [-Wmissing-prototypes]
Signed-off-by Andy Shevchenko <[email protected]>
Cc Bjorn Helgaas <[email protected]>
Cc [email protected]

I applied this and several similar patches to my pci/cleanup branch for v3.10. Thanks!

http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/cleanup

Bjorn

Quoted 17 lines

---
 drivers/pci/pcie/portdrv_acpi.c | 1 +
 1 file changed, 1 insertion(+)

drivers/pci/pcie/portdrv_acpi.c +1 -1

index a86b56e..b4d2894 100644
@@ -17,6 +17,7 @@
 
 #include "aer/aerdrv.h"
 #include "../pci.h"
+#include "portdrv.h"
 
 /**
  * pcie_port_acpi_setup - Request the BIOS to release control of PCIe services.
--

Quoted 2 lines

1.8.2.rc0.22.gb3600c3

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Rafael J. Wysocki

2013-03-26 13:19 UTC #6 lore raw

In reply to Andy Shevchenko

Quoted 7 lines · Andy Shevchenko

This patch fixes following compiler warnings when build via make W=1:
drivers/acpi/button.c:220:5: warning: no previous prototype for ‘acpi_lid_notifier_register’ [-Wmissing-prototypes] drivers/acpi/button.c:226:5: warning: no previous prototype for ‘acpi_lid_notifier_unregister’ [-Wmissing-prototypes] drivers/acpi/button.c:232:5: warning: no previous prototype for ‘acpi_lid_open’ [-Wmissing-prototypes]
Signed-off-by Andy Shevchenko <[email protected]>

Patches [1-4/5] applied to linux-pm.git/linux-next. I'm leaving patch [5/5] to Bjorn.

Thanks,
Rafael

Quoted 17 lines

---
 drivers/acpi/button.c | 1 +
 1 file changed, 1 insertion(+)

drivers/acpi/button.c +1 -0

index 86c7d54..92a659a 100644
@@ -33,6 +33,7 @@
 #include <linux/slab.h>
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
+#include <acpi/button.h>
 
 #define PREFIX "ACPI: "

Signature · 6 lines

I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html