Skip to contentSkip to conversation

Arch: x86: kernel: smpboot.c: Remove unused variable

PATCH In review Valentin Ilie 3 participants 3 messages Mar 11, 2013 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Arch: x86: kernel: smpboot.c: Remove unused variable

Remove unused variable 'c'

---
 arch/x86/kernel/smpboot.c |    1 -
 1 file changed, 1 deletion(-)
arch/x86/kernel/smpboot.c +0 -1
index a6ceaed..7bc998a 100644
@@ -1367,7 +1367,6 @@ static inline void mwait_play_dead(void)
 	unsigned int highest_subcstate = 0;
 	int i;
 	void *mwait_ptr;
-	struct cpuinfo_x86 *c = __this_cpu_ptr(&cpu_info);
 
 	if (!this_cpu_has(X86_FEATURE_MWAIT))
 		return;
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 20 lines · Valentin Ilie

Remove unused variable 'c'

---
 arch/x86/kernel/smpboot.c |    1 -
 1 file changed, 1 deletion(-)
arch/x86/kernel/smpboot.c +0 -2
index a6ceaed..7bc998a 100644
@@ -1367,7 +1367,6 @@ static inline void mwait_play_dead(void)
        unsigned int highest_subcstate = 0;
        int i;
        void *mwait_ptr;
-       struct cpuinfo_x86 *c = __this_cpu_ptr(&cpu_info);
 
        if (!this_cpu_has(X86_FEATURE_MWAIT))
                return;
--
Quoted 1 line

1.7.10.4

Hi Valentin,

I guess a better subject for this patch should be
x86, smpboot: Remove unused variable

Use git log arch/x86/kernel/smpboot.c to check previous commits.

thanks,
Daniel.

#2 lore raw
In reply to Valentin Ilie
Quoted 13 lines · Valentin Ilie

Remove unused variable 'c'

---
 arch/x86/kernel/smpboot.c |    1 -
 1 file changed, 1 deletion(-)
arch/x86/kernel/smpboot.c +0 -0
index a6ceaed..7bc998a 100644

arch/x86/kernel/smpboot.c static inline void mwait_play_dead(void) · line 1372

Quoted 7 lines
arch/x86/kernel/smpboot.c +0 -1
@@ -1367,7 +1367,6 @@ static inline void mwait_play_dead(void)
 	unsigned int highest_subcstate = 0;
 	int i;
 	void *mwait_ptr;
-	struct cpuinfo_x86 *c = __this_cpu_ptr(&cpu_info);
 
 	if (!this_cpu_has(X86_FEATURE_MWAIT))
 		return;

Already done.

-hpa