Skip to contentSkip to conversation

ARM: dt: tegra114: add PWM nodes

PATCH Applied Andrew Chew 4 participants 7 messages Mar 11, 2013 – Mar 12, 2013 4 messages not in the archive

Subsystems (2)
Device tree bindings Tegra architecture support

v2 of 4 Applied Latest is v4 →

lore
Share & tools
lore

Andrew Chew

author
#0 lore raw

PATCH v2 1/1 ARM: dt: tegra114: add PWM nodes

This patch adds device tree nodes for the four PWM controllers present on Tegra114.

Signed-off-by Andrew Chew <[email protected]>

---
Fixed commit message.
Corrected the compatible property.
Placed PWM nodes in the right place such that nodes are sorted by register address.

 arch/arm/boot/dts/tegra114.dtsi |   32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm/boot/dts/tegra114.dtsi +32 -0
index 1dfaf28..5741ae4 100644
@@ -92,6 +92,38 @@
 		status = "disabled";
 	};
 
+	pwm0: pwm@7000a000 {
+		compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a000 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm1: pwm@7000a010 {
+		compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a010 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm2: pwm@7000a020 {
+		compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a020 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm3: pwm@7000a030 {
+		compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a030 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
 	rtc {
 		compatible = "nvidia,tegra114-rtc", "nvidia,tegra20-rtc";
 		reg = <0x7000e000 0x100>;
Signature · 1 line
1.7.9.5

A message that is not in the archive (sent off-list or not yet received): 1363045695-28874-1-git-send-email-achew-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#2 lore raw

Hi Andrew,

Quoted 18 lines · On Tue, 12 Mar 2013 00:48:15 +0100 Andrew Chew…

This patch adds device tree nodes for the four PWM controllers present on Tegra114.

Signed-off-by Andrew Chew <[email protected]>

---
Fixed commit message.
Corrected the compatible property.
Placed PWM nodes in the right place such that nodes are sorted by register address.

 arch/arm/boot/dts/tegra114.dtsi |   32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm/boot/dts/tegra114.dtsi +0 -0
index 1dfaf28..5741ae4 100644

arch/arm/boot/dts/tegra114.dtsi line 99

Quoted 8 lines
arch/arm/boot/dts/tegra114.dtsi +5 -0
@@ -92,6 +92,38 @@
 		status = "disabled";
 	};
 
+	pwm0: pwm@7000a000 {
+		compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a000 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;

FYI:
I'm sending out the patch(v4) to replace car magic # with macro[1]. Then you could replace the above magic #s with macro names.

[1] http://patchwork.ozlabs.org/patch/220680/

A message that is not in the archive (sent off-list or not yet received): 20130312112340.6d624df5dfe28c4b5b8157f5-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#4 lore raw
Quoted 20 lines · Hiroshi Doyu

Hi Andrew,

arch/arm/boot/dts/tegra114.dtsi line 99

Quoted 10 lines · On Tue, 12 Mar 2013 00:48:15 +0100 Andrew Chew…

This patch adds device tree nodes for the four PWM controllers present on Tegra114.

arch/arm/boot/dts/tegra114.dtsi +5 -0
 
+	pwm0: pwm@7000a000 {
+		compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a000 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;

FYI:
I'm sending out the patch(v4) to replace car magic # with macro[1]. Then you could replace the above magic #s with macro names.

Quoted 1 line

[1] http://patchwork.ozlabs.org/patch/220680/

Since the ground-work for dtc+cpp usage isn't complete yet, and it's progress has been a little slow, I'm going to have all new DT nodes use the existing numeric scheme, and put them into Tegra's for-3.10/dt branch. Then, if we actually end up being able to convert to using dtc+cpp in 3.10, I'll create a new branch based on that for the conversion itself. Both you and I will need to rebase our conversion patches on top of all the other DT additions at that time.

Applied
#5 lore raw
In reply to a message not in the archive
Quoted 2 lines · Andrew Chew

This patch adds device tree nodes for the four PWM controllers present on Tegra114.

Applied to Tegra's for-3.10/dt branch.

I changed the patch subject to:
ARM: tegra: add PWM nodes to Tegra114 DT

tegra114: isn't a valid sub-system tag; it's tegra:. I tend not to include dt: now.

#6 lore raw
In reply to a message not in the archive

On Mon, Mar 11, 2013 at 04:48:15PM -0700, Andrew Chew wrote:
[...]

Quoted 1 line
arch/arm/boot/dts/tegra114.dtsi +0 -0

[...]

Quoted 21 lines
arch/arm/boot/dts/tegra114.dtsi +21 -0
+	pwm0: pwm@7000a000 {
+		compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a000 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm1: pwm@7000a010 {
+		compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a010 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};
+
+	pwm2: pwm@7000a020 {
+		compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a020 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;

arch/arm/boot/dts/tegra114.dtsi line 125

Quoted 10 lines
arch/arm/boot/dts/tegra114.dtsi +10 -0
+		status = "disabled";
+	};
+
+	pwm3: pwm@7000a030 {
+		compatible = "nvidia,tegra114-pwm", "nvidia,tegra20-pwm";
+		reg = <0x7000a030 0x4>;
+		#pwm-cells = <2>;
+		clocks = <&tegra_car 17>;
+		status = "disabled";
+	};

Shouldn't these rather go into a single PWM node which provides 4 PWM devices? Just like we do on Tegra20?

Thierry

A message that is not in the archive (sent off-list or not yet received): 20130312192429.GA21924-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/[email protected]

#8 lore raw
Quoted 5 lines · Thierry Reding

On Mon, Mar 11, 2013 at 04:48:15PM -0700, Andrew Chew wrote: [...]

Quoted 2 lines
arch/arm/boot/dts/tegra114.dtsi +0 -0

[...]

Quoted 1 line
arch/arm/boot/dts/tegra114.dtsi +1 -0
+	pwm0: pwm@7000a000 {

...

Quoted 1 line
Quoted 1 line
arch/arm/boot/dts/tegra114.dtsi +1 -0
+	pwm1: pwm@7000a010 {

...

Quoted 1 line
Quoted 1 line
arch/arm/boot/dts/tegra114.dtsi +1 -0
+	pwm2: pwm@7000a020 {

...

Quoted 1 line
Quoted 1 line
arch/arm/boot/dts/tegra114.dtsi +1 -0
+	pwm3: pwm@7000a030 {

...

Quoted 3 lines

Shouldn't these rather go into a single PWM node which provides 4 PWM devices? Just like we do on Tegra20?

Oh yes. Thanks for catching that. I'll remove the patch from the Tegra tree for now until that's fixed.

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#10 lore raw
Quoted 17 lines

From: Stephen Warren [mailto:[email protected]]
Sent: Tuesday, March 12, 2013 12:35 PM
To: Thierry Reding
Cc: Andrew Chew; Hiroshi Doyu; [email protected]
Subject: Re: [PATCH 1/1 v2] ARM: dt: tegra114: add PWM nodes

Quoted 5 lines · Thierry Reding

On Mon, Mar 11, 2013 at 04:48:15PM -0700, Andrew Chew wrote: [...]

Quoted 2 lines
arch/arm/boot/dts/tegra114.dtsi +0 -0

[...]

Quoted 1 line
arch/arm/boot/dts/tegra114.dtsi +1 -0
+	pwm0: pwm@7000a000 {

...

Quoted 1 line
Quoted 1 line
arch/arm/boot/dts/tegra114.dtsi +1 -0
+	pwm1: pwm@7000a010 {

...

Quoted 1 line
Quoted 1 line
arch/arm/boot/dts/tegra114.dtsi +1 -0
+	pwm2: pwm@7000a020 {

...

Quoted 8 lines
Quoted 1 line
Quoted 1 line
arch/arm/boot/dts/tegra114.dtsi +1 -0
+	pwm3: pwm@7000a030 {

...

Quoted 3 lines

Shouldn't these rather go into a single PWM node which provides 4 PWM devices? Just like we do on Tegra20?

Oh yes. Thanks for catching that. I'll remove the patch from the Tegra tree for now until that's fixed.

Does that work? Let me try that, using Tegra20 as guidance.