regmap: Expose total memory consumption in the rbtree debugfs entry
Subsystems (2)
PATCH v2 1/1 regmap: Expose total memory consumption in the rbtree debugfs entry
Provide a feel of how much overhead the rbtree cache adds to the game.
---
Print the size in bytes instead of kB.
drivers/base/regmap/regcache-rbtree.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/base/regmap/regcache-rbtree.c +7 -2
@@ -138,15 +138,20 @@ static int rbtree_show(struct seq_file *s, void *ignored)struct regcache_rbtree_node *n;struct rb_node *node;unsigned int base, top; +size_t mem_size;int nodes =0 ;int registers =0 ;int this_registers, average; map->lock (map); + mem_size =sizeof (*rbtree_ctx); +for (node =rb_first (&rbtree_ctx->root); node !=NULL ; node =rb_next (node)) { n = container_of(node, struct regcache_rbtree_node, node); + mem_size +=sizeof (*n); + mem_size += (n->blklen * map->cache_word_size);regcache_rbtree_get_base_top_reg (map, n, &base, &top); this_registers = ((top - base) / map->reg_stride) +1 ;
@@ -161,8 +166,8 @@ static int rbtree_show(struct seq_file *s, void *ignored)else average =0 ; -seq_printf (s,"%d nodes, %d registers, average %d registers\n" , - nodes, registers, average); +seq_printf (s,"%d nodes, %d registers, average %d registers, memory overhead %zuB\n" , + nodes, registers, average, mem_size); map->unlock (map);
Signature · 1 line
1.8.1.5
drivers/base/regmap/regcache-rbtree.c static int rbtree_show(struct seq_file *s, void *ignored) · line 154
Quoted 7 lines · Dimitris Papastamos
drivers/base/regmap/regcache-rbtree.c +4
-0+ mem_size =sizeof (*rbtree_ctx); +for (node =rb_first (&rbtree_ctx->root); node !=NULL ; node =rb_next (node)) { n = container_of(node, struct regcache_rbtree_node, node); + mem_size +=sizeof (*n); + mem_size += (n->blklen * map->cache_word_size);
This appears to ignore the size of the node structure and only have the root context and the data.
Quoted 12 lines · Mark Brown
drivers/base/regmap/regcache-rbtree.c static int rbtree_show(struct seq_file *s, void *ignored) · line 154
Quoted 7 lines · Dimitris Papastamos
drivers/base/regmap/regcache-rbtree.c +4
-0+ mem_size =sizeof (*rbtree_ctx); +for (node =rb_first (&rbtree_ctx->root); node !=NULL ; node =rb_next (node)) { n = container_of(node, struct regcache_rbtree_node, node); + mem_size +=sizeof (*n); + mem_size += (n->blklen * map->cache_word_size);This appears to ignore the size of the node structure and only have the root context and the data.
I've got mem_size += sizeof(*n) which is the size of the rbnode. That contains the underlying rbtree node links.
Thanks,
Dimitris
Mark Brown
AppliedQuoted 2 lines · Dimitris Papastamos
Provide a feel of how much overhead the rbtree cache adds to the game.
Applied, with a tweak to the log to say "used X bytes" for clarity (it's arguable if the cached data itself is overhead, depends on what you're comparing to).
Quoted 7 lines · Mark Brown
Quoted 2 lines · Dimitris Papastamos
Provide a feel of how much overhead the rbtree cache adds to the game.
Applied, with a tweak to the log to say "used X bytes" for clarity (it's arguable if the cached data itself is overhead, depends on what you're comparing to).
Aha yes, it makes sense.
Thanks,
Dimitris