Skip to contentSkip to conversation

assembler: Add a regions visualizer tool

PATCH In review Chris Cummins 2 participants 3 messages Mar 12, 2013 – Mar 19, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 assembler: Add a regions visualizer tool

This adds a html/js tool for visualizing GEN instruction source operand regions, similar to those used in the Programmer's Reference Manual. To use the tool, open the file assembler/gen_regions/gen_regions.html in your browser-of-preference.

---
 assembler/Makefile.am                              |   17 +
 .../assets/css/bootstrap-responsive.css            | 1109 +++
 assembler/gen_regions/assets/css/bootstrap.css     | 6158 +++++++++++++
 assembler/gen_regions/assets/js/bootstrap-alert.js |   99 +
 .../gen_regions/assets/js/bootstrap-button.js      |  105 +
 .../gen_regions/assets/js/bootstrap-collapse.js    |  167 +
 .../gen_regions/assets/js/bootstrap-dropdown.js    |  165 +
 assembler/gen_regions/assets/js/bootstrap.js       | 2276 +++++
 assembler/gen_regions/assets/js/gen_regions.js     |  795 ++
 assembler/gen_regions/assets/js/jquery-1.9.1.js    | 9597 ++++++++++++++++++++
 .../gen_regions/assets/js/jquery-migrate-1.1.1.js  |  511 ++
 .../gen_regions/assets/js/jquery.ba-hashchange.js  |  390 +
 assembler/gen_regions/assets/js/jquery.hotkeys.js  |  100 +
 assembler/gen_regions/gen_regions.html             |  173 +
 14 files changed, 21662 insertions(+)
 create mode 100644 assembler/gen_regions/assets/css/bootstrap-responsive.css
 create mode 100644 assembler/gen_regions/assets/css/bootstrap.css
 create mode 100644 assembler/gen_regions/assets/js/bootstrap-alert.js
 create mode 100644 assembler/gen_regions/assets/js/bootstrap-button.js
 create mode 100644 assembler/gen_regions/assets/js/bootstrap-collapse.js
 create mode 100644 assembler/gen_regions/assets/js/bootstrap-dropdown.js
 create mode 100644 assembler/gen_regions/assets/js/bootstrap.js
 create mode 100644 assembler/gen_regions/assets/js/gen_regions.js
 create mode 100644 assembler/gen_regions/assets/js/jquery-1.9.1.js
 create mode 100644 assembler/gen_regions/assets/js/jquery-migrate-1.1.1.js
 create mode 100644 assembler/gen_regions/assets/js/jquery.ba-hashchange.js
 create mode 100644 assembler/gen_regions/assets/js/jquery.hotkeys.js
 create mode 100644 assembler/gen_regions/gen_regions.html
assembler/Makefile.am +17 -0
index 95ba08d..cbc29a1 100644
@@ -44,8 +44,25 @@ intel_gen4disasm_LDADD = libbrw.la
 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = intel-gen4asm.pc
 
+gen_regions_files = 					\
+	gen_regions/gen_regions.html			\
+	gen_regions/assets/css/bootstrap-responsive.css	\
+	gen_regions/assets/css/bootstrap.css		\
+	gen_regions/assets/js/jquery-1.9.1.js		\
+	gen_regions/assets/js/jquery.ba-hashchange.js	\
+	gen_regions/assets/js/jquery.hotkeys.js		\
+	gen_regions/assets/js/bootstrap-alert.js	\
+	gen_regions/assets/js/bootstrap-collapse.js	\
+	gen_regions/assets/js/gen_regions.js		\
+	gen_regions/assets/js/bootstrap-button.js	\
+	gen_regions/assets/js/bootstrap.js		\
+	gen_regions/assets/js/bootstrap-dropdown.js	\
+	gen_regions/assets/js/jquery-migrate-1.1.1.js	\
+	$(NULL)
+
 MAINTAINERCLEANFILES = $(BUILT_SOURCES)
 EXTRA_DIST = \
+	$(gen_regions_files) \
 	README \
 	TODO \
 	intel-gen4asm.pc.in
assembler/gen_regions/assets/css/bootstrap-responsive.css new file +1109 -0

1,109 lines not on this page · raw message

assembler/gen_regions/assets/css/bootstrap.css new file +6158 -0

1,866 lines not on this page · raw message

assembler/gen_regions/assets/js/bootstrap-alert.js new file +99 -0

99 lines not on this page · raw message

assembler/gen_regions/assets/js/bootstrap-button.js new file +105 -0

105 lines not on this page · raw message

assembler/gen_regions/assets/js/bootstrap-collapse.js new file +167 -0

167 lines not on this page · raw message

assembler/gen_regions/assets/js/bootstrap-dropdown.js new file +165 -0

165 lines not on this page · raw message

assembler/gen_regions/assets/js/bootstrap.js new file +2276 -0

2,276 lines not on this page · raw message

assembler/gen_regions/assets/js/gen_regions.js new file +795 -0

795 lines not on this page · raw message

assembler/gen_regions/assets/js/jquery-1.9.1.js new file +9597 -0

9,597 lines not on this page · raw message

assembler/gen_regions/assets/js/jquery-migrate-1.1.1.js new file +511 -0

511 lines not on this page · raw message

assembler/gen_regions/assets/js/jquery.ba-hashchange.js new file +390 -0

390 lines not on this page · raw message

assembler/gen_regions/assets/js/jquery.hotkeys.js new file +100 -0

100 lines not on this page · raw message

assembler/gen_regions/gen_regions.html new file +173 -0

173 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 6 lines
1.8.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Part of the diff is not shown here. View the raw message.

#1 lore raw
Quoted 4 lines · Chris Cummins

This adds a html/js tool for visualizing GEN instruction source operand regions, similar to those used in the Programmer's Reference Manual. To use the tool, open the file assembler/gen_regions/gen_regions.html in your browser-of-preference.

To give more details about that work, there's nothing better than examples, visualizing regions taken directly from the published IVB documentation:

http://damien.lespiau.name/intel/gen_regions.html#execsize=16&region=g4.2<16;8,2>w&advanced=0

http://damien.lespiau.name/intel/gen_regions.html#execsize=16&region=r5.0<1;8,2>:w&advanced=0

A quick review trying to use the tool:

* I think it'd be better if byte 0 is at the right, it seems to be the usual ways to represent registers, lower bits at the right.
* there's a bug when giving advanced=1 on the URL, the tool doesn't seem to take it into account
* it'd be nice to get rid of the trailing white space (no review would be complete without a mention to trailing white space, rule #1 of the open source world) from the imported js files, I usually use a script around:
sed -i -e 's,[ \t]*$,,' $file

Signature · 1 line
Damien
#2 lore raw

Hi Damien,

thanks a lot for the review.

Quoted 11 lines · Damien Lespiau

A quick review trying to use the tool:

* I think it'd be better if byte 0 is at the right, it seems to be the usual ways to represent registers, lower bits at the right.
* there's a bug when giving advanced=1 on the URL, the tool doesn't seem to take it into account
* it'd be nice to get rid of the trailing white space (no review would be complete without a mention to trailing white space, rule #1 of the open source world) from the imported js files, I usually use a script around:
sed -i -e 's,[ \t]*$,,' $file

I've pushed a branch to GitHub which implements these improvements, and can be used for temporary work-in-progress before squashing and resubmitting:

git://github.com/ChrisCummins/intel-gpu-tools.git wip/gen_regions

Regards,
Chris