dma: ipu: ipu_idmac: Fix section mismatch
PATCH 1/1 dma: ipu: ipu_idmac: Fix section mismatch
From: Fabio Estevam <[email protected]>
Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p() references) the following section mismatch happens:
WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function ipu_remove() to the function .exit.text:ipu_idmac_exit() The function ipu_remove() references a function in an exit section.
Often the function ipu_idmac_exit() has valid usage outside the exit section
and the fix is to remove the __exit annotation of ipu_idmac_exit.
Remove the '__exit' annotation from ipu_idmac_exit in order to fix it.
--- drivers/dma/ipu/ipu_idmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/ipu/ipu_idmac.c +1 -1
@@ -1642,7 +1642,7 @@ static int __init ipu_idmac_init(struct ipu *ipu)return dma_async_device_register (&idmac->dma); } -static void __exit ipu_idmac_exit(struct ipu *ipu) +static void ipu_idmac_exit (struct ipu *ipu) {int i;struct idmac *idmac = &ipu->idmac;
Signature · 1 line
1.7.9.5
Quoted 11 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit
84c1e63c12(dma: Remove erroneous__exitand__exit_p()references) the following section mismatch happens:WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function
ipu_remove()to the function .exit.text:ipu_idmac_exit() The functionipu_remove()references a function in an exit section.
Often the functionipu_idmac_exit()has valid usage outside the exit section
and the fix is to remove the__exitannotation ofipu_idmac_exit.Remove the '
__exit' annotation fromipu_idmac_exitin order to fix it.
Good catch...
Quoted 21 lines
Signed-off-by Fabio Estevam <[email protected]>--- drivers/dma/ipu/ipu_idmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dma/ipu/ipu_idmac.c +1
-2@@ -1642,7 +1642,7 @@ static int __init ipu_idmac_init(struct ipu *ipu)return dma_async_device_register (&idmac->dma); } -static void __exit ipu_idmac_exit(struct ipu *ipu) +static void ipu_idmac_exit (struct ipu *ipu) {int i;struct idmac *idmac = &ipu->idmac; --1.7.9.5
Quoted 1 line
--
Warm Regards,
Maxin
Hi Vinod,
Quoted 11 lines · Maxin B. John
Quoted 10 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit
84c1e63c12(dma: Remove erroneous__exitand__exit_p()references) the following section mismatch happens:WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function
ipu_remove()to the function .exit.text:ipu_idmac_exit() The functionipu_remove()references a function in an exit section.
Often the functionipu_idmac_exit()has valid usage outside the exit section
and the fix is to remove the__exitannotation ofipu_idmac_exit.
Quoted 4 lines
Quoted 1 line
Remove the '
__exit' annotation fromipu_idmac_exitin order to fix it.Good catch...
Acked-by Maxin B. John <[email protected]>
Can this one be applied?
Quoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Since commit
84c1e63c12(dma: Remove erroneous__exitand__exit_p()references) the following section mismatch happens:
Quoted 8 lines
WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function
ipu_remove()to the function .exit.text:ipu_idmac_exit() The functionipu_remove()references a function in an exit section.
Often the functionipu_idmac_exit()has valid usage outside the exit section
and the fix is to remove the__exitannotation ofipu_idmac_exit.Remove the '
__exit' annotation fromipu_idmac_exitin order to fix it.Signed-off-by Fabio Estevam <[email protected]>
Applied Thanks
--
~Vinod
Quoted 20 lines
--- drivers/dma/ipu/ipu_idmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/dma/ipu/ipu_idmac.c +1
-1@@ -1642,7 +1642,7 @@ static int __init ipu_idmac_init(struct ipu *ipu)return dma_async_device_register (&idmac->dma); } -static void __exit ipu_idmac_exit(struct ipu *ipu) +static void ipu_idmac_exit (struct ipu *ipu) {int i;struct idmac *idmac = &ipu->idmac;Signature · 1 line
1.7.9.5