runqueue: Use taskData.fn_index[depdata] instead of uninitialized dep
PATCH 1/1 runqueue: Use taskData.fn_index[depdata] instead of uninitialized dep
* dep variable was removed in
commit 3190cb83e2af195a464f669c5aa8aedbf795160e
Author: Richard Purdie <[email protected]>
Date: Wed Jun 27 11:04:06 2012 +0100
taskdata: Add gettask_id_fromfnid helper function
This is like gettask_id but doesn't require translation of fnid -> fn first which the function then translates back. This gives a sizeable performance improvement since a significant number of lookups are avoided.
* now it fails completely instead of showing which task is missing
Signed-off-by Martin Jansa <[email protected]>
--- lib/bb/runqueue.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
lib/bb/runqueue.py +2 -2
@@ -472,7 +472,7 @@ class RunQueueData: if depdata is not None: taskid = taskData.gettask_id_fromfnid(depdata, idependtask) if taskid is None: - bb.msg.fatal("RunQueue", "Task %s in %s depends upon non-existent task %s in %s" % (taskData.tasks_name[task], fn, idependtask, dep)) + bb.msg.fatal("RunQueue", "Task %s in %s depends upon non-existent task %s in %s" % (taskData.tasks_name[task], fn, idependtask, taskData.fn_index[depdata])) depends.add(taskid) irdepends = taskData.tasks_irdepends[task] for (depid, idependtask) in irdepends:
@@ -482,7 +482,7 @@ class RunQueueData: if depdata is not None: taskid = taskData.gettask_id_fromfnid(depdata, idependtask) if taskid is None: - bb.msg.fatal("RunQueue", "Task %s in %s rdepends upon non-existent task %s in %s" % (taskData.tasks_name[task], fn, idependtask, dep)) + bb.msg.fatal("RunQueue", "Task %s in %s rdepends upon non-existent task %s in %s" % (taskData.tasks_name[task], fn, idependtask, taskData.fn_index[depdata])) depends.add(taskid) # Resolve recursive 'recrdeptask' dependencies (Part A)
Signature · 1 line
1.8.1.5