net: fec: fix missing napi_disable call
Subsystems (2)
PATCH 1/1 net: fec: fix missing napi_disable call
Commit dc975382d2ef36be7e78fac3717927de1a5abcd8 introduces napi support but never calls napi_disable. This will generate a kernel oops (kernel BUG at include/linux/netdevice.h:473!) every time, when ndo_stop is called followed by ndo_start.
Add the missing napi_diable call.
Signed-off-by Georg Hofmann <[email protected]>
---
Tested with a imx28-evk board.
drivers/net/ethernet/freescale/fec.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/freescale/fec.c +1 -0
@@ -1437,6 +1437,7 @@ fec_enet_close(struct net_device *ndev)struct fec_enet_private *fep =netdev_priv (ndev);/* Don't know what to do yet. */ +napi_disable (&fep->napi); fep->opened =0 ;netif_stop_queue (ndev);fec_stop (ndev);
From: Georg Hofmann <[email protected]>
Date: Thu, 14 Mar 2013 17:54:09 +0100
Quoted 7 lines
Commit
dc975382d2ef36be7e78fac3717927de1a5abcd8introduces napi support but never callsnapi_disable. This will generate a kernel oops (kernel BUG atinclude/linux/netdevice.h:473!) every time, whenndo_stopis called followed byndo_start.
Add the missingnapi_diablecall.Signed-off-by Georg Hofmann <[email protected]>
Applied.