Added lcms2 package
PATCH 1/1 Added lcms2 package
Little CMS intends to be an OPEN SOURCE small-footprint color management engine, with special focus on accuracy and performance.
--- package/Config.in | 1 + package/lcms2/Config.in | 12 ++++++++++++ package/lcms2/lcms2.mk | 23 +++++++++++++++++++++++ 3 files changed, 36 insertions(+) create mode 100644 package/lcms2/Config.in create mode 100644 package/lcms2/lcms2.mk
package/Config.in +1 -0
@@ -421,6 +421,7 @@ source "package/gtk2-engines/Config.in" source "package/gtk2-themes/Config.in" source "package/imlib2/Config.in" source "package/jpeg/Config.in" +source "package/lcms2/Config.in" source "package/libart/Config.in" source "package/libdmtx/Config.in" source "package/libdrm/Config.in"
package/lcms2/Config.in new file +12 -0
@@ -0,0 +1,12 @@ +config BR2_PACKAGE_LCMS2 + bool "lcms2" + help + Little Color Management Software + Little CMS intends to be an OPEN SOURCE small-footprint color + management engine, with special focus on accuracy and performance. + It uses the International Color Consortium standard (ICC), which is + the modern standard when regarding to color management. + + http://www.littlecms.com/ + +
package/lcms2/lcms2.mk new file +23 -0
@@ -0,0 +1,23 @@ +############################################################# +# +# lcms2-2.4.tar.gz +# +############################################################# +LCMS2_VERSION = 2.4 +LCMS2_SITE = http://prdownloads.sourceforge.net/LCMS2/LCMS2/ +LCMS2_SOURCE = lcms2-$(LCMS2_VERSION).tar.gz +LCMS2_INSTALL_STAGING = YES +LCMS2_LIBTOOL_PATCH = YES +LCMS2_AUTORECONF = NO +LCMS2_CONF_OPT = + +ifeq ($(BR2_PREFER_STATIC_LIB),y) + LCMS2_CONF_OPT += --disable-shared +else + LCMS2_CONF_OPT += --enable-shared +endif + +LCMS2_DEPENDENCIES = host-lcms2 + +$(eval $(autotools-package)) +$(eval $(host-autotools-package))
Signature · 1 line
1.7.10.4
PATCH 1/1 Added lcms2 package
Dear Olivier Schonken,
Thanks for your contribution! A few comments below.
Quoted 1 line · Olivier Schonken
Little CMS intends to be an OPEN SOURCE small-footprint color management engine, with special focus on accuracy and performance.
This should be wrapped at ~80 columns.
package/lcms2/lcms2.mk line 3
Quoted 9 lines
package/lcms2/lcms2.mk new file +3
-0@@ -0,0 +1,23 @@ +############################################################# +# +# lcms2-2.4.tar.gz
Should be just "lcms2"
package/lcms2/lcms2.mk line 6
Quoted 3 lines
package/lcms2/lcms2.mk new file +3
-0+# +############################################################# +LCMS2_VERSION = 2.4
One line between the comment header and the first variable line.
package/lcms2/lcms2.mk line 7
Quoted 1 line
package/lcms2/lcms2.mk new file +1
-0+LCMS2_SITE = http://prdownloads.sourceforge.net/LCMS2/LCMS2/
This should use http://downloads.sourceforge.net instead, see other packages. downloads.sourceforge.net automatically redirects to a working SourceForge mirror.
package/lcms2/lcms2.mk line 8
Quoted 1 line
package/lcms2/lcms2.mk new file +1
-0+LCMS2_SOURCE = lcms2-$(LCMS2_VERSION).tar.gz
This is not needed, that's the default.
package/lcms2/lcms2.mk line 10
Quoted 2 lines
package/lcms2/lcms2.mk new file +2
-0+LCMS2_INSTALL_STAGING = YES +LCMS2_LIBTOOL_PATCH = YES
This is not needed, that's the default (for LIBTOOL_PATCH).
package/lcms2/lcms2.mk line 11
Quoted 1 line
package/lcms2/lcms2.mk new file +1
-0+LCMS2_AUTORECONF = NO
This is not needed, that's the default.
package/lcms2/lcms2.mk line 12
Quoted 1 line
package/lcms2/lcms2.mk new file +1
-0+LCMS2_CONF_OPT =
Not needed.
package/lcms2/lcms2.mk line 18
Quoted 6 lines
package/lcms2/lcms2.mk new file +6
-0+ +ifeq ($(BR2_PREFER_STATIC_LIB),y) + LCMS2_CONF_OPT += --disable-shared +else + LCMS2_CONF_OPT += --enable-shared +endif
Not needed, that's already done by the common autotools infrastructure, see:
http://git.buildroot.net/buildroot/tree/package/pkg-autotools.mk#n112,
where SHARED_STATIC_LIBS_OPTS is defined at
http://git.buildroot.net/buildroot/tree/package/Makefile.in#n321.
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH v2 1/1 Added lcms2 package
Little CMS intends to be an OPEN SOURCE small-footprint color management engine, with special focus on accuracy and performance.
--- package/Config.in | 1 + package/lcms2/Config.in | 12 ++++++++++++ package/lcms2/lcms2.mk | 13 +++++++++++++ 3 files changed, 26 insertions(+) create mode 100644 package/lcms2/Config.in create mode 100644 package/lcms2/lcms2.mk
package/Config.in +1 -0
@@ -421,6 +421,7 @@ source "package/gtk2-engines/Config.in" source "package/gtk2-themes/Config.in" source "package/imlib2/Config.in" source "package/jpeg/Config.in" +source "package/lcms2/Config.in" source "package/libart/Config.in" source "package/libdmtx/Config.in" source "package/libdrm/Config.in"
package/lcms2/Config.in new file +12 -0
@@ -0,0 +1,12 @@ +config BR2_PACKAGE_LCMS2 + bool "lcms2" + help + Little Color Management Software + Little CMS intends to be an OPEN SOURCE small-footprint color + management engine, with special focus on accuracy and performance. + It uses the International Color Consortium standard (ICC), which is + the modern standard when regarding to color management. + + http://www.littlecms.com/ + +
package/lcms2/lcms2.mk new file +13 -0
@@ -0,0 +1,13 @@ +############################################################# +# +# lcms2 +# +############################################################# + +LCMS2_VERSION = 2.4 +LCMS2_SITE = http://downloads.sourceforge.net/LCMS2/LCMS2/ + +LCMS2_DEPENDENCIES = host-lcms2 + +$(eval $(autotools-package)) +$(eval $(host-autotools-package))
Signature · 1 line
1.7.10.4
PATCH v2 1/1 Added lcms2 package
Dear Olivier Schonken,
Quoted 4 lines · Olivier Schonken
Little CMS intends to be an OPEN SOURCE small-footprint color management engine, with special focus on accuracy and performance.
Signed-off-by Olivier Schonken <[email protected]>
(visual inspection only).
I have only one very minor nit, that I think doesn't prevent the patch from being applied.
Quoted 8 lines
package/lcms2/Config.in new file +2
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_LCMS2 + bool "lcms2"
package/lcms2/Config.in line 12
Quoted 10 lines
package/lcms2/Config.in new file +10
-0+ help + Little Color Management Software + Little CMS intends to be an OPEN SOURCE small-footprint color + management engine, with special focus on accuracy and performance. + It uses the International Color Consortium standard (ICC), which is + the modern standard when regarding to color management. + + http://www.littlecms.com/ + +
One two many empty newline.
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH v3 1/1 Added lcms2 package
In reply to Olivier SchonkenLittle CMS intends to be an OPEN SOURCE small-footprint color management engine, with special focus on accuracy and performance.
---
Changelog:
Removed excess empty lines from Config.in
Added licensing info to lcms2.mk
package/Config.in | 1 + package/lcms2/Config.in | 11 +++++++++++ package/lcms2/lcms2.mk | 14 ++++++++++++++ 3 files changed, 26 insertions(+) create mode 100644 package/lcms2/Config.in create mode 100644 package/lcms2/lcms2.mk
package/Config.in +1 -0
@@ -421,6 +421,7 @@ source "package/gtk2-engines/Config.in" source "package/gtk2-themes/Config.in" source "package/imlib2/Config.in" source "package/jpeg/Config.in" +source "package/lcms2/Config.in" source "package/libart/Config.in" source "package/libdmtx/Config.in" source "package/libdrm/Config.in"
package/lcms2/Config.in new file +11 -0
@@ -0,0 +1,11 @@ +config BR2_PACKAGE_LCMS2 + bool "lcms2" + help + Little Color Management Software + Little CMS intends to be an OPEN SOURCE small-footprint color + management engine, with special focus on accuracy and performance. + It uses the International Color Consortium standard (ICC), which is + the modern standard when regarding to color management. + + http://www.littlecms.com/ +
package/lcms2/lcms2.mk new file +14 -0
@@ -0,0 +1,14 @@ +############################################################# +# +# lcms2 +# +############################################################# + +LCMS2_VERSION = 2.4 +LCMS2_SITE = http://downloads.sourceforge.net/LCMS2/LCMS2/ +LCMS2_LICENSE = MIT +LCMS2_LICENSE_FILES = COPYING +LCMS2_DEPENDENCIES = host-lcms2 + +$(eval $(autotools-package)) +$(eval $(host-autotools-package))
Signature · 1 line
1.7.10.4
PATCH 1/1 Added lcms2 package
In reply to Olivier SchonkenLittle CMS intends to be an OPEN SOURCE small-footprint color management engine, with special focus on accuracy and performance.
---
Changelog:
Removed excess empty lines from Config.in Added licensing info to lcms2.mk
Chaned LCMS2_SITE to correct url
Added options to include support for zlib, jpeg and tiff Removed dependency on host-lcms2
package/Config.in | 1 + package/lcms2/Config.in | 11 +++++++++++ package/lcms2/lcms2.mk | 35 +++++++++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+) create mode 100644 package/lcms2/Config.in create mode 100644 package/lcms2/lcms2.mk
package/Config.in +1 -0
@@ -421,6 +421,7 @@ source "package/gtk2-engines/Config.in" source "package/gtk2-themes/Config.in" source "package/imlib2/Config.in" source "package/jpeg/Config.in" +source "package/lcms2/Config.in" source "package/libart/Config.in" source "package/libdmtx/Config.in" source "package/libdrm/Config.in"
package/lcms2/Config.in new file +11 -0
@@ -0,0 +1,11 @@ +config BR2_PACKAGE_LCMS2 + bool "lcms2" + help + Little Color Management Software + Little CMS intends to be an OPEN SOURCE small-footprint color + management engine, with special focus on accuracy and performance. + It uses the International Color Consortium standard (ICC), which is + the modern standard when regarding to color management. + + http://www.littlecms.com/ +
package/lcms2/lcms2.mk new file +35 -0
@@ -0,0 +1,35 @@ +############################################################# +# +# lcms2 +# +############################################################# + +LCMS2_VERSION = 2.4 +LCMS2_SITE = http://downloads.sourceforge.net/lcms/lcms +LCMS2_LICENSE = MIT +LCMS2_LICENSE_FILES = COPYING + +LCMS2_CONF_OPT = \ + +ifeq ($(BR2_PACKAGE_JPEG),y) + LCMS2_CONF_OPT += --with-jpeg + LCMS2_DEPENDENCIES += jpeg +else + LCMS2_CONF_OPT += --without-jpeg +endif + +ifeq ($(BR2_PACKAGE_TIFF),y) + LCMS2_CONF_OPT += --with-tiff + LCMS2_DEPENDENCIES += tiff +else + LCMS2_CONF_OPT += --without-tiff +endif + +ifeq ($(BR2_PACKAGE_ZLIB),y) + LCMS2_CONF_OPT += --with-zlib + LCMS2_DEPENDENCIES += zlib +else + LCMS2_CONF_OPT += --without-zlib +endif + +$(eval $(autotools-package))
Signature · 1 line
1.7.10.4
PATCH 1/1 Added lcms2 package
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Olivier" == Olivier Schonken <[email protected]> writes:
Olivier> Little CMS intends to be an OPEN SOURCE small-footprint color management engine, Olivier> with special focus on accuracy and performance.
Olivier> Signed-off-by: Olivier Schonken <[email protected]> Olivier> ---
Olivier> Changelog:
Olivier> Removed excess empty lines from Config.in
Olivier> Added licensing info to lcms2.mk
Olivier> Chaned LCMS2_SITE to correct url
Olivier> Added options to include support for zlib, jpeg and tiff
Olivier> Removed dependency on host-lcms2
Olivier> package/Config.in | 1 + Olivier> package/lcms2/Config.in | 11 +++++++++++ Olivier> package/lcms2/lcms2.mk | 35 +++++++++++++++++++++++++++++++++++ Olivier> 3 files changed, 47 insertions(+) Olivier> create mode 100644 package/lcms2/Config.in Olivier> create mode 100644 package/lcms2/lcms2.mk
Olivier> diff --git a/package/Config.in b/package/Config.in Olivier> index 21c3ec9..4cf71d6 100644
Olivier> --- a/package/Config.in
Olivier> +++ b/package/Config.in
Olivier> @@ -421,6 +421,7 @@ source "package/gtk2-engines/Config.in"
Olivier> source "package/gtk2-themes/Config.in" Olivier> source "package/imlib2/Config.in" Olivier> source "package/jpeg/Config.in" Olivier> +source "package/lcms2/Config.in" Olivier> source "package/libart/Config.in" Olivier> source "package/libdmtx/Config.in" Olivier> source "package/libdrm/Config.in" Olivier> diff --git a/package/lcms2/Config.in b/package/lcms2/Config.in Olivier> new file mode 100644 Olivier> index 0000000..33999fa Olivier> --- /dev/null Olivier> +++ b/package/lcms2/Config.in Olivier> @@ -0,0 +1,11 @@ Olivier> +config BR2_PACKAGE_LCMS2 Olivier> + bool "lcms2" Olivier> + help Olivier> + Little Color Management Software Olivier> + Little CMS intends to be an OPEN SOURCE small-footprint color Olivier> + management engine, with special focus on accuracy and performance. Olivier> + It uses the International Color Consortium standard (ICC), which is Olivier> + the modern standard when regarding to color management.
Olivier> +
Olivier> + http://www.littlecms.com/
Olivier> +
You have trailing spaces and an empty line at the end.
Olivier> diff --git a/package/lcms2/lcms2.mk b/package/lcms2/lcms2.mk Olivier> new file mode 100644
Olivier> index 0000000..1766bec
Olivier> --- /dev/null
Olivier> +++ b/package/lcms2/lcms2.mk
Olivier> @@ -0,0 +1,35 @@
Olivier> +############################################################# Olivier> +#
Olivier> +# lcms2
Olivier> +#
Olivier> +############################################################# Olivier> +
Olivier> +LCMS2_VERSION = 2.4
Olivier> +LCMS2_SITE = http://downloads.sourceforge.net/lcms/lcms
Olivier> +LCMS2_LICENSE = MIT
Olivier> +LCMS2_LICENSE_FILES = COPYING
Olivier> +
Olivier> +LCMS2_CONF_OPT = \
Olivier> +
Olivier> +ifeq ($(BR2_PACKAGE_JPEG),y)
Olivier> + LCMS2_CONF_OPT += --with-jpeg
Olivier> + LCMS2_DEPENDENCIES += jpeg
And the same here (multiple places).
Committed with those fixed, thanks.
Signature · 1 line
Bye, Peter Korsgaard