Skip to contentSkip to conversation

MIPS: Init new mmu_context for each possible CPU to avoid memory corruption

PATCH In review Huacai Chen 3 participants 3 messages Mar 17, 2013 – Mar 20, 2013 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/2 MIPS: Init new mmu_context for each possible CPU to avoid memory corruption

Currently, init_new_context() only for each online CPU, this may cause memory corruption when CPU hotplug and fork() happens at the same time. To avoid this, we make init_new_context() cover each possible CPU.

Scenario:
1, CPU#1 is being offline;
2, On CPU#0, do_fork() call dup_mm() and copy a mm_struct to the child; 3, On CPU#0, dup_mm() call init_new_context(), since CPU#1 is offline
and init_new_context() only covers the online CPUs, child has the same asid as its parent on CPU#1 (however, child's asid should be 0);
4, CPU#1 is being online;
5, Now, if both parent and child run on CPU#1, memory corruption (e.g.
segfault, bus error, etc.) will occur.

---
 arch/mips/include/asm/mmu_context.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/mips/include/asm/mmu_context.h +1 -1
index e81d719..49d220c 100644
@@ -133,7 +133,7 @@ init_new_context(struct task_struct *tsk, struct mm_struct *mm)
 {
 	int i;
 
-	for_each_online_cpu(i)
+	for_each_possible_cpu(i)
 		cpu_context(i, mm) = 0;
 
 	return 0;
Signature · 1 line
1.7.7.3
#1 lore raw

2013/3/17 Huacai Chen <[email protected]>:

Quoted 4 lines

Currently, init_new_context() only for each online CPU, this may cause memory corruption when CPU hotplug and fork() happens at the same time. To avoid this, we make init_new_context() cover each possible CPU.

Quoted 9 lines

Scenario:
1, CPU#1 is being offline;
2, On CPU#0, do_fork() call dup_mm() and copy a mm_struct to the child; 3, On CPU#0, dup_mm() call init_new_context(), since CPU#1 is offline
and init_new_context() only covers the online CPUs, child has the same asid as its parent on CPU#1 (however, child's asid should be 0);
4, CPU#1 is being online;
5, Now, if both parent and child run on CPU#1, memory corruption (e.g.
segfault, bus error, etc.) will occur.

Adds some further explanations about point 5:
5.1) The parent process runs on CPU#1, the version field of its asid[CPU#1] and CPU#1's asid cache may match, thus the parent process's asid[CPU#1] is used in TLB refilling routine.

5.2) Then the child process runs on CPU#1 which probably has the same asid[CPU#1] as its parent(as pointed by point 3).

5.3) The child process may access address space of its parent.

It can also be solved by increasing version field of asid cache when plugin a CPU, may be a better way?

Regards,
-- Chen Jie

Acked-by on v2 2/2
#2 lore raw
In reply to Huacai Chen
Quoted 14 lines · Huacai Chen

Currently, init_new_context() only for each online CPU, this may cause memory corruption when CPU hotplug and fork() happens at the same time. To avoid this, we make init_new_context() cover each possible CPU.

Scenario:
1, CPU#1 is being offline;
2, On CPU#0, do_fork() call dup_mm() and copy a mm_struct to the child; 3, On CPU#0, dup_mm() call init_new_context(), since CPU#1 is offline
and init_new_context() only covers the online CPUs, child has the same asid as its parent on CPU#1 (however, child's asid should be 0);
4, CPU#1 is being online;
5, Now, if both parent and child run on CPU#1, memory corruption (e.g.
segfault, bus error, etc.) will occur.

Quoted 1 line

We were seeing the same crashes, this patch set seems to fix the problem.

Quoted 18 lines
---
  arch/mips/include/asm/mmu_context.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
arch/mips/include/asm/mmu_context.h +1 -1
index e81d719..49d220c 100644
@@ -133,7 +133,7 @@ init_new_context(struct task_struct *tsk, struct mm_struct *mm)
  {
  	int i;
 
-	for_each_online_cpu(i)
+	for_each_possible_cpu(i)
  		cpu_context(i, mm) = 0;
 
  	return 0;