perf: Reset hwc->last_period on sw clock events
Namhyung Kim
maintainerPATCH 1/2 perf: Reset hwc->last_period on sw clock events
From: Namhyung Kim <[email protected]>
When cpu/task clock events are initialized, their sampling frequencies are converted to have a fixed value. However it missed to update the hwc->last_period which was set to 1 for initial sampling frequency calibration.
Because this hwc->last_period value is used as a period in perf_swevent_ hrtime(), every recorded sample will have an incorrected period of 1.
$ perf record -e task-clock noploop 1 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.158 MB perf.data (~6919 samples) ]
$ perf report -n --show-total-period --stdio
# Samples: 4K of event 'task-clock'
# Event count (approx.): 4000
#
# Overhead Samples Period Command Shared Object Symbol
# ........ ............ ............ ....... ............. ..................
#
99.95% 3998 3998 noploop noploop [.] main
0.03% 1 1 noploop libc-2.15.so [.] init_cacheinfo
0.03% 1 1 noploop ld-2.15.so [.] open_verifyNote that it doesn't affect the non-sampling event so that the perf stat still gets correct value with or without this patch.
$ perf stat -e task-clock noploop 1
Performance counter stats for 'noploop 1':
1000.272525 task-clock # 1.000 CPUs utilized
1.000560605 seconds time elapsed--- kernel/events/core.c | 1 + 1 file changed, 1 insertion(+)
kernel/events/core.c +1 -0
@@ -5659,6 +5659,7 @@ static void perf_swevent_init_hrtimer(struct perf_event *event) event->attr.sample_period =NSEC_PER_SEC / freq; hwc->sample_period = event->attr.sample_period;local64_set (&hwc->period_left, hwc->sample_period); + hwc->last_period = hwc->sample_period; event->attr.freq =0 ; } }
Signature · 1 line
1.7.11.7
Namhyung Kim
maintainerPATCH 2/2 perf tests: Add a test case for checking sw clock event frequency
From: Namhyung Kim <[email protected]>
This test case checks frequency conversion of hrtimer-based software clock events (cpu-clock, task-clock) have valid (non-1) periods.
--- tools/perf/Makefile | 1 + tools/perf/tests/builtin-test.c | 4 ++ tools/perf/tests/sw-clock.c | 118 ++++++++++++++++++++++++++++++++++++++++ tools/perf/tests/tests.h | 1 + 4 files changed, 124 insertions(+) create mode 100644 tools/perf/tests/sw-clock.c
tools/perf/Makefile +1 -0
@@ -514,6 +514,7 @@ LIB_OBJS += $(OUTPUT)tests/python-use.o LIB_OBJS += $(OUTPUT)tests/bp_signal.o LIB_OBJS += $(OUTPUT)tests/bp_signal_overflow.o LIB_OBJS += $(OUTPUT)tests/task-exit.o +LIB_OBJS += $(OUTPUT)tests/sw-clock.o BUILTIN_OBJS += $(OUTPUT)builtin-annotate.o BUILTIN_OBJS += $(OUTPUT)builtin-bench.o
tools/perf/tests/builtin-test.c +4 -0
@@ -90,6 +90,10 @@ static struct test { .func = test__task_exit, }, { + .desc = "Test software clock events have valid period values", + .func = test__sw_clock_freq, + }, + { .func = NULL, }, };
tools/perf/tests/sw-clock.c new file +118 -0
118 lines not on this page · raw message
tools/perf/tests/tests.h +1 -0
@@ -26,5 +26,6 @@ int test__python_use(void);int test__bp_signal (void );int test__bp_signal_overflow (void );int test__task_exit (void ); +int test__sw_clock_freq (void );#endif /* TESTS_H */
Signature · 1 line
1.7.11.7
Re: [PATCH 2/2] perf tests: Add a test case for checking sw clock event frequency
Em Mon, Mar 18, 2013 at 11:41:47AM +0900, Namhyung Kim escreveu:
Quoted 8 lines
tools/perf/tests/sw-clock.c new file +8
-0+static int __test__sw_clock_freq (enum perf_sw_ids clock_id) +{ +int i, err =-1 ; +volatile int tmp =0 ; +u64 total_periods =0 ; +int nr_samples =0 ; +union perf_event *event; +struct perf_evsel *evsel;
tools/perf/tests/sw-clock.c line 36
Quoted 10 lines
tools/perf/tests/sw-clock.c new file +10
-0+struct perf_evlist *evlist; +struct perf_event_attr attr = { + .type =PERF_TYPE_SOFTWARE , + .config = clock_id, + .sample_type =PERF_SAMPLE_PERIOD , + .exclude_kernel =1 , + .disabled =1 , + .freq =1 , + .sample_freq =10000 , + };
In some compilers we get:
tests/sw-clock.c: In function ‘__test__sw_clock_freq’:tests/sw-clock.c:35: error: unknown field ‘sample_freq’ specified in initializer
So I'm moving the initialization to outside the struct named initialization block, i.e.:
@@ -32,9 +32,10 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id)
.exclude_kernel = 1,
.disabled = 1,
.freq = 1,
- .sample_freq = 10000,
};+ attr.sample_freq = 10000;
+
- Arnaldo
Namhyung Kim
maintainerRe: [PATCH 2/2] perf tests: Add a test case for checking sw clock event frequency
Hi Arnaldo,
Quoted 28 lines · Arnaldo Carvalho de Melo
Em Mon, Mar 18, 2013 at 11:41:47AM +0900, Namhyung Kim escreveu:
Quoted 8 lines
tools/perf/tests/sw-clock.c new file +8
-0+static int __test__sw_clock_freq (enum perf_sw_ids clock_id) +{ +int i, err =-1 ; +volatile int tmp =0 ; +u64 total_periods =0 ; +int nr_samples =0 ; +union perf_event *event; +struct perf_evsel *evsel;tools/perf/tests/sw-clock.c line 36
Quoted 10 lines
tools/perf/tests/sw-clock.c new file +10
-0+struct perf_evlist *evlist; +struct perf_event_attr attr = { + .type =PERF_TYPE_SOFTWARE , + .config = clock_id, + .sample_type =PERF_SAMPLE_PERIOD , + .exclude_kernel =1 , + .disabled =1 , + .freq =1 , + .sample_freq =10000 , + };In some compilers we get:
tests/sw-clock.c: In function ‘__test__sw_clock_freq’:tests/sw-clock.c:35: error: unknown field ‘sample_freq’ specified in initializerSo I'm moving the initialization to outside the struct named initialization block, i.e.:
Review static int __test__sw_clock_freq(enum perf_sw_ids clock_id) · line 39
Quoted 9 lines
(quoted diff) +2
-1@@ -32,9 +32,10 @@ static int __test__sw_clock_freq(enum perf_sw_ids clock_id) .exclude_kernel = 1, .disabled = 1, .freq = 1, - .sample_freq = 10000, }; + attr.sample_freq = 10000; +
Thanks for fixing this!
Namhyung
tip-bot for Namhyung Kim
merge bot[tip:perf/core] perf tests: Add a test case for checking sw clock event frequency
In reply to Namhyung Kimperf tests: Add a test case for checking sw clock event frequency
Commit-ID: bc96b361cbf90e61d2665b1305cd2c4ac1fd9cfc Gitweb: http://git.kernel.org/tip/bc96b361cbf90e61d2665b1305cd2c4ac1fd9cfc Author: Namhyung Kim <[email protected]> AuthorDate: Mon, 18 Mar 2013 11:41:47 +0900 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Mon, 18 Mar 2013 11:43:16 -0300
perf tests: Add a test case for checking sw clock event frequency
This test case checks frequency conversion of hrtimer-based software clock events (cpu-clock, task-clock) have valid (non-1) periods.
--- tools/perf/Makefile | 1 + tools/perf/tests/builtin-test.c | 4 ++ tools/perf/tests/sw-clock.c | 119 ++++++++++++++++++++++++++++++++++++++++ tools/perf/tests/tests.h | 1 + 4 files changed, 125 insertions(+)
tools/perf/Makefile +1 -0
@@ -514,6 +514,7 @@ LIB_OBJS += $(OUTPUT)tests/python-use.o LIB_OBJS += $(OUTPUT)tests/bp_signal.o LIB_OBJS += $(OUTPUT)tests/bp_signal_overflow.o LIB_OBJS += $(OUTPUT)tests/task-exit.o +LIB_OBJS += $(OUTPUT)tests/sw-clock.o BUILTIN_OBJS += $(OUTPUT)builtin-annotate.o BUILTIN_OBJS += $(OUTPUT)builtin-bench.o
tools/perf/tests/builtin-test.c +4 -0
@@ -90,6 +90,10 @@ static struct test { .func = test__task_exit, }, { + .desc = "Test software clock events have valid period values", + .func = test__sw_clock_freq, + }, + { .func = NULL, }, };
tools/perf/tests/sw-clock.c new file +119 -0
119 lines not on this page · raw message
tools/perf/tests/tests.h +1 -0
@@ -26,5 +26,6 @@ int test__python_use(void);int test__bp_signal (void );int test__bp_signal_overflow (void );int test__task_exit (void ); +int test__sw_clock_freq (void );#endif /* TESTS_H */
tip-bot for Namhyung Kim
merge botperf: Reset hwc->last_period on sw clock events
Commit-ID: 778141e3cf0bf29f91cd3cb5c314ea477b9402a7 Gitweb: http://git.kernel.org/tip/778141e3cf0bf29f91cd3cb5c314ea477b9402a7 Author: Namhyung Kim <[email protected]> AuthorDate: Mon, 18 Mar 2013 11:41:46 +0900 Committer: Ingo Molnar <[email protected]> CommitDate: Mon, 18 Mar 2013 09:15:18 +0100
perf: Reset hwc->last_period on sw clock events
When cpu/task clock events are initialized, their sampling frequencies are converted to have a fixed value. However it missed to update the hwc->last_period which was set to 1 for initial sampling frequency calibration.
Because this hwc->last_period value is used as a period in perf_swevent_ hrtime(), every recorded sample will have an incorrected period of 1.
$ perf record -e task-clock noploop 1 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.158 MB perf.data (~6919 samples) ]
$ perf report -n --show-total-period --stdio
# Samples: 4K of event 'task-clock'
# Event count (approx.): 4000
#
# Overhead Samples Period Command Shared Object Symbol
# ........ ............ ............ ....... ............. ..................
#
99.95% 3998 3998 noploop noploop [.] main
0.03% 1 1 noploop libc-2.15.so [.] init_cacheinfo
0.03% 1 1 noploop ld-2.15.so [.] open_verifyNote that it doesn't affect the non-sampling event so that the perf stat still gets correct value with or without this patch.
$ perf stat -e task-clock noploop 1
Performance counter stats for 'noploop 1':
1000.272525 task-clock # 1.000 CPUs utilized
1.000560605 seconds time elapsed--- kernel/events/core.c | 1 + 1 file changed, 1 insertion(+)
kernel/events/core.c +1 -0
@@ -5647,6 +5647,7 @@ static void perf_swevent_init_hrtimer(struct perf_event *event) event->attr.sample_period =NSEC_PER_SEC / freq; hwc->sample_period = event->attr.sample_period;local64_set (&hwc->period_left, hwc->sample_period); + hwc->last_period = hwc->sample_period; event->attr.freq =0 ; } }