Skip to contentSkip to conversation

perf cgroup: Add __percpu annotation to perf_cgroup->info

PATCH Superseded Namhyung Kim 3 participants 4 messages Mar 18, 2013 perf events

lore
Share & tools
lore

Namhyung Kim

author maintainer
#0 lore raw

PATCH 1/1 perf cgroup: Add __percpu annotation to perf_cgroup->info

From: Namhyung Kim <[email protected]>

It's a per-cpu data structure but missed the __percpu annotation.

---
 include/linux/perf_event.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/perf_event.h +2 -2
index 001a3b64fe61..16116aee9405 100644
@@ -311,8 +311,8 @@ struct perf_cgroup_info {
 };
 
 struct perf_cgroup {
-	struct				cgroup_subsys_state css;
-	struct				perf_cgroup_info *info;	/* timing info, one per cpu */
+	struct cgroup_subsys_state 	css;
+	struct perf_cgroup_info __percpu * info;
 };
 #endif
 
Signature · 1 line
1.7.11.7
#1 lore raw
Quoted 15 lines · Namhyung Kim

From: Namhyung Kim <[email protected]>

It's a per-cpu data structure but missed the __percpu annotation.

---
 include/linux/perf_event.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/perf_event.h +0 -0
index 001a3b64fe61..16116aee9405 100644

include/linux/perf_event.h struct perf_cgroup_info { · line 317

Quoted 9 lines
include/linux/perf_event.h +2 -2
@@ -311,8 +311,8 @@ struct perf_cgroup_info {
 };
 
 struct perf_cgroup {
-	struct				cgroup_subsys_state css;
-	struct				perf_cgroup_info *info;	/* timing info, one per cpu */
+	struct cgroup_subsys_state 	css;
+	struct perf_cgroup_info __percpu * info;
 };
 #endif

Would be nice to have this against tip:master - 'struct perf_cgroup' recently moved to kernel/events/, in the development tree.

Thanks,

Ingo

author maintainer
#2 lore raw

PATCH v2 1/1 perf cgroup: Add __percpu annotation to perf_cgroup->info

From: Namhyung Kim <[email protected]>

It's a per-cpu data structure but missed the __percpu annotation.

---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/events/core.c +1 -1
index 5976a2a6b4ce..efb75b3a69ad 100644
@@ -245,7 +245,7 @@ struct perf_cgroup_info {
 
 struct perf_cgroup {
 	struct cgroup_subsys_state	css;
-	struct perf_cgroup_info		*info;
+	struct perf_cgroup_info	__percpu *info;
 };
 
 /*
Signature · 1 line
1.7.11.7
#3 lore raw

[tip:perf/core] perf/cgroup: Add __percpu annotation to perf_cgroup->info

perf/cgroup: Add __percpu annotation to perf_cgroup->info
Commit-ID:  86e213e1d901fbeaf6e57d13c5edd925fadddcbe
Gitweb:     http://git.kernel.org/tip/86e213e1d901fbeaf6e57d13c5edd925fadddcbe
Author:     Namhyung Kim <[email protected]>
AuthorDate: Mon, 18 Mar 2013 18:56:34 +0900
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 18 Mar 2013 11:02:06 +0100

perf/cgroup: Add __percpu annotation to perf_cgroup->info

It's a per-cpu data structure but missed the __percpu annotation.

---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/events/core.c +1 -1
index 5976a2a..efb75b3 100644
@@ -245,7 +245,7 @@ struct perf_cgroup_info {
 
 struct perf_cgroup {
 	struct cgroup_subsys_state	css;
-	struct perf_cgroup_info		*info;
+	struct perf_cgroup_info	__percpu *info;
 };
 
 /*