Skip to contentSkip to conversation

mfd: da9055 change irq state to default

PATCH Applied Ashish Jangam 2 participants 3 messages Mar 18, 2013 – Apr 9, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: da9055 change irq state to default

This patch changes the irq state from high to the now default low. Because the default PMIC irq state of DA9055 got changed from high to low. This change should not affect any of the existing users since all of them use active low state.

This patch has been tested on smdkv6410.

---
 drivers/mfd/da9055-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/da9055-core.c +1 -1
index f56a1a9..49cb23d 100644
@@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
 		da9055->irq_base = pdata->irq_base;
 
 	ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
-				  IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+				  IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 				  da9055->irq_base, &da9055_regmap_irq_chip,
 				  &da9055->irq_data);
 	if (ret < 0)
Signature · 1 line
1.7.1
#1 lore raw
Quoted 18 lines · Ashish Jangam

This patch changes the irq state from high to the now default low. Because the default PMIC irq state of DA9055 got changed from high to low. This change should not affect any of the existing users since all of them use active low state.

This patch has been tested on smdkv6410.

---
 drivers/mfd/da9055-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/da9055-core.c +0 -0
index f56a1a9..49cb23d 100644

drivers/mfd/da9055-core.c int da9055_device_init(struct da9055 *da9055) · line 397

Quoted 8 lines
drivers/mfd/da9055-core.c +1 -1
@@ -391,7 +391,7 @@ int da9055_device_init(struct da9055 *da9055)
 		da9055->irq_base = pdata->irq_base;
 
 	ret = regmap_add_irq_chip(da9055->regmap, da9055->chip_irq,
-				  IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+				  IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 				  da9055->irq_base, &da9055_regmap_irq_chip,
 				  &da9055->irq_data);
 	if (ret < 0)

If there are no comments then can this patch get merged.

Applied
#2 lore raw
In reply to Ashish Jangam

Hi Ashish,

Quoted 5 lines · Ashish Jangam

This patch changes the irq state from high to the now default low. Because the default PMIC irq state of DA9055 got changed from high to low. This change should not affect any of the existing users since all of them use active low state.

Quoted 7 lines

This patch has been tested on smdkv6410.

---
 drivers/mfd/da9055-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Applied, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/