nfsd: only unhash DRC entries that are in the hashtable
Subsystems (2)
PATCH 1/1 nfsd: only unhash DRC entries that are in the hashtable
It's not safe to call hlist_del() on a newly initialized hlist_node. That leads to a NULL pointer dereference. Only do that if the entry is hashed.
Signed-off-by Jeff Layton <[email protected]>
--- fs/nfsd/nfscache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/nfsd/nfscache.c +2 -1
@@ -102,7 +102,8 @@ nfsd_reply_cache_free_locked(struct svc_cacherep *rp) {if (rp->c_type ==RC_REPLBUFF )kfree (rp->c_replvec.iov_base); -hlist_del (&rp->c_hash); +if (!hlist_unhashed (&rp->c_hash)) +hlist_del (&rp->c_hash);list_del (&rp->c_lru); --num_drc_entries;kmem_cache_free (drc_slab, rp);
Signature · 1 line
1.7.11.7
Quoted 3 lines · Jeff Layton
It's not safe to call
hlist_del()on a newly initializedhlist_node. That leads to a NULL pointer dereference. Only do that if the entry is hashed.
Thanks! Applying for 3.9.--b.
Quoted 23 lines
Signed-off-by Jeff Layton <[email protected]>--- fs/nfsd/nfscache.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)fs/nfsd/nfscache.c +2
-1@@ -102,7 +102,8 @@ nfsd_reply_cache_free_locked(struct svc_cacherep *rp) {if (rp->c_type ==RC_REPLBUFF )kfree (rp->c_replvec.iov_base); -hlist_del (&rp->c_hash); +if (!hlist_unhashed (&rp->c_hash)) +hlist_del (&rp->c_hash);list_del (&rp->c_lru); --num_drc_entries;kmem_cache_free (drc_slab, rp);Signature · 1 line
1.7.11.7