Skip to contentSkip to conversation

h8300, score: fix CROSS_COMPILE setting in arch/xxx/Makefile

PATCH New Jiang Liu 1 participant 1 message Mar 18, 2013

lore
Share & tools
lore

Jiang Liu

author
#0 lore raw

PATCH 1/1 h8300, score: fix CROSS_COMPILE setting in arch/xxx/Makefile

Makefiles for h8300 and score architectures unconditionally set CROSS_COMPILE to a default value, which breaks following cross compilation command:
ARCH=h8300 CROSS_COMPILE=/ws/tool/h8300-elf/bin/h8300-elf- make arch/h8300/mm/init.o
make: h8300-elf-gcc: Command not found
make: h8300-elf-gcc: Command not found

  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
  CC      kernel/bounds.s

/bin/sh: 1: h8300-elf-gcc: not found
make[1]: *** [kernel/bounds.s] Error 127
make: *** [prepare0] Error 2

So only set CROSS_COMPILE to the default value if it's has been set yet.

Also fix a typo in arch/h8300/Makefile to change "CROSS-COMPILE" to "CROSS_COMPILE".

Cc Yoshinori Sato <[email protected]>
Cc Chen Liqin <[email protected]>
Cc Lennox Wu <[email protected]>
---
 arch/h8300/Makefile |    6 ++++--
 arch/score/Makefile |    4 +++-
 2 files changed, 7 insertions(+), 3 deletions(-)
arch/h8300/Makefile +4 -2
index a556447..62a4d08 100644
@@ -38,8 +38,10 @@ KBUILD_CFLAGS += -DUTS_SYSNAME=\"uClinux\"
 KBUILD_AFLAGS += -DPLATFORM=$(PLATFORM) -DMODEL=$(MODEL) $(cflags-y)
 LDFLAGS += $(ldflags-y)
 
-CROSS_COMPILE = h8300-elf-
-LIBGCC := $(shell $(CROSS-COMPILE)$(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
+ifeq ($(CROSS_COMPILE),)
+	CROSS_COMPILE := h8300-elf-
+endif
+LIBGCC := $(shell $(CROSS_COMPILE)$(CC) $(KBUILD_CFLAGS) -print-libgcc-file-name)
 
 head-y := arch/$(ARCH)/platform/$(PLATFORM)/$(BOARD)/crt0_$(MODEL).o
 
arch/score/Makefile +3 -1
index 974aefe..70973bb 100644
@@ -7,7 +7,9 @@
 #
 
 KBUILD_DEFCONFIG := spct6600_defconfig
-CROSS_COMPILE := score-linux-
+ifeq ($(CROSS_COMPILE),)
+	CROSS_COMPILE := score-linux-
+endif
 
 #
 # CPU-dependent compiler/assembler options for optimization.
Signature · 1 line
1.7.9.5