Skip to contentSkip to conversation

layer.conf: avoid unnecessary early expansion with :=

PATCH Applied Christopher Larson 2 participants 2 messages Mar 19, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 layer.conf: avoid unnecessary early expansion with :=

From: Christopher Larson <[email protected]>

bitbake handles immediate expansions of LAYERDIR for us automatically.

---
 conf/layer.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
conf/layer.conf +3 -3
index f4597db..84ab5f7 100644
@@ -1,10 +1,10 @@
 # We have a conf and classes directory, add to BBPATH
-BBPATH := "${BBPATH}:${LAYERDIR}"
+BBPATH .= ":${LAYERDIR}"
 
 # We have a packages directory, add to BBFILES
-BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb"
+BBFILES += "${LAYERDIR}/recipes-*/*/*.bb"
 
 BBFILE_COLLECTIONS += "qt3"
-BBFILE_PATTERN_qt3 := "^${LAYERDIR}/"
+BBFILE_PATTERN_qt3 = "^${LAYERDIR}/"
 BBFILE_PRIORITY_qt3 = "6"
 
Signature · 1 line
1.8.2
#1 lore raw
Quoted 16 lines · On Monday 18 March 2013 19:33:30 Christopher Larson wrote:

From: Christopher Larson <[email protected]>

bitbake handles immediate expansions of LAYERDIR for us automatically.

---
 conf/layer.conf | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
conf/layer.conf +0 -1
index f4597db..84ab5f7 100644
@@ -1,10 +1,10 @@
 # We have a conf and classes directory, add to BBPATH
-BBPATH := "${BBPATH}:${LAYERDIR}"

conf/layer.conf line 9

Quoted 10 lines
conf/layer.conf +3 -2
+BBPATH .= ":${LAYERDIR}"
 
 # We have a packages directory, add to BBFILES
-BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb"
+BBFILES += "${LAYERDIR}/recipes-*/*/*.bb"
 
 BBFILE_COLLECTIONS += "qt3"
-BBFILE_PATTERN_qt3 := "^${LAYERDIR}/"
+BBFILE_PATTERN_qt3 = "^${LAYERDIR}/"
 BBFILE_PRIORITY_qt3 = "6"

Merged, thanks.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre