Skip to contentSkip to conversation

Added package HPLIP for printing to HP printers

PATCH Superseded Olivier Schonken 4 participants 10 messages Mar 2, 2013 – Mar 19, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Added package HPLIP for printing to HP printers

HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed solution for printing, scanning, and faxing with HP inkjet and laser based printers in Linux.

---
 package/cups/Config.in             |    1 +
 package/hplip/Config.in            |   13 ++++++
 package/hplip/hplip-fix-make.patch |   80 ++++++++++++++++++++++++++++++++++++
 package/hplip/hplip.mk             |   52 +++++++++++++++++++++++
 4 files changed, 146 insertions(+)
 create mode 100644 package/hplip/Config.in
 create mode 100644 package/hplip/hplip-fix-make.patch
 create mode 100644 package/hplip/hplip.mk
package/cups/Config.in +1 -0
index dc1c2ed..7b703ff 100644
@@ -18,4 +18,5 @@ config BR2_PACKAGE_CUPS_PDFTOPS
 comment "pdftops support requires a toolchain with C++ support enabled"
 	depends on !BR2_INSTALL_LIBSTDCPP
 
+source "package/hplip/Config.in"
 endif
package/hplip/Config.in new file +13 -0
new file mode 100644
index 0000000..b0d802a
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_HPLIP
+	bool "hplip"
+	select BR2_PACKAGE_LIBUSB
+	help
+	  HP Linux Imaging and Printing (HPLIP)
+	  HPLIP is an HP-developed solution for printing, scanning, and faxing
+	  with HP inkjet and laser based printers in Linux. The HPLIP project 
+	  provides printing support for 2,211 printer models, including 
+	  Deskjet, Officejet, Photosmart, PSC (Print Scan Copy), Business 
+	  Inkjet, LaserJet, Edgeline MFP, and LaserJet MFP. 
+	  
+	  http://hplipopensource.com/
+
package/hplip/hplip-fix-make.patch new file +80 -0

80 lines not on this page · raw message

package/hplip/hplip.mk new file +52 -0

52 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 Added package HPLIP for printing to HP printers

Dear Olivier Schonken,

Quoted 1 line · Olivier Schonken

HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed solution for printing, scanning, and faxing with HP inkjet and laser based printers in Linux.

The commit log should be wrapped at ~80 columns.

package/cups/Config.in config BR2_PACKAGE_CUPS_PDFTOPS · line 22

Quoted 10 lines
package/cups/Config.in +1 -0
index dc1c2ed..7b703ff 100644
@@ -18,4 +18,5 @@ config BR2_PACKAGE_CUPS_PDFTOPS
 comment "pdftops support requires a toolchain with C++ support enabled"
 	depends on !BR2_INSTALL_LIBSTDCPP
 
+source "package/hplip/Config.in"
 endif

No, I think the package should still be included from package/Config.in like all other packages, but maybe it can carry a "depends on BR2_PACKAGE_CUPS" in package/hplip/Config.in. I guess we can assume that the person who wants the HP printer drivers will know that CUPS should be enabled.

Quoted 37 lines
package/hplip/Config.in new file +13 -0
new file mode 100644
index 0000000..b0d802a
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_HPLIP
+	bool "hplip"
+	select BR2_PACKAGE_LIBUSB
+	help
+	  HP Linux Imaging and Printing (HPLIP)
+	  HPLIP is an HP-developed solution for printing, scanning, and faxing
+	  with HP inkjet and laser based printers in Linux. The HPLIP project 
+	  provides printing support for 2,211 printer models, including 
+	  Deskjet, Officejet, Photosmart, PSC (Print Scan Copy), Business 
+	  Inkjet, LaserJet, Edgeline MFP, and LaserJet MFP. 
+	  
+	  http://hplipopensource.com/
+
package/hplip/hplip-fix-make.patch new file +12 -0
new file mode 100644
index 0000000..339e58e
@@ -0,0 +1,80 @@
+From 1e03ca316a3784290b489470b16c34b7f44a0c75 Mon Sep 17 00:00:00 2001
+From: Olivier Schonken <[email protected]>
+Date: Sat, 2 Mar 2013 18:01:03 +0200
+Subject: [PATCH] Changed Makefile.am and Makefile.in to allow
+ cross-compilation of HPLIP
+
+Signed-off-by: Olivier Schonken <[email protected]>
+---
+ Makefile.am |    4 ++--
+ Makefile.in |   16 ++--------------
+ 2 files changed, 4 insertions(+), 16 deletions(-)
+

package/hplip/hplip-fix-make.patch line 22

Quoted 10 lines
package/hplip/hplip-fix-make.patch new file +10 -0
+diff --git a/Makefile.am b/Makefile.am
+index 16ea902..00ec8da 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -72,7 +72,7 @@ libhpmud_la_SOURCES = io/hpmud/hpmud.c io/hpmud/mlc.c io/hpmud/model.c io/hpmud/
+ 	  io/hpmud/hpmud.h io/hpmud/hpmudi.h io/hpmud/list.h io/hpmud/mlc.h io/hpmud/pml.h io/hpmud/dot4.c \
+ 	  io/hpmud/dot4.h io/hpmud/jd.c io/hpmud/jd.h io/hpmud/pp.c io/hpmud/pp.h io/hpmud/musb.h io/hpmud/musb_libusb01.c
+ else
+-libhpmud_la_CFLAGS = -I/usr/include/libusb-1.0 -DMUDNAME=\"$(MUDNAME)\" -DCONFDIR=\"$(hplip_confdir)\"
++libhpmud_la_CFLAGS = -I$(includedir)/usr/include/libusb-1.0 -DMUDNAME=\"$(MUDNAME)\" -DCONFDIR=\"$(hplip_confdir)\"

You should make this -I$(includedir)/libusb-1.0

package/hplip/hplip-fix-make.patch line 31

Quoted 9 lines
package/hplip/hplip-fix-make.patch new file +9 -0
+ libhpmud_la_SOURCES = io/hpmud/hpmud.c io/hpmud/mlc.c io/hpmud/model.c io/hpmud/pml.c \
+ 	  io/hpmud/hpmud.h io/hpmud/hpmudi.h io/hpmud/list.h io/hpmud/mlc.h io/hpmud/pml.h io/hpmud/dot4.c \
+ 	  io/hpmud/dot4.h io/hpmud/jd.c io/hpmud/jd.h io/hpmud/pp.c io/hpmud/pp.h io/hpmud/musb.h io/hpmud/musb.c
+@@ -292,7 +292,7 @@ hpmudext_la_LIBADD = libhpmud.la
+ if LIBUSB01_BUILD
+ hpmudext_la_CFLAGS = -I$(PYTHONINCLUDEDIR)
+ else
+-hpmudext_la_CFLAGS =-I/usr/include/libusb-1.0 -I$(PYTHONINCLUDEDIR)
++hpmudext_la_CFLAGS =-I$(includedir)/usr/include/libusb-1.0 -I$(PYTHONINCLUDEDIR)

Ditto, -I$(includedir)/libusb-1.0

package/hplip/hplip-fix-make.patch line 38

Quoted 7 lines
package/hplip/hplip-fix-make.patch new file +7 -0
+ endif
+ 
+ # ui (qt3)
+diff --git a/Makefile.in b/Makefile.in
+index e8e6142..5d9c331 100644
+--- a/Makefile.in
++++ b/Makefile.in

You are patching both Makefile.am and Makefile.in. Normally, we prefer to patch Makefile.am and do HPLIP_AUTORECONF=YES. Have you tried that? Have you had issues in doing this?

package/hplip/hplip.mk line 5

Quoted 11 lines
package/hplip/hplip.mk new file +5 -0
new file mode 100644
index 0000000..03fb514
@@ -0,0 +1,52 @@
+#############################################################
+#
+# hplip
+#
+#############################################################

One blank line between header and first variable.

package/hplip/hplip.mk line 7

Quoted 2 lines
package/hplip/hplip.mk new file +2 -0
+HPLIP_VERSION = 3.12.11
+HPLIP_SITE = http://prdownloads.sourceforge.net/hplip/hplip/

Please use http://downloads.sourceforge.net instead (see other packages).

package/hplip/hplip.mk line 8

Quoted 1 line
package/hplip/hplip.mk new file +1 -0
+HPLIP_SOURCE = hplip-$(HPLIP_VERSION).tar.gz

Not needed, that's the default.

package/hplip/hplip.mk line 11

Quoted 3 lines
package/hplip/hplip.mk new file +3 -0
+HPLIP_INSTALL_STAGING = NO
+HPLIP_LIBTOOL_PATCH = YES 
+HPLIP_AUTORECONF = NO

All those values are the default, so they are unneeded. However, if possible, make your patch only on Makefile.am and do HPLIP_AUTORECONF = YES.

package/hplip/hplip.mk line 14

Quoted 3 lines
package/hplip/hplip.mk new file +3 -0
+
+#HPLIP_CONF_ENV += \
+#	ac_cv_prog_ac_ct_STRIP=arm-none-linux-gnueabi-strip

Please remove such dead code.

Quoted 6 lines
package/hplip/hplip.mk new file +6 -0
+
+HPLIP_CONF_OPT =           --disable-qt4 \
+                           --disable-scan-build \
+                           --disable-gui-build \
+                           --disable-doc-build \
+                           --disable-network-build \

package/hplip/hplip.mk line 30

Quoted 10 lines
package/hplip/hplip.mk new file +10 -0
+                           --enable-hpcups-install \
+                           --disable-hpijs-install \
+                           --enable-cups-ppd-install \
+                           --enable-cups-drv-install \
+                           --disable-foomatic-ppd-install \
+                           --disable-foomatic-drv-install \
+                           --disable-foomatic-rip-hplip-install \
+                           --enable-new-hpcups \
+                           --enable-lite-build \
+                           --with-sysroot=$(STAGING_DIR) \

Why is this needed?

package/hplip/hplip.mk line 31

Quoted 1 line
package/hplip/hplip.mk new file +1 -0
+			   --includedir=$(STAGING_DIR)

Remove this --includedir, once you make the modification I suggested above (-I$(includedir)/libusb-1.0), it should no longer be needed to pass a custom --incluedir.

Also, that's nitpicking, but we usually prefer the following formatting:

HPLIP_CONF_OPT = \
	--enable-foo \
	--disable-bar \
	--with-something=foobar

package/hplip/hplip.mk line 35

Quoted 4 lines
package/hplip/hplip.mk new file +4 -0
+
+ifeq ($(BR2_PACKAGE_DBUS),y)
+             HPLIP_CONF_OPT += --enable-dbus-build 
+endif

Add a:

else

	HPLIP_CONFIG_OPT += --disable-dbus-build

endif

package/hplip/hplip.mk line 41

Quoted 6 lines
package/hplip/hplip.mk new file +6 -0
+   
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+             HPLIP_CONF_OPT += --disable-shared 
+else
+             HPLIP_CONF_OPT += --enable-shared 
+endif

Not needed, already passed by the autotools package infrastructure.

package/hplip/hplip.mk line 49

Quoted 8 lines
package/hplip/hplip.mk new file +8 -0
+
+HPLIP_DEPENDENCIES = cups libusb
+
+
+define HPLIP_POST_INSTALL_TARGET_FIXUP
+	mkdir -p $(TARGET_DIR)/usr/share/hplip/data/models
+        cp $(@D)/data/models/* $(TARGET_DIR)/usr/share/hplip/data/models
+endef

Please fix the indentation here, it should be one tab.

package/hplip/hplip.mk line 52

Quoted 3 lines
package/hplip/hplip.mk new file +3 -0
+HPLIP_POST_INSTALL_TARGET_HOOKS += HPLIP_POST_INSTALL_TARGET_FIXUP
+
+$(eval $(autotools-package))

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 Added package HPLIP for printing to HP printers

HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed solution for printing, scanning, and faxing with HP inkjet and laser based printers in Linux.

The --includedir=$(STAGING_DIR)/usr/include is unfortunately necessary even with the modified Makefile.am for a succesful build.

Created a menu for cups related components to be kept close together.

---
 package/Config.in                  |    3 ++
 package/hplip/Config.in            |   13 +++++++
 package/hplip/hplip-fix-make.patch |   74 ++++++++++++++++++++++++++++++++++++
 package/hplip/hplip.mk             |   53 ++++++++++++++++++++++++++
 4 files changed, 143 insertions(+)
 create mode 100644 package/hplip/Config.in
 create mode 100644 package/hplip/hplip-fix-make.patch
 create mode 100644 package/hplip/hplip.mk
package/Config.in +3 -0
index 8a02506..646dd68 100644
@@ -627,7 +627,10 @@ source "package/can-utils/Config.in"
 source "package/connman/Config.in"
 source "package/ctorrent/Config.in"
 source "package/conntrack-tools/Config.in"
+menu "cups (common unix printing system)"
 source "package/cups/Config.in"
+source "package/hplip/Config.in"
+endmenu #cups
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/dhcp/Config.in"
 endif
package/hplip/Config.in new file +13 -0
new file mode 100644
index 0000000..b0d802a
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_HPLIP
+	bool "hplip"
+	select BR2_PACKAGE_LIBUSB
+	help
+	  HP Linux Imaging and Printing (HPLIP)
+	  HPLIP is an HP-developed solution for printing, scanning, and faxing
+	  with HP inkjet and laser based printers in Linux. The HPLIP project 
+	  provides printing support for 2,211 printer models, including 
+	  Deskjet, Officejet, Photosmart, PSC (Print Scan Copy), Business 
+	  Inkjet, LaserJet, Edgeline MFP, and LaserJet MFP. 
+	  
+	  http://hplipopensource.com/
+
package/hplip/hplip-fix-make.patch new file +74 -0

74 lines not on this page · raw message

package/hplip/hplip.mk new file +53 -0

53 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#3 lore raw

PATCH v2 1/1 Added package HPLIP for printing to HP printers

Hi Olivier,

Quoted 10 lines · Olivier Schonken

HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed solution for printing, scanning, and faxing with HP inkjet and laser based printers in Linux.

The --includedir=$(STAGING_DIR)/usr/include is unfortunately necessary even with the modified Makefile.am for a succesful build.

Created a menu for cups related components to be kept close together.

[...]

package/hplip/Config.in line 3

Quoted 3 lines
package/hplip/Config.in new file +3 -0
+config BR2_PACKAGE_HPLIP
+	bool "hplip"
+	select BR2_PACKAGE_LIBUSB

Also select BR2_PACKAGE_CUPS, since it is listed as dependency below. Remember to also depend on dbus' dependencies.

[...]

package/hplip/hplip.mk line 30

Quoted 2 lines
package/hplip/hplip.mk new file +2 -0
+ifeq ($(BR2_PACKAGE_DBUS),y)
+	HPLIP_CONF_OPT += --enable-dbus-build 

Add 'HPLIP_DEPENDENCIES += dbus', and make sure you do not override this assignment below.

package/hplip/hplip.mk line 35

Quoted 5 lines
package/hplip/hplip.mk new file +5 -0
+else
+	HPLIP_CONF_OPT += --disable-dbus-build 
+endif
+   
+HPLIP_DEPENDENCIES = cups libusb

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#4 lore raw

PATCH v3 1/1 Added package HPLIP for printing to HP printers

HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed solution for printing, scanning, and faxing with HP inkjet and laser based printers in Linux.

The --includedir=$(STAGING_DIR)/usr/include is unfortunately necessary even with the modified Makefile.am for a succesful build.

Created a menu for cups related components to be kept close together.

Fixed a jpeg and dbus dependencies, Thanks for pointing out the dbus dependency Baruch.

---
 package/Config.in                  |    3 ++
 package/hplip/Config.in            |   15 ++++++++
 package/hplip/hplip-fix-make.patch |   74 ++++++++++++++++++++++++++++++++++++
 package/hplip/hplip.mk             |   52 +++++++++++++++++++++++++
 4 files changed, 144 insertions(+)
 create mode 100644 package/hplip/Config.in
 create mode 100644 package/hplip/hplip-fix-make.patch
 create mode 100644 package/hplip/hplip.mk
package/Config.in +3 -0
index a65054c..21c3ec9 100644
@@ -631,7 +631,10 @@ source "package/can-utils/Config.in"
 source "package/connman/Config.in"
 source "package/ctorrent/Config.in"
 source "package/conntrack-tools/Config.in"
+menu "cups (common unix printing system)"
 source "package/cups/Config.in"
+source "package/hplip/Config.in"
+endmenu #cups
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/dhcp/Config.in"
 endif
package/hplip/Config.in new file +15 -0
new file mode 100644
index 0000000..4c673e6
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_HPLIP
+	bool "hplip"
+	depends on BR2_PACKAGE_CUPS
+	select BR2_PACKAGE_LIBUSB
+	select BR2_PACKAGE_JPEG
+	help
+	  HP Linux Imaging and Printing (HPLIP)
+	  HPLIP is an HP-developed solution for printing, scanning, and faxing
+	  with HP inkjet and laser based printers in Linux. The HPLIP project 
+	  provides printing support for 2,211 printer models, including 
+	  Deskjet, Officejet, Photosmart, PSC (Print Scan Copy), Business 
+	  Inkjet, LaserJet, Edgeline MFP, and LaserJet MFP. 
+	  
+	  http://hplipopensource.com/
+
package/hplip/hplip-fix-make.patch new file +74 -0

74 lines not on this page · raw message

package/hplip/hplip.mk new file +52 -0

52 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#5 lore raw

PATCH v3 1/1 Added package HPLIP for printing to HP printers

Dear Olivier Schonken,

Quoted 11 lines · Olivier Schonken

HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed solution for printing, scanning, and faxing with HP inkjet and laser based printers in Linux.

The --includedir=$(STAGING_DIR)/usr/include is unfortunately necessary even with the modified Makefile.am for a succesful build.

Created a menu for cups related components to be kept close together.

Fixed a jpeg and dbus dependencies, Thanks for pointing out the dbus dependency Baruch.

The "changelog" shouldn't go in the commit log, but instead...

Quoted 3 lines

---

... here. Otherwise, it gets committed and kept in the project history, which doesn't make much sense.

Quoted 5 lines

new file mode 100644
index 0000000..1bfac40

package/hplip/hplip.mk line 10

Quoted 10 lines
package/hplip/hplip.mk new file +10 -0
@@ -0,0 +1,52 @@
+#############################################################
+#
+# hplip
+#
+#############################################################
+
+HPLIP_VERSION = 3.12.11
+HPLIP_SITE = http://downloads.sourceforge.net/hplip/hplip/
+HPLIP_AUTORECONF = YES
+HPLIP_DEPENDENCIES = cups libusb jpeg

You should add HPLIP_LICENSE and HPLIP_LICENSE_FILES here.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#6 lore raw

PATCH v4 1/1 Added package HPLIP for printing to HP printers

In reply to Olivier Schonken

HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed solution for printing, scanning, and faxing with HP inkjet and laser based printers in Linux.

---
Changelog:
The --includedir=$(STAGING_DIR)/usr/include is unfortunately necessary even with the modified Makefile.am for a succesful build.

Created a menu for cups related components to be kept close together.

Fixed a jpeg and dbus dependencies, Thanks for pointing out the dbus dependency Baruch.

Added Licensing information

 package/Config.in                  |    3 ++
 package/hplip/Config.in            |   15 ++++++++
 package/hplip/hplip-fix-make.patch |   74 ++++++++++++++++++++++++++++++++++++
 package/hplip/hplip.mk             |   54 ++++++++++++++++++++++++++
 4 files changed, 146 insertions(+)
 create mode 100644 package/hplip/Config.in
 create mode 100644 package/hplip/hplip-fix-make.patch
 create mode 100644 package/hplip/hplip.mk
package/Config.in +3 -0
index a65054c..21c3ec9 100644
@@ -631,7 +631,10 @@ source "package/can-utils/Config.in"
 source "package/connman/Config.in"
 source "package/ctorrent/Config.in"
 source "package/conntrack-tools/Config.in"
+menu "cups (common unix printing system)"
 source "package/cups/Config.in"
+source "package/hplip/Config.in"
+endmenu #cups
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/dhcp/Config.in"
 endif
package/hplip/Config.in new file +15 -0
new file mode 100644
index 0000000..4c673e6
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_HPLIP
+	bool "hplip"
+	depends on BR2_PACKAGE_CUPS
+	select BR2_PACKAGE_LIBUSB
+	select BR2_PACKAGE_JPEG
+	help
+	  HP Linux Imaging and Printing (HPLIP)
+	  HPLIP is an HP-developed solution for printing, scanning, and faxing
+	  with HP inkjet and laser based printers in Linux. The HPLIP project 
+	  provides printing support for 2,211 printer models, including 
+	  Deskjet, Officejet, Photosmart, PSC (Print Scan Copy), Business 
+	  Inkjet, LaserJet, Edgeline MFP, and LaserJet MFP. 
+	  
+	  http://hplipopensource.com/
+
package/hplip/hplip-fix-make.patch new file +74 -0

74 lines not on this page · raw message

package/hplip/hplip.mk new file +54 -0

54 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#7 lore raw

PATCH v4 1/1 Added package HPLIP for printing to HP printers

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"O" == Olivier Schonken <[email protected]> writes:

O> HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed O> solution for printing, scanning, and faxing with HP inkjet and laser O> based printers in Linux.

O> Signed-off-by: Olivier Schonken <[email protected]> O> ---
O> Changelog:
O> The --includedir=$(STAGING_DIR)/usr/include is unfortunately necessary even O> with the modified Makefile.am for a succesful build.

O> Created a menu for cups related components to be kept close together.

O> Fixed a jpeg and dbus dependencies, Thanks for pointing out the dbus O> dependency Baruch.

O> Added Licensing information

 O>  package/Config.in                  |    3 ++
 O>  package/hplip/Config.in            |   15 ++++++++
 O>  package/hplip/hplip-fix-make.patch |   74 ++++++++++++++++++++++++++++++++++++
 O>  package/hplip/hplip.mk             |   54 ++++++++++++++++++++++++++
 O>  4 files changed, 146 insertions(+)
 O>  create mode 100644 package/hplip/Config.in
 O>  create mode 100644 package/hplip/hplip-fix-make.patch
 O>  create mode 100644 package/hplip/hplip.mk

O> diff --git a/package/Config.in b/package/Config.in O> index a65054c..21c3ec9 100644
O> --- a/package/Config.in
O> +++ b/package/Config.in
O> @@ -631,7 +631,10 @@ source "package/can-utils/Config.in"

 O>  source "package/connman/Config.in"
 O>  source "package/ctorrent/Config.in"
 O>  source "package/conntrack-tools/Config.in"

O> +menu "cups (common unix printing system)"
O> source "package/cups/Config.in"
O> +source "package/hplip/Config.in"
O> +endmenu #cups

With only a single sub package I don't think the menu makes sense (but keep hplip right after cups).

 O>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 O>  source "package/dhcp/Config.in"
 O>  endif

O> diff --git a/package/hplip/Config.in b/package/hplip/Config.in O> new file mode 100644
O> index 0000000..4c673e6
O> --- /dev/null
O> +++ b/package/hplip/Config.in
O> @@ -0,0 +1,15 @@
O> +config BR2_PACKAGE_HPLIP
O> + bool "hplip"
O> + depends on BR2_PACKAGE_CUPS
O> + select BR2_PACKAGE_LIBUSB
O> + select BR2_PACKAGE_JPEG

It needs atleast C++ support as well:

checking whether the C++ compiler works... no
configure: error: in `/home/peko/source/buildroot/output/build/hplip-3.12.11':
configure: error: C++ compiler cannot create executables
See `config.log' for more details

Please check with a minimal build to ensure you have all dependencies.

O> + help

 O> +	  HP Linux Imaging and Printing (HPLIP)
 O> +	  HPLIP is an HP-developed solution for printing, scanning, and faxing
 O> +	  with HP inkjet and laser based printers in Linux. The HPLIP project 
 O> +	  provides printing support for 2,211 printer models, including 
 O> +	  Deskjet, Officejet, Photosmart, PSC (Print Scan Copy), Business 
 O> +	  Inkjet, LaserJet, Edgeline MFP, and LaserJet MFP. 

O> +
O> + http://hplipopensource.com/
O> +

You have a number of trailing spaces and an extra empty line at the bottom here.

O> diff --git a/package/hplip/hplip.mk b/package/hplip/hplip.mk O> new file mode 100644
O> index 0000000..2d62392
O> --- /dev/null
O> +++ b/package/hplip/hplip.mk
O> @@ -0,0 +1,54 @@
O> +############################################################# O> +#
O> +# hplip
O> +#
O> +############################################################# O> +
O> +HPLIP_VERSION = 3.12.11

Latest version is 3.13.3. Any reason why you are not using that?

O> +HPLIP_SITE = http://downloads.sourceforge.net/hplip/hplip/

That URL doesn't work. It seems like it should be:

http://prdownloads.sourceforge.net/hplip/

O> +HPLIP_AUTORECONF = YES
O> +HPLIP_DEPENDENCIES = cups libusb jpeg
O> +HPLIP_LICENSE = GPLv2 BSD-3c MIT
O> +HPLIP_LICENSE_FILES = COPYING
O> +
O> +HPLIP_CONF_OPT = \
O> + --disable-qt4 \
O> + --disable-scan-build \
O> + --disable-gui-build \
O> + --disable-doc-build \
O> + --disable-network-build \
O> + --enable-hpcups-install \
O> + --disable-hpijs-install \
O> + --enable-cups-ppd-install \
O> + --enable-cups-drv-install \
O> + --disable-foomatic-ppd-install \
O> + --disable-foomatic-drv-install \
O> + --disable-foomatic-rip-hplip-install \
O> + --enable-new-hpcups \
O> + --enable-lite-build \
O> + --with-sysroot=$(STAGING_DIR) \
O> + --includedir=$(STAGING_DIR)/usr/include

We do have qt4, sane, polkit and python in buildroot, so optional support for these would be nice (but isn't essential).

O> +
O> +ifeq ($(BR2_PACKAGE_DBUS),y)
O> + HPLIP_CONF_OPT += --enable-dbus-build
O> + HPLIP_DEPENDENCIES += dbus
O> +else
O> + HPLIP_CONF_OPT += --disable-dbus-build
O> +endif

Again trailing spaces for both.

O> +
O> +define HPLIP_POST_INSTALL_TARGET_FIXUP
O> + mkdir -p $(TARGET_DIR)/usr/share/hplip/data/models
O> + cp $(@D)/data/models/* $(TARGET_DIR)/usr/share/hplip/data/models
O> +endef
O> +HPLIP_POST_INSTALL_TARGET_HOOKS += HPLIP_POST_INSTALL_TARGET_FIXUP O> +
O> +define HPLIP_PRE_CONFIGURE_FIXUP
O> + touch $(@D)/AUTHORS
O> + touch $(@D)/ChangeLog
O> + touch $(@D)/CHANGES
O> + touch $(@D)/NEWS
O> + touch $(@D)/README
O> +endef
O> +HPLIP_PRE_CONFIGURE_HOOKS += HPLIP_PRE_CONFIGURE_FIXUP

As far as I can see CHANGES isn't needed. It would be good with a comment explaining why it is needed (missing from tarball but needed to autoreconf).

Care to fix these issues and resend?

Signature · 1 line
Bye, Peter Korsgaard
#8 lore raw

PATCH v5 1/1 Added package HPLIP for printing to HP printers

In reply to Olivier Schonken

HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed solution for printing, scanning, and faxing with HP inkjet and laser based printers in Linux.

---
Changelog:
The --includedir=$(STAGING_DIR)/usr/include is unfortunately necessary even with the modified Makefile.am for a succesful build.
Fixed a jpeg and dbus dependencies, Thanks for pointing out the dbus dependency Baruch.
Added Licensing information
Updated version to most recent 3.13.3
Fixed download site link (Trailing slash was breaking it) Removed trailing whitespaces
Added check for C++ enabled compiler in Config.in
Updated hplip-fix-make.patch for newer version

 package/Config.in                  |    1 +
 package/hplip/Config.in            |   17 +++++++++
 package/hplip/hplip-fix-make.patch |   74 ++++++++++++++++++++++++++++++++++++
 package/hplip/hplip.mk             |   53 ++++++++++++++++++++++++++
 4 files changed, 145 insertions(+)
 create mode 100644 package/hplip/Config.in
 create mode 100644 package/hplip/hplip-fix-make.patch
 create mode 100644 package/hplip/hplip.mk
package/Config.in +1 -0
index a65054c..24caba0 100644
@@ -632,6 +632,7 @@ source "package/connman/Config.in"
 source "package/ctorrent/Config.in"
 source "package/conntrack-tools/Config.in"
 source "package/cups/Config.in"
+source "package/hplip/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/dhcp/Config.in"
 endif
package/hplip/Config.in new file +17 -0
new file mode 100644
index 0000000..551e9c4
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_HPLIP
+	bool "hplip"
+	depends on BR2_PACKAGE_CUPS
+	select BR2_PACKAGE_LIBUSB
+	select BR2_PACKAGE_JPEG
+	help
+	  HP Linux Imaging and Printing (HPLIP)
+	  HPLIP is an HP-developed solution for printing, scanning, and faxing
+	  with HP inkjet and laser based printers in Linux. The HPLIP project
+	  provides printing support for 2,211 printer models, including
+	  Deskjet, Officejet, Photosmart, PSC (Print Scan Copy), Business
+	  Inkjet, LaserJet, Edgeline MFP, and LaserJet MFP.
+  
+	  http://hplipopensource.com/
+
+comment "hplip requires a toolchain with C++ support enabled"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/hplip/hplip-fix-make.patch new file +74 -0

74 lines not on this page · raw message

package/hplip/hplip.mk new file +53 -0

53 lines not on this page · raw message

Signature · 1 line
1.7.10.4
#9 lore raw

PATCH v5 1/1 Added package HPLIP for printing to HP printers

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Olivier" == Olivier Schonken <[email protected]> writes:

Olivier> HPLIP (Hewlett-Packard Linux Imaging & Printing) is an HP-developed solution Olivier> for printing, scanning, and faxing with HP inkjet and laser based printers Olivier> in Linux.

Olivier> Signed-off-by: Olivier Schonken <[email protected]> Olivier> ---
Olivier> Changelog:
Olivier> The --includedir=$(STAGING_DIR)/usr/include is unfortunately necessary even Olivier> with the modified Makefile.am for a succesful build.
Olivier> Fixed a jpeg and dbus dependencies, Thanks for pointing out the dbus Olivier> dependency Baruch.
Olivier> Added Licensing information
Olivier> Updated version to most recent 3.13.3
Olivier> Fixed download site link (Trailing slash was breaking it) Olivier> Removed trailing whitespaces
Olivier> Added check for C++ enabled compiler in Config.in
Olivier> Updated hplip-fix-make.patch for newer version

 Olivier>  package/Config.in                  |    1 +
 Olivier>  package/hplip/Config.in            |   17 +++++++++
 Olivier>  package/hplip/hplip-fix-make.patch |   74 ++++++++++++++++++++++++++++++++++++
 Olivier>  package/hplip/hplip.mk             |   53 ++++++++++++++++++++++++++
 Olivier>  4 files changed, 145 insertions(+)
 Olivier>  create mode 100644 package/hplip/Config.in
 Olivier>  create mode 100644 package/hplip/hplip-fix-make.patch
 Olivier>  create mode 100644 package/hplip/hplip.mk

Olivier> diff --git a/package/Config.in b/package/Config.in Olivier> index a65054c..24caba0 100644
Olivier> --- a/package/Config.in
Olivier> +++ b/package/Config.in
Olivier> @@ -632,6 +632,7 @@ source "package/connman/Config.in"

 Olivier>  source "package/ctorrent/Config.in"
 Olivier>  source "package/conntrack-tools/Config.in"
 Olivier>  source "package/cups/Config.in"
 Olivier> +source "package/hplip/Config.in"
 Olivier>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 Olivier>  source "package/dhcp/Config.in"
 Olivier>  endif
 Olivier> diff --git a/package/hplip/Config.in b/package/hplip/Config.in
 Olivier> new file mode 100644
 Olivier> index 0000000..551e9c4
 Olivier> --- /dev/null
 Olivier> +++ b/package/hplip/Config.in
 Olivier> @@ -0,0 +1,17 @@
 Olivier> +config BR2_PACKAGE_HPLIP
 Olivier> +	bool "hplip"
 Olivier> +	depends on BR2_PACKAGE_CUPS
 Olivier> +	select BR2_PACKAGE_LIBUSB
 Olivier> +	select BR2_PACKAGE_JPEG
 Olivier> +	help
 Olivier> +	  HP Linux Imaging and Printing (HPLIP)
 Olivier> +	  HPLIP is an HP-developed solution for printing, scanning, and faxing
 Olivier> +	  with HP inkjet and laser based printers in Linux. The HPLIP project
 Olivier> +	  provides printing support for 2,211 printer models, including
 Olivier> +	  Deskjet, Officejet, Photosmart, PSC (Print Scan Copy), Business
 Olivier> +	  Inkjet, LaserJet, Edgeline MFP, and LaserJet MFP.

Olivier> +

You have some trailing spaces here.

Committed with that fixed, thanks!

Signature · 1 line
Bye, Peter Korsgaard