Skip to contentSkip to conversation

pci, aer_inject fix return values when device not found

PATCH In review Prarit Bhargava 2 participants 2 messages Mar 20, 2013 – Apr 3, 2013 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pci, aer_inject fix return values when device not found

Currently the aer_inject driver returns -ENOTTY when the target PCIE device root port is not found or if the device or root port doesn't support AER.

In the case where the root port isn't found, the driver should return -ENODEV, and in the other cases it should return -EPERM.

---
 drivers/pci/pcie/aer/aer_inject.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pci/pcie/aer/aer_inject.c +3 -3
index 4e24cb8..8d4a5e3 100644
@@ -334,13 +334,13 @@ static int aer_inject(struct aer_error_inj *einj)
 		return -ENODEV;
 	rpdev = pcie_find_root_port(dev);
 	if (!rpdev) {
-		ret = -ENOTTY;
+		ret = -ENODEV;
 		goto out_put;
 	}
 
 	pos_cap_err = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);
 	if (!pos_cap_err) {
-		ret = -ENOTTY;
+		ret = -EPERM;
 		goto out_put;
 	}
 	pci_read_config_dword(dev, pos_cap_err + PCI_ERR_UNCOR_SEVER, &sever);
@@ -350,7 +350,7 @@ static int aer_inject(struct aer_error_inj *einj)
 
 	rp_pos_cap_err = pci_find_ext_capability(rpdev, PCI_EXT_CAP_ID_ERR);
 	if (!rp_pos_cap_err) {
-		ret = -ENOTTY;
+		ret = -EPERM;
 		goto out_put;
 	}
 
Signature · 1 line
1.7.9.3
maintainer
#1 lore raw
Quoted 7 lines · Prarit Bhargava

Currently the aer_inject driver returns -ENOTTY when the target PCIE device root port is not found or if the device or root port doesn't support AER.

In the case where the root port isn't found, the driver should return -ENODEV, and in the other cases it should return -EPERM.

Applied for v3.10, thanks.

Ben, chime in if you have any input about errno usage :)

Quoted 40 lines
---
 drivers/pci/pcie/aer/aer_inject.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pci/pcie/aer/aer_inject.c +3 -4
index 4e24cb8..8d4a5e3 100644
@@ -334,13 +334,13 @@ static int aer_inject(struct aer_error_inj *einj)
                return -ENODEV;
        rpdev = pcie_find_root_port(dev);
        if (!rpdev) {
-               ret = -ENOTTY;
+               ret = -ENODEV;
                goto out_put;
        }
 
        pos_cap_err = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);
        if (!pos_cap_err) {
-               ret = -ENOTTY;
+               ret = -EPERM;
                goto out_put;
        }
        pci_read_config_dword(dev, pos_cap_err + PCI_ERR_UNCOR_SEVER, &sever);
@@ -350,7 +350,7 @@ static int aer_inject(struct aer_error_inj *einj)
 
        rp_pos_cap_err = pci_find_ext_capability(rpdev, PCI_EXT_CAP_ID_ERR);
        if (!rp_pos_cap_err) {
-               ret = -ENOTTY;
+               ret = -EPERM;
                goto out_put;
        }
 
--

1.7.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html