pci, aer_inject fix return values when device not found
PATCH 1/1 pci, aer_inject fix return values when device not found
Currently the aer_inject driver returns -ENOTTY when the target PCIE device root port is not found or if the device or root port doesn't support AER.
In the case where the root port isn't found, the driver should return -ENODEV, and in the other cases it should return -EPERM.
--- drivers/pci/pcie/aer/aer_inject.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pci/pcie/aer/aer_inject.c +3 -3
@@ -334,13 +334,13 @@ static int aer_inject(struct aer_error_inj *einj)return -ENODEV ; rpdev =pcie_find_root_port (dev);if (!rpdev) { - ret = -ENOTTY ; + ret = -ENODEV ; goto out_put; } pos_cap_err =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR );if (!pos_cap_err) { - ret = -ENOTTY ; + ret = -EPERM ; goto out_put; }pci_read_config_dword (dev, pos_cap_err +PCI_ERR_UNCOR_SEVER , &sever);
@@ -350,7 +350,7 @@ static int aer_inject(struct aer_error_inj *einj) rp_pos_cap_err =pci_find_ext_capability (rpdev,PCI_EXT_CAP_ID_ERR );if (!rp_pos_cap_err) { - ret = -ENOTTY ; + ret = -EPERM ; goto out_put; }
Signature · 1 line
1.7.9.3
Bjorn Helgaas
maintainerQuoted 7 lines · Prarit Bhargava
Currently the
aer_injectdriver returns-ENOTTYwhen the target PCIE device root port is not found or if the device or root port doesn't support AER.In the case where the root port isn't found, the driver should return
-ENODEV, and in the other cases it should return-EPERM.Signed-off-by Prarit Bhargava <[email protected]>
Applied for v3.10, thanks.
Ben, chime in if you have any input about errno usage :)
Quoted 40 lines
--- drivers/pci/pcie/aer/aer_inject.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/pci/pcie/aer/aer_inject.c +3
-4@@ -334,13 +334,13 @@ static int aer_inject(struct aer_error_inj *einj)return -ENODEV ; rpdev =pcie_find_root_port (dev);if (!rpdev) { - ret = -ENOTTY ; + ret = -ENODEV ; goto out_put; } pos_cap_err =pci_find_ext_capability (dev,PCI_EXT_CAP_ID_ERR );if (!pos_cap_err) { - ret = -ENOTTY ; + ret = -EPERM ; goto out_put; }pci_read_config_dword (dev, pos_cap_err +PCI_ERR_UNCOR_SEVER , &sever);@@ -350,7 +350,7 @@ static int aer_inject(struct aer_error_inj *einj) rp_pos_cap_err =pci_find_ext_capability (rpdev,PCI_EXT_CAP_ID_ERR );if (!rp_pos_cap_err) { - ret = -ENOTTY ; + ret = -EPERM ; goto out_put; } --1.7.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html