Skip to contentSkip to conversation

bridge: avoid br_ifinfo_notify when nothing changed

PATCH In review Hong Zhiguo 3 participants 9 messages Mar 23, 2013 – Mar 25, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bridge: avoid br_ifinfo_notify when nothing changed

When neither IFF_BRIDGE_PORT or IFF_BRIDGE_PORT is set, and afspec == NULL but protinfo != NULL, we run into "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with random value in ret.

---
 net/bridge/br_netlink.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/bridge/br_netlink.c +2 -2
index 84c3b7d..b96e02e 100644
@@ -357,7 +357,7 @@ int br_setlink(struct net_device *dev, struct nlmsghdr *nlh)
 	struct nlattr *afspec;
 	struct net_bridge_port *p;
 	struct nlattr *tb[IFLA_BRPORT_MAX + 1];
-	int err;
+	int err = 0;
 
 	ifm = nlmsg_data(nlh);
 
@@ -370,7 +370,7 @@ int br_setlink(struct net_device *dev, struct nlmsghdr *nlh)
 	/* We want to accept dev as bridge itself if the AF_SPEC
 	 * is set to see if someone is setting vlan info on the brigde
 	 */
-	if (!p && ((dev->priv_flags & IFF_EBRIDGE) && !afspec))
+	if (!p && !afspec)
 		return -EINVAL;
 
 	if (p && protinfo) {
Signature · 1 line
1.7.10.4
#1 lore raw

Hello.

Quoted 1 line · Hong Zhiguo

When neither IFF_BRIDGE_PORT or IFF_BRIDGE_PORT is set,

That is the same flag repeated twice.

Quoted 5 lines

and afspec == NULL but protinfo != NULL, we run into "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with random value in ret.

WBR, Sergei

#2 lore raw

PATCH 1/1 bridge: avoid br_ifinfo_notify when nothing changed

In reply to Hong Zhiguo

When neither IFF_BRIDGE nor IFF_BRIDGE_PORT is set, and afspec == NULL but protinfo != NULL, we run into "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with random value in ret.

Thanks to Sergei for pointing out the error in commit comments.

---
 net/bridge/br_netlink.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/bridge/br_netlink.c +2 -2
index 84c3b7d..b96e02e 100644
@@ -357,7 +357,7 @@ int br_setlink(struct net_device *dev, struct nlmsghdr *nlh)
 	struct nlattr *afspec;
 	struct net_bridge_port *p;
 	struct nlattr *tb[IFLA_BRPORT_MAX + 1];
-	int err;
+	int err = 0;
 
 	ifm = nlmsg_data(nlh);
 
@@ -370,7 +370,7 @@ int br_setlink(struct net_device *dev, struct nlmsghdr *nlh)
 	/* We want to accept dev as bridge itself if the AF_SPEC
 	 * is set to see if someone is setting vlan info on the brigde
 	 */
-	if (!p && ((dev->priv_flags & IFF_EBRIDGE) && !afspec))
+	if (!p && !afspec)
 		return -EINVAL;
 
 	if (p && protinfo) {
Signature · 1 line
1.7.10.4
#3 lore raw

Hello.

Quoted 8 lines · Hong Zhiguo

When neither IFF_BRIDGE nor IFF_BRIDGE_PORT is set, and afspec == NULL but protinfo != NULL, we run into "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with random value in ret.

Thanks to Sergei for pointing out the error in commit comments.

For the future, if you post the revised version of the patch, you
should indicate in the subject it like this: [PATCH v2].

WBR, Sergei

maintainer
#4 lore raw

From: Sergei Shtylyov <[email protected]>
Date: Sun, 24 Mar 2013 17:34:47 +0300

Quoted 9 lines

Hello.

Quoted 5 lines · Hong Zhiguo

When neither IFF_BRIDGE nor IFF_BRIDGE_PORT is set, and afspec == NULL but protinfo != NULL, we run into "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with random value in ret.

Quoted 6 lines
Quoted 3 lines

Thanks to Sergei for pointing out the error in commit comments.

For the future, if you post the revised version of the patch, you
should indicate in the subject it like this: [PATCH v2].

I'm disappointed that you have enough energy to point out such a lower priority omission, but you lack the time for something more important, which is giving this patch your explicit ACK if it fixes all of the issues you pointed out to him.

Reviewed-by
#5 lore raw

Hello.

Quoted 9 lines · David Miller
Quoted 8 lines
Quoted 8 lines

When neither IFF_BRIDGE nor IFF_BRIDGE_PORT is set, and afspec == NULL but protinfo != NULL, we run into "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with random value in ret.

Thanks to Sergei for pointing out the error in commit comments.

Quoted 7 lines
Quoted 2 lines

For the future, if you post the revised version of the patch, you
should indicate in the subject it like this: [PATCH v2].

I'm disappointed that you have enough energy to point out such a lower priority omission, but you lack the time for something more important, which is giving this patch your explicit ACK if it fixes all of the issues you pointed out to him.

Sorry, I don't usuallly ACK patches in an area I'm not closely familiar
with. Though I can add:

WBR, Sergei

maintainer
#6 lore raw

From: Sergei Shtylyov <[email protected]>
Date: Mon, 25 Mar 2013 19:32:14 +0400

Quoted 2 lines

Sorry, I don't usuallly ACK patches in an area I'm not closely familiar with. Though I can add:

If you feel confident enough to ask for corrections, you better be ready to ACK the result when your requests have been met.

You can't hold other people accountable yet take none of the same responsibility yourself.

#7 lore raw

Hello.

Quoted 5 lines · David Miller
Quoted 2 lines

Sorry, I don't usuallly ACK patches in an area I'm not closely familiar with. Though I can add:

If you feel confident enough to ask for corrections, you better be ready to ACK the result when your requests have been met.

Come on, I only asked to correct an evident cut and paste typo in the
description. That's too little a correction to ACK the whole patch. To ACK it, I should know well the code it's patching and be confident that the whole patch is correct. I have neither knowledge.

Quoted 2 lines

You can't hold other people accountable yet take none of the same responsibility yourself.

I don't hold anyone accountable, I just provide my comments which might as
well be ignored by the submitter/maintainer.

WBR, Sergei

maintainer Applied
#8 lore raw
In reply to Hong Zhiguo

From: Hong Zhiguo <[email protected]>
Date: Sun, 24 Mar 2013 21:26:47 +0800

Quoted 8 lines

When neither IFF_BRIDGE nor IFF_BRIDGE_PORT is set, and afspec == NULL but protinfo != NULL, we run into "if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p);" with random value in ret.

Thanks to Sergei for pointing out the error in commit comments.

Applied.