bridge: fix crash when set mac address of br interface
Subsystems (3)
PATCH 1/1 bridge: fix crash when set mac address of br interface
When I tried to set mac address of a bridge interface to a mac address which already learned on this bridge, I got system hang.
The cause is straight forward: function br_fdb_change_mac_address calls fdb_insert with NULL source nbp. Then an fdb lookup is performed. If an fdb entry is found and it's local, it's OK. But if it's not local, source is dereferenced for printk without NULL check.
--- net/bridge/br_fdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/bridge/br_fdb.c +1 -1
@@ -421,7 +421,7 @@ static int fdb_insert(struct net_bridge *br, struct net_bridge_port *source,return 0 ;br_warn (br,"adding interface %s with same address " "as a received packet\n" , - source->dev->name); + source ? source->dev->name : br->dev->name);fdb_delete (br, fdb); }
Signature · 1 line
1.7.10.4
From: Hong Zhiguo <[email protected]>
Date: Sat, 23 Mar 2013 20:27:50 +0800
Quoted 10 lines
When I tried to set mac address of a bridge interface to a mac address which already learned on this bridge, I got system hang.
The cause is straight forward: function
br_fdb_change_mac_addresscallsfdb_insertwith NULL source nbp. Then an fdb lookup is performed. If an fdb entry is found and it's local, it's OK. But if it's not local, source is dereferenced for printk without NULL check.Signed-off-by Hong Zhiguo <[email protected]>
Applied.