tcp: undo spurious timeout after SACK reneging
Subsystems (3)
PATCH 1/1 tcp: undo spurious timeout after SACK reneging
On SACK reneging the sender immediately retransmits and forces a timeout but disables Eifel (undo). If the (buggy) receiver does not drop any packet this can trigger a false slow-start retransmit storm driven by the ACKs of the original packets. This can be detected with undo and TCP timestamps.
--- net/ipv4/tcp_input.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
net/ipv4/tcp_input.c +2 -5
@@ -1858,11 +1858,8 @@ void tcp_enter_loss(struct sock *sk, int how)if (tcp_is_reno (tp))tcp_reset_reno_sack (tp); -if (!how) { -/* Push undo marker, if it was plain RTO and nothing -* was retransmitted. */ - tp->undo_marker = tp->snd_una; - }else { + tp->undo_marker = tp->snd_una; +if (how) { tp->sacked_out =0 ; tp->fackets_out =0 ; }
Signature · 1 line
1.8.1.3
Quoted 10 lines · Yuchung Cheng
On SACK reneging the sender immediately retransmits and forces a timeout but disables Eifel (undo). If the (buggy) receiver does not drop any packet this can trigger a false slow-start retransmit storm driven by the ACKs of the original packets. This can be detected with undo and TCP timestamps.
Signed-off-by Yuchung Cheng <[email protected]>--- net/ipv4/tcp_input.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
neal
From: Neal Cardwell <[email protected]>
Date: Sun, 24 Mar 2013 16:50:41 -0400
Quoted 7 lines · Yuchung Cheng
Quoted 6 lines
On SACK reneging the sender immediately retransmits and forces a timeout but disables Eifel (undo). If the (buggy) receiver does not drop any packet this can trigger a false slow-start retransmit storm driven by the ACKs of the original packets. This can be detected with undo and TCP timestamps.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Yuchung Cheng <[email protected]>--- net/ipv4/tcp_input.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)Acked-by Neal Cardwell <[email protected]>
Applied.