staging: vme: fix for a potential NULL pointer dereference
Subsystems (2)
PATCH 1/1 staging: vme: fix for a potential NULL pointer dereference
Audit the return value of cdev_alloc and hence fixes a potential NULL pointer dereferencing.
Signed-off-by Kumar Amit Mehta <[email protected]>
--- drivers/staging/vme/devices/vme_user.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/staging/vme/devices/vme_user.c +4 -0
@@ -710,6 +710,10 @@ static int vme_user_probe(struct vme_dev *vdev)/* Register the driver as a char device */ vme_user_cdev =cdev_alloc (); +if (!vme_user_cdev) { + err = -ENOMEM ; + goto err_char; + } vme_user_cdev->ops = &vme_user_fops; vme_user_cdev->owner =THIS_MODULE ; err =cdev_add (vme_user_cdev,MKDEV (VME_MAJOR ,0 ),VME_DEVS );
Signature · 1 line
1.7.9.5
Quoted 4 lines · Kumar Amit Mehta
Audit the return value of
cdev_allocand hence fixes a potential NULL pointer dereferencing.Signed-off-by Kumar Amit Mehta <[email protected]>
Looks good to me, thanks.
Signed-off-by Martyn Welch <[email protected]>
Quoted 20 lines
--- drivers/staging/vme/devices/vme_user.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/staging/vme/devices/vme_user.c +4
-0@@ -710,6 +710,10 @@ static int vme_user_probe(struct vme_dev *vdev)/* Register the driver as a char device */ vme_user_cdev =cdev_alloc (); +if (!vme_user_cdev) { + err = -ENOMEM ; + goto err_char; + } vme_user_cdev->ops = &vme_user_fops; vme_user_cdev->owner =THIS_MODULE ; err =cdev_add (vme_user_cdev,MKDEV (VME_MAJOR ,0 ),VME_DEVS );
Signature · 4 lines
Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E [email protected] | VAT:GB 927559189