Skip to contentSkip to conversation

Create postinstall script for opkg conditionally

PATCH In review Kang Kai 2 participants 4 messages Mar 25, 2013 – Mar 26, 2013

lore
Share & tools
lore

Kang Kai

author
#0 lore raw

cover Create postinstall script for opkg conditionally

The following changes since commit 3c5f4d54d01887a117bf659fc9af6b2b892c2b08:

separatebuilddir.inc: mxsldr should never have been added to this list, remove (2013-03-24 14:03:19 +0000)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib kangkai/debug-tweaks
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/debug-tweaks

Kang Kai (1):
opkg: create run-scripts file conditionally

 meta/recipes-devtools/opkg/opkg.inc |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.5.4
author
#1 lore raw

PATCH 1/1 opkg: create run-scripts file conditionally

When build sato sdk image, opkg will be installed to image even the image package type is set to RPM. This causes the script file run-postinsts installed by rpm will be overwrited by opkg.

Judge the image package type and don't create run-scripts file when package type is not ipk.

[YOCTO #3223]

---
 meta/recipes-devtools/opkg/opkg.inc |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
meta/recipes-devtools/opkg/opkg.inc +6 -0
index f9c1202..bc80cb0 100644
@@ -59,10 +59,16 @@ do_install_append_class-native() {
 
 POSTLOG ?= "/var/log/postinstall.log"
 REDIRECT_CMD = "${@base_contains('IMAGE_FEATURES', 'debug-tweaks', '>${POSTLOG} 2>&1', '', d)}"
+PKGTYPE = "${@d.getVar('IMAGE_PKGTYPE', True)}"
 
 pkg_postinst_${PN} () {
 #!/bin/sh
 if [ "x$D" != "x" ]; then
+	# if installed to a rpm/deb based image, don't create run-postinsts file
+	if [ "x${PKGTYPE}" != "xipk" ]; then
+		exit 0
+	fi
+
 	install -d $D${sysconfdir}/rcS.d
 	# this happens at S98 where our good 'ole packages script used to run
 	echo "#!/bin/sh
Signature · 1 line
1.7.5.4
#2 lore raw

Re: [PATCH 1/1] opkg: create run-scripts file conditionally

Quoted 25 lines · Kang Kai

When build sato sdk image, opkg will be installed to image even the image package type is set to RPM. This causes the script file run-postinsts installed by rpm will be overwrited by opkg.

Judge the image package type and don't create run-scripts file when package type is not ipk.

[YOCTO #3223]

---
 meta/recipes-devtools/opkg/opkg.inc |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
meta/recipes-devtools/opkg/opkg.inc +1 -0
index f9c1202..bc80cb0 100644
@@ -59,10 +59,16 @@ do_install_append_class-native() {
 
 POSTLOG ?= "/var/log/postinstall.log"
 REDIRECT_CMD = "${@base_contains('IMAGE_FEATURES', 'debug-tweaks', '>${POSTLOG} 2>&1', '', d)}"
+PKGTYPE = "${@d.getVar('IMAGE_PKGTYPE', True)}"
 
 pkg_postinst_${PN} () {

meta/recipes-devtools/opkg/opkg.inc do_install_append_class-native() { · line 74

Quoted 10 lines
meta/recipes-devtools/opkg/opkg.inc +5 -0
 #!/bin/sh
 if [ "x$D" != "x" ]; then
+	# if installed to a rpm/deb based image, don't create run-postinsts file
+	if [ "x${PKGTYPE}" != "xipk" ]; then
+		exit 0
+	fi
+
 	install -d $D${sysconfdir}/rcS.d
 	# this happens at S98 where our good 'ole packages script used to run
 	echo "#!/bin/sh

Why are you trying to install opkg into an non-opkg rootfs in the first place? This looks like it will create subtle package differences depending on configuration and I'm wary of this...

Cheers,

Richard

author
#3 lore raw

Re: [PATCH 1/1] opkg: create run-scripts file conditionally

Quoted 25 lines · Richard Purdie
Quoted 24 lines · Kang Kai

When build sato sdk image, opkg will be installed to image even the image package type is set to RPM. This causes the script file run-postinsts installed by rpm will be overwrited by opkg.

Judge the image package type and don't create run-scripts file when package type is not ipk.

[YOCTO #3223]

---
  meta/recipes-devtools/opkg/opkg.inc |    6 ++++++
  1 files changed, 6 insertions(+), 0 deletions(-)
meta/recipes-devtools/opkg/opkg.inc +1 -0
index f9c1202..bc80cb0 100644
@@ -59,10 +59,16 @@ do_install_append_class-native() {
 
  POSTLOG ?= "/var/log/postinstall.log"
  REDIRECT_CMD = "${@base_contains('IMAGE_FEATURES', 'debug-tweaks', '>${POSTLOG} 2>&1', '', d)}"
+PKGTYPE = "${@d.getVar('IMAGE_PKGTYPE', True)}"
 
Quoted 14 lines

meta/recipes-devtools/opkg/opkg.inc do_install_append_class-native() { · line 74

Quoted 11 lines
meta/recipes-devtools/opkg/opkg.inc +5 -0
  pkg_postinst_${PN} () {
  #!/bin/sh
  if [ "x$D" != "x" ]; then
+	# if installed to a rpm/deb based image, don't create run-postinsts file
+	if [ "x${PKGTYPE}" != "xipk" ]; then
+		exit 0
+	fi
+
  	install -d $D${sysconfdir}/rcS.d
  	# this happens at S98 where our good 'ole packages script used to run
  	echo "#!/bin/sh

Why are you trying to install opkg into an non-opkg rootfs in the first place? This looks like it will create subtle package differences depending on configuration and I'm wary of this...

This just happens on sdk image.

update-alternatives-cworth is default installed into sato image. And for sato-sdk image, it installs every related -dev package. update-alternatives-cworth is from opkg, so opkg-dev is installed then it requires opkg, then opkg is installed into sato-sdk image.

This patch is try to fix this issue. I'll send V2 to update commit comments.

Regards,
Kai

Quoted 8 lines

Cheers,

Richard