dosfstools: really compile supporting large files [ Fix: 409915 ]
PATCH 1/1 dosfstools: really compile supporting large files [ Fix: 409915 ]
CQID: 409915
Makefile in the package tries to set _FILE_OFFSET_BITS=64, but we clobber that with our CFLAGS, so we add it in the recipe.
--- .../recipes-devtools/dosfstools/dosfstools_2.11.bb | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
meta/recipes-devtools/dosfstools/dosfstools_2.11.bb +6 -1
@@ -7,7 +7,7 @@ DESCRIPTION = "DOS FAT Filesystem Utilities" SECTION = "base" LICENSE = "GPLv2" LIC_FILES_CHKSUM = "file://mkdosfs/COPYING;md5=cbe67f08d6883bff587f615f0cc81aa8" -PR = "r4" +PR = "r5" SRC_URI = "ftp://ftp.uni-erlangen.de/pub/Linux/LOCAL/dosfstools/dosfstools-${PV}.src.tar.gz \ file://mkdosfs-bootcode.patch \
@@ -22,6 +22,11 @@ SRC_URI = "ftp://ftp.uni-erlangen.de/pub/Linux/LOCAL/dosfstools/dosfstools-${PV} SRC_URI[md5sum] = "407d405ade410f7597d364ab5dc8c9f6" SRC_URI[sha256sum] = "0eac6d12388b3d9ed78684529c1b0d9346fa2abbe406c4d4a3eb5a023c98a484" +# Makefile sets this, but we clobber its CFLAGS, so +# add this in here to for sure allow for big files. +# +CFLAGS_append = " -D_FILE_OFFSET_BITS=64" + do_install () { oe_runmake "PREFIX=${D}" "SBINDIR=${D}${sbindir}" \ "MANDIR=${D}${mandir}/man8" install
Signature · 1 line
1.7.3.4
Quoted 8 lines · Joe Slater
CQID: 409915
Makefilein the package tries to set _FILE_OFFSET_BITS=64, but we clobber that with our CFLAGS, so we add it in the recipe.Signed-off-by Joe Slater <[email protected]>
Afaik there is a largefile distro feature, should this use that, through packageconfig?
Signature · 1 line
Christopher Larson
Quoted 16 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Chris Larson
Sent: Monday, March 25, 2013 2:16 PM
To: Slater, Joseph
Cc: Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH 1/1] dosfstools: really compile supporting large files [
Fix: 409915 ]On Mon, Mar 25, 2013 at 1:49 PM, Joe Slater <[email protected]> wrote:
CQID: 409915
Quoted 8 lines
Makefilein the package tries to set _FILE_OFFSET_BITS=64, but we clobber that with our CFLAGS, so we add it in the recipe.Signed-off-by Joe Slater <[email protected]>Afaik there is a largefile distro feature, should this use that, through packageconfig?
This is really aimed at dosfstools-native, but I noticed, just by chance, that bzip2 unconditionally sets this, apparently without ill effect.
Joe
Quoted 2 lines
--
Christopher Larson