regulator: ab8500: Don't update is_enabled flag in error paths
PATCH 1/1 regulator: ab8500: Don't update is_enabled flag in error paths
This avoid setting is_enabled flag to wrong status if enable/disable fails.
Signed-off-by Axel Lin <[email protected]>
--- drivers/regulator/ab8500.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/regulator/ab8500.c +4 -2
@@ -121,7 +121,8 @@ static int ab8500_regulator_enable(struct regulator_dev *rdev)dev_err (rdev_get_dev (rdev),"couldn't set enable bits for regulator\n" ); - info->is_enabled = true; +if (ret ==0 ) + info->is_enabled = true; dev_vdbg(rdev_get_dev(rdev), "%s-enable (bank, reg, mask, value): 0x%x, 0x%x, 0x%x, 0x%x\n",
@@ -148,7 +149,8 @@ static int ab8500_regulator_disable(struct regulator_dev *rdev)dev_err (rdev_get_dev (rdev),"couldn't set disable bits for regulator\n" ); - info->is_enabled = false; +if (ret ==0 ) + info->is_enabled = false; dev_vdbg(rdev_get_dev(rdev), "%s-disable (bank, reg, mask, value): 0x%x, 0x%x, 0x%x, 0x%x\n",
Signature · 1 line
1.7.10.4