Skip to contentSkip to conversation

linux-next: build failure after merge of the char-misc tree

PATCH New Stephen Rothwell 2 participants 2 messages Mar 26, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

Hi all,

After merging the char-misc tree, today's linux-next build (x86_64_allmodconfig) failed like this:

drivers/input/keyboard/pmic8xxx-keypad.c:24:35: fatal error: linux/mfd/pm8xxx/gpio.h: No such file or directory

Caused by commit e44b0ceee4cc ("add single-wire serial bus interface (SSBI) driver") which added the Kconfig symbol MSM_SSBI (later changed to just SSBI) which did not exist in the tree before. However, MFD_PM8921_CORE depended on it and that selects MFD_PM8XXX which allows the above file to build (and fail).

I have used the char-misc tree from next-20130325 for today.

Signature · 2 lines
Cheers,
Stephen Rothwell                    [email protected]
#1 lore raw

PATCH 1/1 mfd: pm8921: Disable driver until it gets fixed

The pm8921 driver has been broken for a while now, but was prevented from compiling because the SSBI bus driver was missing. Now that SSBI is present, pm8921 causes compile fails.

Until the pm8921 driver is fixed, mark it as BROKEN to prevent compiles from failing.

Cc Greg KH <[email protected]>
Cc Stephen Rothwell <[email protected]>

---
Someone is working on the pm8921 driver, but we need to disable it until those patches are posted.

 drivers/mfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/Kconfig +1 -1
index 5bfa7bb..b9723a8 100644
@@ -990,7 +990,7 @@ config MFD_PM8XXX
 
 config MFD_PM8921_CORE
 	tristate "Qualcomm PM8921 PMIC chip"
-	depends on SSBI
+	depends on SSBI && BROKEN
 	select MFD_CORE
 	select MFD_PM8XXX
 	help
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation