Skip to contentSkip to conversation

arm: prima2: export sirfsoc_reset_device as the common API of drivers

PATCH New Barry Song 3 participants 3 messages Mar 27, 2013 – Mar 29, 2013

Subsystems (2)
lore
Share & tools
lore

Barry Song

author
#0 lore raw

PATCH 1/1 arm: prima2: export sirfsoc_reset_device as the common API of drivers

From: "renwei.wu" <[email protected]>

sirfsoc_reset_device() should be an API used by other SiRF drivers. This patch exports it.
devices who want to reset just need to add reset_bit in .dts.

---
 arch/arm/mach-prima2/rstc.c |    1 +
 include/linux/sirfsoc_rst.h |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 include/linux/sirfsoc_rst.h
arch/arm/mach-prima2/rstc.c +1 -0
index 435019c..6c40913 100644
@@ -79,6 +79,7 @@ int sirfsoc_reset_device(struct device *dev)
 
 	return 0;
 }
+EXPORT_SYMBOL(sirfsoc_reset_device);
 
 #define SIRFSOC_SYS_RST_BIT  BIT(31)
 
include/linux/sirfsoc_rst.h new file +6 -0
new file mode 100644
index 0000000..b29017a
@@ -0,0 +1,6 @@
+#ifndef _SIRFSOC_RST_H_
+#define _SIRFSOC_RST_H_
+
+int sirfsoc_reset_device(struct device *dev);
+
+#endif
Signature · 6 lines
1.7.5.4



Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom
More information can be found at www.csr.com. Follow CSR on Twitter at http://twitter.com/CSR_PLC and read our blog at www.csr.com/blog
#1 lore raw

PATCH 1/1 arm: prima2: export sirfsoc_reset_device as the common API of drivers

Quoted 8 lines · Barry Song

From: "renwei.wu" <[email protected]>

sirfsoc_reset_device() should be an API used by other SiRF drivers. This patch exports it.
devices who want to reset just need to add reset_bit in .dts.

The interface is currently not used in the mainline kernel, and having a global header for it is not a good solution in the long run. Please have a look at the patches labeled "Reset controller API to reset IP modules on i.MX5 and i.MX6" from Philipp Zabel and coordinate with him or base your own drivers on his code when you get it upstream.

Arnd

#2 lore raw

PATCH 1/1 arm: prima2: export sirfsoc_reset_device as the common API of drivers

2013/3/29 Arnd Bergmann <[email protected]>

Quoted 11 lines · Barry Song
Quoted 8 lines

From: "renwei.wu" <[email protected]>

sirfsoc_reset_device() should be an API used by other SiRF drivers. This patch exports it.
devices who want to reset just need to add reset_bit in .dts.

Quoted 6 lines

The interface is currently not used in the mainline kernel, and having a global header for it is not a good solution in the long run. Please have a look at the patches labeled "Reset controller API to reset IP modules on i.MX5 and i.MX6" from Philipp Zabel and coordinate with him or base your own drivers on his code when you get it upstream.

well. happy to see there is another subsystem about reset_controller. that should remove the requirement of sirfsoc specific reset api.

Quoted 2 lines

Arnd

-barry