iommu/amd: Make sure dma_ops are set for hotplug devices
Subsystems (2)
Joerg Roedel
maintainerPATCH 1/1 iommu/amd: Make sure dma_ops are set for hotplug devices
There is a bug introduced with commit 27c2127 that causes devices which are hot unplugged and then hot-replugged to not have per-device dma_ops set. This causes these devices to not function correctly. Fixed with this patch.
Signed-off-by Joerg Roedel <[email protected]>
--- drivers/iommu/amd_iommu.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-)
drivers/iommu/amd_iommu.c +10 -12
@@ -2466,18 +2466,16 @@ static int device_change_notifier(struct notifier_block *nb,/* allocate a protection domain if a device is added */ dma_domain =find_protection_domain (devid); -if (dma_domain) - goto out; - dma_domain =dma_ops_domain_alloc (); -if (!dma_domain) - goto out; - dma_domain->target_dev = devid; - -spin_lock_irqsave (&iommu_pd_list_lock, flags); -list_add_tail (&dma_domain->list, &iommu_pd_list); -spin_unlock_irqrestore (&iommu_pd_list_lock, flags); - - dev_data =get_dev_data (dev); +if (!dma_domain) { + dma_domain =dma_ops_domain_alloc (); +if (!dma_domain) + goto out; + dma_domain->target_dev = devid; + +spin_lock_irqsave (&iommu_pd_list_lock, flags); +list_add_tail (&dma_domain->list, &iommu_pd_list); +spin_unlock_irqrestore (&iommu_pd_list_lock, flags); + } dev->archdata.dma_ops = &amd_iommu_dma_ops;
Signature · 1 line
1.7.9.5